Created
May 2, 2016 17:16
-
-
Save kaosf/2a36fa8629b994166d42ca60ca944118 to your computer and use it in GitHub Desktop.
Rubocop log at the shirasagi repository commit of https://github.com/toyodundy/shirasagi/commit/3818b5715d3ce13272e1b810eeb32e6edf7e45cb for @toyodundy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/models/concerns/article/addon/import.rb:2:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:4:3: C: Module has too many lines. [210/166] | |
module Import ... | |
^^^^^^^^^^^^^ | |
app/models/concerns/article/addon/import.rb:5:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:8:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:15:5: W: Useless public access modifier. | |
public | |
^^^^^^ | |
app/models/concerns/article/addon/import.rb:16:7: C: Assignment Branch Condition size for to_csv is too high. [61.04/61] | |
def to_csv | |
^^^ | |
app/models/concerns/article/addon/import.rb:18:130: C: Line is too long. [263/129] | |
data << %w(id name file_name layout order keywords description summary_html html categories event_name event_dates contact_state contact_group contact_charge contact_tel contact_fax contact_email released release_date close_date groups permission_level) | |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
app/models/concerns/article/addon/import.rb:52:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:56:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:69:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:73:3: W: Useless public access modifier. | |
public | |
^^^^^^ | |
app/models/concerns/article/addon/import.rb:73:3: C: Indent access modifiers like public. | |
public | |
^^^^^^ | |
app/models/concerns/article/addon/import.rb:77:22: C: Trailing whitespace detected. | |
validate_import | |
^ | |
app/models/concerns/article/addon/import.rb:78:40: C: Trailing whitespace detected. | |
return false unless errors.empty? | |
^^ | |
app/models/concerns/article/addon/import.rb:87:3: C: Indent access modifiers like private. | |
private | |
^^^^^^^ | |
app/models/concerns/article/addon/import.rb:95:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:97:59: C: Trailing whitespace detected. | |
return errors.add :in_file, :blank if in_file.blank? | |
^ | |
app/models/concerns/article/addon/import.rb:98:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:99:40: C: Trailing whitespace detected. | |
fname = in_file.original_filename | |
^ | |
app/models/concerns/article/addon/import.rb:108:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:109:5: C: Assignment Branch Condition size for update_row is too high. [125.7/61] | |
def update_row(row, index) | |
^^^ | |
app/models/concerns/article/addon/import.rb:109:5: C: Method has too many lines. [93/42] | |
def update_row(row, index) ... | |
^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
app/models/concerns/article/addon/import.rb:109:5: C: Perceived complexity for update_row is too high. [17/14] | |
def update_row(row, index) | |
^^^ | |
app/models/concerns/article/addon/import.rb:139:10: C: Trailing whitespace detected. | |
end | |
^ | |
app/models/concerns/article/addon/import.rb:150:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:153:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:162:1: C: Trailing whitespace detected. | |
app/models/concerns/article/addon/import.rb:205:27: C: Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead. | |
item.updated = Time.now | |
^^^ | |
app/models/concerns/article/addon/import.rb:232:11: C: Use self-assignment shorthand +=. | |
depth = depth + 1 | |
^^^^^^^^^^^^^^^^^ | |
app/models/concerns/article/addon/import.rb:245:30: C: Trailing whitespace detected. | |
item.category_ids = ids | |
^ | |
app/models/concerns/article/addon/import.rb:294:69: C: Trailing whitespace detected. | |
unless permission_level.to_i >= 1 && permission_level.to_i <=3 | |
^ | |
app/models/concerns/article/addon/import.rb:316:4: C: Trailing whitespace detected. | |
end | |
^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment