karmi · November 5, 2009 08:48
diff --git a/Comments b/Comments
 # WebPage uses cache??? What the heck is cache in context of a webpage crawling process? It should only crawl pages. You need to inject some dummy cache to prevent caching. 

 Yeah, that's the assignment as I see it? The crawler crawls and caches stuff it has found and parsed. Your comments are cryptic .)
 
 # thumnail generation is an expensive job, thus lazy-loading. But you are not saving already generated thumbnails in cache. :(

 I guess it's pretty obvious the thumbnail stuff is just for illustration, isn't it? But yeah, definitely it should save the generated thumbnail in the cache! But guess what, probably in some hypothetic Thumbnail class? Not in WebPage class?
	# WebPage uses cache??? What the heck is cache in context of a webpage crawling process? It should only crawl pages. You need to inject some dummy cache to prevent caching.

	Yeah, that's the assignment as I see it? The crawler crawls and caches stuff it has found and parsed. Your comments are cryptic .)

	# thumnail generation is an expensive job, thus lazy-loading. But you are not saving already generated thumbnails in cache. :(

	I guess it's pretty obvious the thumbnail stuff is just for illustration, isn't it? But yeah, definitely it should save the generated thumbnail in the cache! But guess what, probably in some hypothetic Thumbnail class? Not in WebPage class?