Skip to content

Instantly share code, notes, and snippets.

@khanghoang
Last active January 13, 2016 10:26
Show Gist options
  • Save khanghoang/984c3a4031be0170ff32 to your computer and use it in GitHub Desktop.
Save khanghoang/984c3a4031be0170ff32 to your computer and use it in GitHub Desktop.
changes

####Breaking changes:

  • Change how we import files (from global variables using <script />in index.html to webpack modules import).
  • Now the ENV variables by passing them from gulp to webpack (check the webpack.config.js).
  • Change the command to run in native from gulp build-SG-en --config native to gulp build-SG-en --type native.

Why? To use the webpack ENV variable

####Improve:

  • Console log will show you where the data comes from (Mock Data vs Mock Server). Log

####Remaining problems:

  • We are using window in many places in code for 2 reason:
    • Some functions are broswer's, e.g window.atob, window.btoa
    • Native apps use the eval to call javascript function on global variables, e.g QSNativeUIEventDispatcher.swift line 47.
  • There are some files which are included by <script /> in index.html, we gonna move them when we touch them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment