Created
June 17, 2018 20:05
-
-
Save kopylovvlad/119e46154ea9b943a16056b353ac702d to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Before | |
# Metrics/MethodLength: Method has too many lines. [13/10] | |
def foo1(number) | |
if number == 1 | |
'one' | |
elsif number == 2 | |
'two' | |
elsif number == 3 | |
'three' | |
elsif number == 4 | |
'four' | |
elsif number == 5 | |
'five' | |
else | |
'many' | |
end | |
end | |
# After | |
DICTIONARY = { | |
1 => 'one', | |
2 => 'two', | |
3 => 'three', | |
4 => 'four', | |
5 => 'five' | |
}.freeze | |
def foo2(number) | |
DICTIONARY[number] || 'many' | |
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DICTIONARY.fetch(number, 'many')