Marcin Krzyzanowski krzyzanowskim

According to documentation it's enough to override NSResponder.undoManager to provide custom NSUndoManager instance. I found it's not quite working:

Xcode Mac application template comes with Undo menu item bind to firstResponder.undo: despite NSResponder has no undo: selector defined. Unless first responder actually respond to undo: the Undo action doesn't work
NSFirstResponder.undoManager look up in responder chain and eventually it end up in NSWindow where the only place (that I found) that validate Undo menu item is NSWindow.validateUserInterfaceItem - that one, as turned out, only ever validate undo: action if first responder implements _getUndoManager: selector (quite private, isn't it?) - see attached disassembly

at this point 🤕 I start to think it's either documentation issue, or AppKit implementation issue. Anyway, I didn't found way to enable undo: action unless I implement one of these methods in my NSView. (notice: the view is first responder tha

	name: auto-format
	on: pull_request
	jobs:
	format:
	# Check if the PR is not from a fork
	if: github.event.pull_request.head.repo.full_name == github.repository
	runs-on: ubuntu-latest
	steps:
	- uses: actions/checkout@v3
	with:

	struct ContentView: View {
	@State var color: Color = .Pastel.random()

	var body: some View {
	Rectangle()
	.foregroundColor(color)
	.onTapGesture {
	color = .Pastel.random()
	}
	}

	// Usage

	@MainActor
	final class AppSettings: ObservableObject {

	static let standard = AppSettings()

	@Published(preferenceKey: AppSettingsKey.editorHighlightSelectedLine)
	var editorHighlightSelectedLine: Bool = true
	}

	import AppKit
	import SwiftUI

	/*
	Text("Menu")
	.popUpMenu {
	NSMenuItem(title: "One", action: nil, keyEquivalent: "")
	NSMenuItem(title: "Two", action: nil, keyEquivalent: "")
	}
	*/

	struct VisualEffectView: NSViewRepresentable {
	let material: NSVisualEffectView.Material
	let blendingMode: NSVisualEffectView.BlendingMode

	init(material: NSVisualEffectView.Material, blendingMode: NSVisualEffectView.BlendingMode = .withinWindow) {
	self.material = material
	self.blendingMode = blendingMode
	}

	func makeNSView(context: Context) -> NSVisualEffectView {

	public struct OptionSetIterator<Element: OptionSet>: IteratorProtocol where Element.RawValue == Int {
	private let value: Element

	init(element: Element) {
	self.value = element
	}

	private lazy var remainingBits = value.rawValue
	private var bitMask = 1

	/// Wait for async operation to return value and call callback with the value
	/// This class is intended to workaround/simplify async/await + actors isolation
	/// https://twitter.com/krzyzanowskim/status/1523233140914876416
	private class AsyncWaiter<T> {
	var didReceiveValue: Bool = false
	let value: (T) -> Void
	let operation: () async throws -> T

	init(_ value: @escaping (T) -> Void, operation: @escaping () async throws -> T) {
	self.value = value

	extension String {
	func stride(by distance: String.IndexDistance, substring: (String.SubSequence) -> Void) {
	guard distance > 0, distance < count else {
	substring(self[...])
	return
	}

	var i = index(startIndex, offsetBy: distance, limitedBy: endIndex) ?? endIndex
	var previ = startIndex
	while i < endIndex {

	struct SharingServicePicker: NSViewRepresentable {
	@Binding var isPresented: Bool
	var items: [Any] = []

	func makeNSView(context: Context) -> NSView {
	let view = NSView()
	view.translatesAutoresizingMaskIntoConstraints = false
	return view
	}