Kyle Stevens kstevens715

Monday, August 28, 2017

Yesterday

WA-4929 / NF-18593 was merged and Michael verified it.
Made good progress on NF-14938:
- Changed the designation/requirements job introduced in WA-4929 to work by applicant to not double process requirements owned by multiple programs and to take advantage of more eager loading and caching.
- Found out that the join table between programs and requirements allows duplicates, and actually there are 428k join records but only 64k of them are unique. Without doing anything, we would be processing records based on the extra joins so I made sure we were only processing unique jobs.
Made a "performance" / integration type test that performs the job and counts the number of SQL queries executed since it's a good

Here are things I would like to see to give this PR a plus-one. Please make updates to this PR or let me know why they cannot or should not be done and then I will re-review.

https://github.com/Liaison-Intl/WebAdMIT/pull/6424#discussion_r114338147 Explain desired change. Justify requested change. The link in the beginning is to a specific comment with more details and GitHub minifies it to look good.
Another change request

On ETL K8:

failures = Resque::Failure.all(0, Resque::Failure.count).map { |f| f["payload"]["args"][0].gsub("applicant/", "").split("/") }.reject { |j| j[0] =~ /gpa/ }
file = File.open('/tmp/applicants.txt', 'w')
failures.each { |failure| file.write("#{failure[0]},#{failure[1]}\n") }

On local host

kubectl cp wa-etl-resque-web-386939940-dp406:/tmp/applicants.txt applicants.txt

	require 'tempfile'

	t = Tempfile.new
	t.write('data')

	t.close # comment out to see difference

	if File.open(t.path).read == 'data'
	puts 'Tempfile was complete'
	else

	#!/usr/bin/env ruby
	# Usage:
	# To search for all occurrences in history of text "perform" in app/models/model.rb:
	#
	# git search-file-history perform app/models/model.rb
	#
	# TODO: A good future enhancement would be to show the commit right after the last occurrence, to see where it was removed.
	#
	text, filename = ARGV

	require "test_helper"
	require "support/matchers/scopes"
	require "support/double_helpers"

	describe Applicant do
	it do
	deprecation_warnings_for_file('app/models/applicant.rb').length.must_equal 0
	end

	private

	require 'benchmark'

	class Lots
	def run
	time = Benchmark.realtime do
	10_000.times do \|n\|
	n = n.to_s
	puts n
	l = GlobalLookup.new(identifier: n, name: n)
	l.type = 'TempTest2'

	module Documents
	class Loader
	def initialize(current_user_identity, current_organization, applicant, programs)
	@current_user_identity = current_user_identity
	@current_organization = current_organization
	@applicant = applicant
	@programs = programs
	@panels = {}
	end

	require "test_helper"
	require "csv_parser"
	require "support/reports_unit_test_helper"
	require "benchmark"

	describe Reports::HighSchoolCourseworkReport do
	let(:described_class) { Reports::HighSchoolCourseworkReport }

	def random_word(l)
	(0...l).map { (65 + rand(26)).chr }.join