Last active
May 10, 2016 11:39
-
-
Save kvz/a566ba3be4a3faf7d6e6 to your computer and use it in GitHub Desktop.
Proposal for (partial) template includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | |
| include_template: "a", // <-- full template, used as a base | |
| is_video: { | |
| use: ":original", | |
| robot: "/file/filter", | |
| accepts: [ | |
| [ | |
| "${file.mime}", | |
| "regex", | |
| "video" | |
| ], | |
| ], | |
| error_on_decline:false | |
| }, | |
| is_image: { | |
| use: ":original", | |
| robot: "/file/filter", | |
| accepts: [ | |
| [ | |
| "${file.mime}", | |
| "regex", | |
| "image", | |
| ], | |
| ], | |
| error_on_decline: false | |
| }, | |
| include_template_partial: "c.video_encode", // <-- include just 1 named step | |
| video_encode: { | |
| use: "is_video", // <-- override its `use` parameter to connect the chain | |
| }, | |
| include_template_partial: "c.image_resize", | |
| image_resize: { | |
| use: "is_image", | |
| }, | |
| store: { // <-- was already inside template "a" | |
| // <-- override its `use` parameter to connect the chain | |
| use: ["video_encode", "image_resize", ":original"], | |
| }, | |
| } |
Author
@Prinzhorn I see where the two diverge now, your approach is interesting and easier to add indeed. I'll discuss with the team if I'm not overlooking anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a similar idea last week but it's basically not THAT similar https://gist.github.com/Prinzhorn/8af8b7f56d72431f9945552bca06f962
I just want to keep things DRY and think that would be something that can be added really easily. Basically with the exact same logic that we already have when sending
stepsalong with the upload (it's just a matter of merging those objects).To be honest looking at the json in this gist it's not obvious to me what it's supposed to do. I get the idea that having public templates would be beneficial for everyone, but then the templates on transloadit are not self contained any more and I need to do a shitton of work in my head to put everything together. You wouldn't be able to understand the template just by looking at it.