Skip to content

Instantly share code, notes, and snippets.

@lamperez
Last active November 11, 2024 11:16
Show Gist options
  • Save lamperez/862763881c0e1c812392b5574727f6ff to your computer and use it in GitHub Desktop.
Save lamperez/862763881c0e1c812392b5574727f6ff to your computer and use it in GitHub Desktop.
CS35L41 amplifiers in an ASUS Zenbook on linux

Asus Zenbook UX3402 speakers on Linux

Important

THIS IS NOW OBSOLETE WITH KERNEL VERSIONS ≥ 6.7.0

A recent announcement in the kernel mail list by Cirrus developers will solve the problem described here. Therefore, the proposed solutions will be soon obsolete. See this comment (thanks, @flukejones, for the tip).

I got the speakers working on my Asus Zenbook 14 OLED UX3402, the one with Intel CPU and the two CS35L41 audio amplifiers connected over SPI (not the UM3402YA, with AMD and I²C). The amplifiers are supported by the snd_hda_scodec_cs35l41 module in recent kernel versions, but they require some model-specific configuration paramaters, that should be provided by the BIOS, via ACPI. Of course, they are missing. It seems that the Windows drivers have those parameters somehow hardcoded, instead of using ACPI (bad idea, but who am I to criticise). Since Asus has been nasty and refused/was not able to update the BIOS with the missing data, I have patched the ACPI tables myself.

Warning

As stated by Cirrus developers, if you try this there is a non-zero (low, I hope) possibility of blowing your speakers. Take into account that this procedure is not just configuring your box, it is hardware-level hacking with very scarce information about the hardware (thank you, ASUS, and thank you, Cirrus, for not publishing the CS35L41 datasheet and making it only available by request). Additionally, You should know how to work with DSDT or SSDT files (I have a brief guide here) and how to recover from a non booting system. You are on your own. You have been warned.

Note

I have used the patch for some months, and everything seems OK. As you can see, the most recent versions do not require electrical parameters to be specified, just providing the functions of several GPIO pins, that are already present in the original BIOS, and the behavior associated to them. I am almost sure that the patch is totally safe.

My BIOS is the most recent one (version 310). I have added two _DSD objects in the SSDT file (ssdt_csc3551.dsl, or its already assembled version, ssdt_csc3551.aml):

  • One inside the SPK1 device, providing the missing "cirrus,dev-index" and other properties, just like the I2C models. You can also provide these properties by patching the kernel module (the linux/sound/pci/hda/cs35l41_hda.c file).

  • Another one, after the SPK1 device, with the chip select GPIOs, "cs-gpios", required by the SPI bus (the somehow simpler I²C bus does not use chip select pins, but addresses). Without this _DSD object, only one amplifier can be addressed and activated. In this case, the driver refuses to load even for this single working amplifier.

Obsolete: DSDT patch

Instead of applying a SSDT file, you may patch the full DSDT dissassembled DSDT file (dsdt.dsl). This was my original solution (thanks to @thor2002ro for pointing to the simpler, nicer SSDT solution, see the comment, especially if you use grub). The patch is available for reference, just apply the SSDT file.

Obsolete: internal boost

I keep the old, original patch, that produced AMP short error messages when the volume was high enough, for reference. Please try first the simpler patch with external boost, that seems to work without flaws (thanks to @bdandy, see the comment).

Boot log

Output from journalctl -b -g CSC3551 --output short-monotonic after the old patch:

[5.358062] zenbook kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 SPI devices.
[5.643640] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Cirrus Logic CS35L41 (35a40), Revision: B2
[5.680302] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2
[5.996217] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Falling back to default firmware.
[5.996608] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: Firmware version: 3
[5.996611] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: cirrus/cs35l41-dsp1-spk-prot.wmfw: Fri 24 Jun 2022 14:55:56 GMT Daylight Time
[6.069598] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: Firmware: 400a4 vendor: 0x2 v0.58.0, 2 algorithms
[6.070173] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: 0: ID cd v29.78.0 XM@94 YM@e
[6.070185] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: 1: ID f20b v0.1.0 XM@17c YM@0
[6.070192] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: spk-prot: e:\workspace\workspace\tibranch_release_playback_6.76_2\ormis\staging\default_tunings\internal\CS35L53\Fixed_Attenuation_Mono_48000_29.78.0\full\Fixed_Attenuation_Mono_48000_29.78.0_full.bin
[6.083485] zenbook kernel: snd_hda_codec_realtek ehdaudio0D0: bound spi1-CSC3551:00-cs35l41-hda.0 (ops cs35l41_hda_comp_ops [snd_hda_scodec_cs35l41])
[6.083899] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Falling back to default firmware.
[6.083962] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: Firmware version: 3
[6.083966] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: cirrus/cs35l41-dsp1-spk-prot.wmfw: Fri 24 Jun 2022 14:55:56 GMT Daylight Time
[6.145224] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: Firmware: 400a4 vendor: 0x2 v0.58.0, 2 algorithms
[6.145817] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: 0: ID cd v29.78.0 XM@94 YM@e
[6.145828] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: 1: ID f20b v0.1.0 XM@17c YM@0
[6.145834] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: spk-prot: e:\workspace\workspace\tibranch_release_playback_6.76_2\ormis\staging\default_tunings\internal\CS35L53\Fixed_Attenuation_Mono_48000_29.78.0\full\Fixed_Attenuation_Mono_48000_29.78.0_full.bin
[6.161484] zenbook kernel: snd_hda_codec_realtek ehdaudio0D0: bound spi1-CSC3551:00-cs35l41-hda.1 (ops cs35l41_hda_comp_ops [snd_hda_scodec_cs35l41])

The "Falling back to default firmware" disappears if spk-id-gpios are provided (the block is commented in the patch). As a result, a different firmware is loaded, resulting in very low volume and strong distortion. If the new patch is used, that uses external boost, the sound is correct, and the log is

[0.004000] zenbook kernel: ACPI: Table Upgrade: install [SSDT-CUSTOM- CSC3551]
[0.004000] zenbook kernel: ACPI: SSDT 0x00000000368FD000 0001A0 (v01 CUSTOM CSC3551  00000001 INTL 20200925)
[5.607253] zenbook kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 SPI devices.
[5.906936] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Cirrus Logic CS35L41 (35a40), Revision: B2
[5.907354] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Reset line busy, assuming shared reset
[5.938136] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2
[6.239406] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: Firmware version: 3
[6.239415] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: cirrus/cs35l41-dsp1-spk-prot-10431e02.wmfw: Fri 27 Aug 2021 14:58:19 W. Europe Daylight Time
[6.313109] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: Firmware: 400a4 vendor: 0x2 v0.43.1, 2 algorithms
[6.313524] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: 0: ID cd v29.63.1 XM@94 YM@e
[6.313530] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: 1: ID f20b v0.1.0 XM@176 YM@0
[6.313535] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: DSP1: spk-prot: C:\Users\tyang\Desktop\Product Setting\SmartAMP\ASUS\ASUS_Zenbook\UX3402\Tuning Release\220304\ASUS_UX3402_L_tuning_IDYC_ReDc_PICL_RTL_0304.bin
[6.337211] zenbook kernel: snd_hda_codec_realtek ehdaudio0D0: bound spi1-CSC3551:00-cs35l41-hda.0 (ops cs35l41_hda_comp_ops [snd_hda_scodec_cs35l41])
[6.337534] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: Firmware version: 3
[6.337540] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: cirrus/cs35l41-dsp1-spk-prot-10431e02.wmfw: Fri 27 Aug 2021 14:58:19 W. Europe Daylight Time
[6.399070] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: Firmware: 400a4 vendor: 0x2 v0.43.1, 2 algorithms
[6.399612] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: 0: ID cd v29.63.1 XM@94 YM@e
[6.399623] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: 1: ID f20b v0.1.0 XM@176 YM@0
[6.399629] zenbook kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: DSP1: spk-prot: C:\Users\tyang\Desktop\Product Setting\SmartAMP\ASUS\ASUS_Zenbook\UX3402\Tuning Release\220304\ASUS_UX3402_R_tuning_IDYC_ReDc_PICL_RTL_0304.bin
[6.427637] zenbook kernel: snd_hda_codec_realtek ehdaudio0D0: bound spi1-CSC3551:00-cs35l41-hda.1 (ops cs35l41_hda_comp_ops [snd_hda_scodec_cs35l41])
--- dsdt.dsl.old 2023-03-26 01:06:48.845795666 +0100
+++ dsdt.dsl 2023-03-26 12:00:45.643851841 +0200
@@ -18,7 +18,7 @@
* Compiler ID "INTL"
* Compiler Version 0x20200717 (538969879)
*/
-DefinitionBlock ("", "DSDT", 2, "_ASUS_", "Notebook", 0x01072009)
+DefinitionBlock ("", "DSDT", 2, "_ASUS_", "Notebook", 0x0107200A)
{
/*
* iASL Warning: There were 233 external control methods found during
@@ -90642,7 +90642,48 @@
Method (_DIS, 0, NotSerialized) // _DIS: Disable Device
{
}
+
+ Name (_DSD, Package () // _DSD: Device-Specific Data
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "cirrus,dev-index", Package () { Zero, One }},
+ Package () { "reset-gpios", Package () {
+ SPK1, One, Zero, Zero,
+ SPK1, One, Zero, Zero,
+ } },
+ // Package () { "spk-id-gpios", Package () {
+ // SPK1, 0x02, Zero, Zero,
+ // SPK1, 0x02, Zero, Zero,
+ // } },
+ Package () { "cirrus,speaker-position", Package () { Zero, One } },
+ Package () { "cirrus,gpio1-func", Package () { Zero, Zero } },
+ Package () { "cirrus,gpio2-func", Package () { 0x02, 0x02 } },
+ // boost-type: 0 internal, 1 external
+ Package () { "cirrus,boost-type", Package () { Zero, Zero } },
+ // boost-peak-milliamp: 1600 to 4500, increments of 50 mA
+ Package () { "cirrus,boost-peak-milliamp", Package () { 4500, 4500 } },
+ // boost-ind-nanohenry: 1000 | 1200 | 1500 | 2200 nH
+ Package () { "cirrus,boost-ind-nanohenry", Package () { 1000, 1000 } },
+ // boost-cap-microfarad: rounded to the nearest integer
+ Package () { "cirrus,boost-cap-microfarad", Package () { 24, 24 } },
+ },
+ })
}
+
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "cs-gpios", Package () {
+ Zero, // Native CS
+ SPK1, Zero, Zero, Zero // GPIO CS
+ } }
+ }
+ })
+
}
Scope (_SB.PC00.LPCB)
--- dsdt.dsl.old 2023-03-26 01:06:48.845795666 +0100
+++ dsdt.dsl 2023-03-26 12:00:45.643851841 +0200
@@ -18,7 +18,7 @@
* Compiler ID "INTL"
* Compiler Version 0x20200717 (538969879)
*/
-DefinitionBlock ("", "DSDT", 2, "_ASUS_", "Notebook", 0x01072009)
+DefinitionBlock ("", "DSDT", 2, "_ASUS_", "Notebook", 0x0107200A)
{
/*
* iASL Warning: There were 233 external control methods found during
@@ -90642,7 +90642,43 @@
Method (_DIS, 0, NotSerialized) // _DIS: Disable Device
{
}
+
+ Name (_DSD, Package () // _DSD: Device-Specific Data
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "cirrus,dev-index", Package () { Zero, One }},
+ Package () { "reset-gpios", Package () {
+ SPK1, One, Zero, Zero,
+ SPK1, One, Zero, Zero,
+ } },
+ Package () { "spk-id-gpios", Package () {
+ SPK1, 0x02, Zero, Zero,
+ SPK1, 0x02, Zero, Zero,
+ } },
+ Package () { "cirrus,speaker-position", Package () { Zero, One } },
+ // gpioX-func: 0 not used, 1 VPSK_SWITCH, 2: INTERRUPT, 3: SYNC
+ Package () { "cirrus,gpio1-func", Package () { One, One } },
+ Package () { "cirrus,gpio2-func", Package () { 0x02, 0x02 } },
+ // boost-type: 0 internal, 1 external
+ Package () { "cirrus,boost-type", Package () { One, One } },
+ },
+ })
}
+
+ Name (_DSD, Package ()
+ {
+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package ()
+ {
+ Package () { "cs-gpios", Package () {
+ Zero, // Native CS
+ SPK1, Zero, Zero, Zero // GPIO CS
+ } }
+ }
+ })
+
}
Scope (_SB.PC00.LPCB)
DefinitionBlock ("", "SSDT", 1, "CUSTOM", "CSC3551", 0x00000001)
{
External (_SB_.PC00.SPI0, DeviceObj)
External (_SB_.PC00.SPI0.SPK1, DeviceObj)
Scope (_SB.PC00.SPI0.SPK1)
{
Name (_DSD, Package ()
{
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package () { "cirrus,dev-index", Package () { Zero, One }},
Package () { "reset-gpios", Package () {
SPK1, One, Zero, Zero,
SPK1, One, Zero, Zero
} },
Package () { "spk-id-gpios", Package () {
SPK1, 0x02, Zero, Zero,
SPK1, 0x02, Zero, Zero
} },
Package () { "cirrus,speaker-position", Package () { Zero, One } },
// gpioX-func: 0 not used, 1 VPSK_SWITCH, 2: INTERRUPT, 3: SYNC
Package () { "cirrus,gpio1-func", Package () { One, One } },
Package () { "cirrus,gpio2-func", Package () { 0x02, 0x02 } },
// boost-type: 0 internal, 1 external
Package () { "cirrus,boost-type", Package () { One, One } }
}
})
}
Scope (_SB.PC00.SPI0)
{
Name (_DSD, Package ()
{
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package ()
{
Package () { "cs-gpios", Package () {
Zero, // Native CS
SPK1, Zero, Zero, Zero // GPIO CS
} }
}
})
}
}
@lamperez
Copy link
Author

lamperez commented Jun 6, 2023

It seems strange, since the devices are called i2c-CSC3551:00-cs35l41-hda.0 (and 1). To my understanding, the kernel only tries to load the cs35l41-hda module if the ACPI device is called CLSA0100, CLSA0101 or CSC3551, as you can see in the source file (for SPI connected devices, only the last one).

@PoSayDone
Copy link

PoSayDone commented Jun 9, 2023

Not working for me with ux3402va

[    0.009317] ACPI: Table Upgrade: install [SSDT-CUSTOM- CSC3551]
[    0.009318] ACPI: SSDT 0x0000000036E63000 0001A0 (v01 CUSTOM CSC3551  0000000A INTL 20200925)
[    3.437382] cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Cirrus Logic CS35L41 (35a40), Revision: B2
[    3.478326] cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Reset line busy, assuming shared reset
[    3.511465] cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2
[    3.511517] Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 SPI devices.

Used SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2). I have a chinese version, so maybe I need to use another id? How could I find out which one I need to use?

@PoSayDone
Copy link

Installed sof-firmware package and now everything works!

@JulienQNN
Copy link

The Tables modifications and Updating to Kernel: 6.3.7-arch1-1 today made everything working thanks again for this great work @lamperez

@PoSayDone
Copy link

Maybe someone familiar with contributing to kernel could submit this patch to make ux3402va also work?
https://gist.github.com/PoSayDone/ec01ba84e5aad40f229b034f6beec5d9

@ruineka
Copy link

ruineka commented Jun 15, 2023

It looks like the Asus Ally has the same missing fields....How exactly did you know what values to use?

@tghe-retford
Copy link

Thank you for the patch and @lamperez for the explanation as to what steps to take to attempt to get this to work. I have a ASUS ROG Strix G733PZ which is also missing the DSD properties. I followed the guide, created the CPIO file and booted into Arch Linux. The kernel can now see the device. I also installed sol-firmware but I still get no sound. So it will need the laptop adding to the driver's sound PCI quirk section (at this time by compiling the kernel which I haven't got round to yet due to work commitments).

To save anyone in the future the work I did, the laptop's ID for the two buses is the same as in the guide, the speakers are referred to as SPKR and the amps are on i2c so the sound PCI quirk line should be:

SND_PCI_QUIRK(0x1043, 0x1503, "ASUS ROG Strix G733PZ", ALC287_FIXUP_CS35L41_I2C_2),

I'm not familiar with submitting patches to the kernel but hopefully this helps in the investigation to get other people's speakers working.

@ruineka
Copy link

ruineka commented Jun 18, 2023

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

@Moooebie
Copy link

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

@ruineka
Copy link

ruineka commented Jun 18, 2023

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

What errors are you getting in your log?

@Moooebie
Copy link

Moooebie commented Jun 18, 2023

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

What errors are you getting in your log?

Like this:

Jun 18 19:53:51 mx3340-tbplus kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 I2C devices.
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Failed waiting for OTP_BOOT_DONE: -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda: probe of i2c-CSC3551:00-cs35l41-hda.0 failed with error -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2

@ruineka
Copy link

ruineka commented Jun 18, 2023

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

What errors are you getting in your log?

Like this:

Jun 18 19:53:51 mx3340-tbplus kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 I2C devices.
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Failed waiting for OTP_BOOT_DONE: -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda: probe of i2c-CSC3551:00-cs35l41-hda.0 failed with error -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2

Oh, I fixed that. You must have this

                Package () { "reset-gpios", Package () {
                    SPKR, One, Zero, Zero,
                    SPKR, One, Zero, Zero
                } },

to fix it do this

                Package () { "reset-gpios", Package () {
                    SPKR, Zero, Zero, Zero,
                    SPKR, Zero, Zero, Zero
                } },

@ruineka
Copy link

ruineka commented Jun 18, 2023

I believe I just fixed the restart problem as well. I had some stuff at /etc/modprobe.d/alsa-base.conf I commented it out and rebooted and it's working now with reboot and shutdown.

@Moooebie
Copy link

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

What errors are you getting in your log?

Like this:

Jun 18 19:53:51 mx3340-tbplus kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 I2C devices.
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Failed waiting for OTP_BOOT_DONE: -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda: probe of i2c-CSC3551:00-cs35l41-hda.0 failed with error -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2

Oh, I fixed that. You must have this

                Package () { "reset-gpios", Package () {
                    SPKR, One, Zero, Zero,
                    SPKR, One, Zero, Zero
                } },

to fix it do this

                Package () { "reset-gpios", Package () {
                    SPKR, Zero, Zero, Zero,
                    SPKR, Zero, Zero, Zero
                } },

This fixed the problem. Thanks!

@ruineka
Copy link

ruineka commented Jun 18, 2023

Anyone else here have i2c and have it where you won't have sound during reboots and if you do a full power restart (hold power button) then the sound will work again? Another way to get it working is to do three reboots. I suspected it was the GPIO reset but I'm not so sure.

I have the same issue (also i2c), but not necessarily a force power off by holding the power button, but simply using the "shutdown" option in the OS is enough. If the computer is rebooted then the sound will not work, there are some errors in journalctl log but I don't really have an idea about that...

What errors are you getting in your log?

Like this:

Jun 18 19:53:51 mx3340-tbplus kernel: Serial bus multi instantiate pseudo device driver CSC3551:00: Instantiated 2 I2C devices.
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.0: Failed waiting for OTP_BOOT_DONE: -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda: probe of i2c-CSC3551:00-cs35l41-hda.0 failed with error -121
Jun 18 19:53:51 mx3340-tbplus kernel: cs35l41-hda i2c-CSC3551:00-cs35l41-hda.1: Cirrus Logic CS35L41 (35a40), Revision: B2

Oh, I fixed that. You must have this

                Package () { "reset-gpios", Package () {
                    SPKR, One, Zero, Zero,
                    SPKR, One, Zero, Zero
                } },

to fix it do this

                Package () { "reset-gpios", Package () {
                    SPKR, Zero, Zero, Zero,
                    SPKR, Zero, Zero, Zero
                } },

This fixed the problem. Thanks!

Thats great! I noticed that putting the system to sleep and waking it up breaks audio for me. Can you confirm that is the case for you too? If i can resolve this then it'll be perfect on the Asus Ally.

@lamperez
Copy link
Author

The need of changing reset-gpios for i2c devices is logical. GPIO indexes are a sequence starting from zero.

For SPI devices:

  • index 0: chip select of one of the amplifiers (cs-gpios),
  • index 1: reset of both amplifiers (reset-gpios),
  • index 2: speaker id (spk-id-gpios).

For i2c devices, the chip select is missing, and therefore you must shift the others by one:

  • index 0: reset (reset-gpios)
  • index 1: speaker id (spk-id-gpios).

The audio breaking after suspend is related to the kernel module, that is the one that should restore the original state. The ACPI just provides the information to the kernel. Maybe a missing quirk for the specific model? I dunno.

@talentlessguy
Copy link

talentlessguy commented Jun 22, 2023

Is there a general instruction how to fix the sound on Zephyrus G16 GU603VV?

I just purchased the laptop and I would like to be very careful with patching anything. Which patch should I apply? Should I modify anything? Thanks in advance

Also here's my journalctl:

juuni 22 23:42:29 Asus kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Error: ACPI _DSD Properties are missing for HID CSC3551.
juuni 22 23:42:29 Asus kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: error -EINVAL: Platform not supported
juuni 22 23:42:29 Asus kernel: cs35l41-hda: probe of spi1-CSC3551:00-cs35l41-hda.0 failed with error -22
juuni 22 23:42:29 Asus kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: Error: ACPI _DSD Properties are missing for HID CSC3551.
juuni 22 23:42:29 Asus kernel: cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: error -EINVAL: Platform not supported
juuni 22 23:42:29 Asus kernel: cs35l41-hda: probe of spi1-CSC3551:00-cs35l41-hda.1 failed with error -22

I used this patch: https://github.com/thor2002ro/asus_zenbook_ux3402za/tree/main/Sound it worked!

@phamdangtrung
Copy link

Finally got my ux3402za speakers working on linux using the ssdt solution! You guys rock!!! It spits out some acpi error on boot but speakers are working normally so I guess it's fine in the long run, I hope

@SergioASantosF
Copy link

Thank you very much to everyone involved, especially to @lamperez and @thor2002ro for providing the DSDT patch and the guide to apply it!!!! It worked perfectly on the UX3402ZA.

@cw-87-tw
Copy link

cw-87-tw commented Jul 5, 2023

@SergioASantosF What guide did you follow, I tried https://github.com/thor2002ro/asus_zenbook_ux3402za/blob/main/Sound/README.md but it doesn't work. I'm also using UX3402ZA. and I followed all the guide
When I tried to update grub, here's my output

Sourcing file `/etc/default/grub'
Sourcing file `/etc/default/grub.d/init-select.cfg'
Generating grub configuration file ...
Searching for custom ACPI tables in /boot
Found custom ACPI table: /boot/ssdt-csc3551.aml
Found linux image: /boot/vmlinuz-5.19.0-46-generic
Found initrd image: /boot/initrd.img-5.19.0-46-generic
Found linux image: /boot/vmlinuz-5.19.0-32-generic
Found initrd image: /boot/initrd.img-5.19.0-32-generic
Memtest86+ needs a 16-bit boot, that is not available on EFI, exiting
Warning: os-prober will be executed to detect other bootable partitions.
Its output will be used to detect bootable binaries on them and create new boot entries.
Found Windows Boot Manager on /dev/nvme0n1p1@/EFI/Microsoft/Boot/bootmgfw.efi
Adding boot menu entry for UEFI Firmware Settings ...
done

Is that normal?

@speedy01
Copy link

speedy01 commented Jul 5, 2023

@cw-87-tw I'm having the same issue. Please post back if you find a solutions.

@SergioASantosF
Copy link

@cw-87-tw, I followed exactly the tutorial that you also tried, using the files provided by @thor2002ro , without making any modifications, and it worked here on Debian 12, Ubuntu, and Fedora 38 (which is currently installed).

I don't know if it's because I don't have dual boot, so I didn't encounter any issues with the grub update.

Since it was my first attempt and it didn't give any errors, I won't be able to help you.

@fermino
Copy link

fermino commented Jul 5, 2023

@cw-87-tw @speedy01 that output looks completely normal (it's detecting the ACPI table and it's detecting a windows installation). What issue are you having?

@speedy01
Copy link

speedy01 commented Jul 5, 2023

@fermino the issue I'm having is "still no sound" from what I can tell, grub is not loading the custom tables. even though the entry is in the grub.cfg
sudo dmesg | grep SSDT
[ 0.015492] ACPI: SSDT 0x00000000407E3000 00740E (v02 DptfTb DptfTabl 00001000 INTL 20200717)
[ 0.015499] ACPI: SSDT 0x000000004076F000 00038C (v02 PmaxDv Pmax_Dev 00000001 INTL 20200717)
[ 0.015501] ACPI: SSDT 0x0000000040769000 005D0B (v02 CpuRef CpuSsdt 00003000 INTL 20200717)
[ 0.015503] ACPI: SSDT 0x0000000040766000 002AA1 (v02 SaSsdt SaSsdt 00003000 INTL 20200717)
[ 0.015505] ACPI: SSDT 0x0000000040762000 0033D3 (v02 INTEL IgfxSsdt 00003000 INTL 20200717)
[ 0.015508] ACPI: SSDT 0x0000000040754000 00D337 (v02 INTEL TcssSsdt 00001000 INTL 20200717)
[ 0.015516] ACPI: SSDT 0x000000004074B000 005D47 (v02 ASUS AdlP_Rvp 00001000 INTL 20200717)
[ 0.015518] ACPI: SSDT 0x0000000040749000 001F1A (v02 ASUS Ther_Rvp 00001000 INTL 20200717)
[ 0.015523] ACPI: SSDT 0x0000000040744000 002A83 (v02 ASUS PtidDevc 00001000 INTL 20200717)
[ 0.015525] ACPI: SSDT 0x0000000040741000 002357 (v02 ASUS TbtTypeC 00000000 INTL 20200717)
[ 0.015532] ACPI: SSDT 0x000000004073D000 001AC9 (v02 ASUS UsbCTabl 00001000 INTL 20200717)
[ 0.015538] ACPI: SSDT 0x0000000040739000 000B35 (v02 INTEL xh_adlLP 00000000 INTL 20200717)
[ 0.015541] ACPI: SSDT 0x0000000040735000 003AEA (v02 SocGpe SocGpe 00003000 INTL 20200717)
[ 0.015543] ACPI: SSDT 0x0000000040732000 002B2A (v02 SocCmn SocCmn 00003000 INTL 20200717)
[ 0.015545] ACPI: SSDT 0x0000000040731000 000144 (v02 Intel ADebTabl 00001000 INTL 20200717)
[ 0.015567] ACPI: Reserving SSDT table memory at [mem 0x407e3000-0x407ea40d]
[ 0.015568] ACPI: Reserving SSDT table memory at [mem 0x4076f000-0x4076f38b]
[ 0.015569] ACPI: Reserving SSDT table memory at [mem 0x40769000-0x4076ed0a]
[ 0.015569] ACPI: Reserving SSDT table memory at [mem 0x40766000-0x40768aa0]
[ 0.015570] ACPI: Reserving SSDT table memory at [mem 0x40762000-0x407653d2]
[ 0.015571] ACPI: Reserving SSDT table memory at [mem 0x40754000-0x40761336]
[ 0.015573] ACPI: Reserving SSDT table memory at [mem 0x4074b000-0x40750d46]
[ 0.015573] ACPI: Reserving SSDT table memory at [mem 0x40749000-0x4074af19]
[ 0.015574] ACPI: Reserving SSDT table memory at [mem 0x40744000-0x40746a82]
[ 0.015575] ACPI: Reserving SSDT table memory at [mem 0x40741000-0x40743356]
[ 0.015577] ACPI: Reserving SSDT table memory at [mem 0x4073d000-0x4073eac8]
[ 0.015578] ACPI: Reserving SSDT table memory at [mem 0x40739000-0x40739b34]
[ 0.015579] ACPI: Reserving SSDT table memory at [mem 0x40735000-0x40738ae9]
[ 0.015579] ACPI: Reserving SSDT table memory at [mem 0x40732000-0x40734b29]
[ 0.015580] ACPI: Reserving SSDT table memory at [mem 0x40731000-0x40731143]
[ 0.230477] ACPI: SSDT 0xFFFF972441FDE400 0001AB (v02 PmRef Cpu0Psd 00003000 INTL 20200717)
[ 0.237350] ACPI: SSDT 0xFFFF97244120A400 000394 (v02 PmRef Cpu0Cst 00003001 INTL 20200717)
[ 0.238595] ACPI: SSDT 0xFFFF97244245C000 000560 (v02 PmRef Cpu0Ist 00003000 INTL 20200717)
[ 0.239782] ACPI: SSDT 0xFFFF97244245C800 0004BA (v02 PmRef Cpu0Hwp 00003000 INTL 20200717)
[ 0.241187] ACPI: SSDT 0xFFFF972441200000 001BAF (v02 PmRef ApIst 00003000 INTL 20200717)
[ 0.242975] ACPI: SSDT 0xFFFF972441204000 001038 (v02 PmRef ApHwp 00003000 INTL 20200717)
[ 0.244470] ACPI: SSDT 0xFFFF972441206000 001349 (v02 PmRef ApPsd 00003000 INTL 20200717)
[ 0.246178] ACPI: SSDT 0xFFFF972441214000 000FBB (v02 PmRef ApCst 00003000 INTL 20200717)

@fermino
Copy link

fermino commented Jul 5, 2023

@speedy01 maybe the grub cfg is being used from another location? Try pressing e in the GRUB screen and see if the ssdt line is there (press ctrl+x in that screen to boot).

@speedy01
Copy link

speedy01 commented Jul 5, 2023

@fermino thanks for the hint. when I manually entered the command, I got an error. Turns out the secure boot is preventing grub from running acpi. A workaround for me was to disable secure boot.

this also pops up...but prob nothing.
sudo journalctl -b | grep "ACPI Error"
Jul 05 13:35:59 lx-asus kernel: ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20221020/psobject-220)
Jul 05 13:35:59 lx-asus kernel: ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20221020/psobject-220)
Jul 05 13:35:59 lx-asus kernel: ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20221020/psobject-220)
Jul 05 13:35:59 lx-asus kernel: ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20221020/psobject-220)
Jul 05 13:36:01 lx-asus kernel: ACPI Error: Aborting method _SB.PC00.LPCB.H_EC.TFN1._FST due to previous error (AE_NOT_FOUND) (20221020/psparse-529

@fermino
Copy link

fermino commented Jul 5, 2023

@speedy01 awesome! Did it work?

@speedy01
Copy link

speedy01 commented Jul 5, 2023

@fermino yes..disabling secure boot allowed grub to load custom table. I have sound! :)

@cw-87-tw
Copy link

cw-87-tw commented Jul 5, 2023

@fermino yes..disabling secure boot allowed grub to load custom table. I have sound! :)

Thank you so much, it finally worked after I turned off secure boot

@amarkezic
Copy link

amarkezic commented Jul 19, 2023

Just got a new laptop, the asus ux5304v and to no surprise (after reading this thread) the audio doesn't work (just the speakers don't). Did anyone here try to apply the patch to this specific device ?

Another question i have is will this get overwritten if there is a BIOS update?
Does asus even push firmware updates for linux devices (like DELL does) or do i need to dualboot windows for the firmware updates (or if i don't want to dual boot, apply them manually myself)?

P.S. I am quite a linux newbie especially when it comes to this level of customization (BIOS level) and am not really keen into giving so much time to just have a working machine

Thank in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment