Last active
August 29, 2015 14:05
-
-
Save lefnire/2fa14cfd4f73d5d14097 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## These are the failing tests when using the old code (they fail Markus's critical-time checks) | |
2 failing | |
1) Helper Check Two days apart yesterday two days ago before dayStart today before: | |
Error: expected 1 to sort of equal 2 | |
+ expected - actual | |
+2 | |
-1 | |
at Assertion.assert (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/expect.js/index.js:96:13) | |
at Assertion.eql (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/expect.js/index.js:230:10) | |
at Context.<anonymous> (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/test/algos.mocha.coffee:684:61) | |
at callFn (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runnable.js:223:21) | |
at Test.Runnable.run (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runnable.js:216:7) | |
at Runner.runTest (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:374:10) | |
at /Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:452:12 | |
at next (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:299:14) | |
at /Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:309:7 | |
at next (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:247:23) | |
at Object._onImmediate (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:276:5) | |
at processImmediate [as _immediateCallback] (timers.js:330:15) | |
2) Helper Check two days apart yesterday two days ago before dayStart today after: | |
Error: expected 2 to sort of equal 3 | |
+ expected - actual | |
+3 | |
-2 | |
at Assertion.assert (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/expect.js/index.js:96:13) | |
at Assertion.eql (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/expect.js/index.js:230:10) | |
at Context.<anonymous> (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/test/algos.mocha.coffee:689:61) | |
at callFn (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runnable.js:223:21) | |
at Test.Runnable.run (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runnable.js:216:7) | |
at Runner.runTest (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:374:10) | |
at /Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:452:12 | |
at next (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:299:14) | |
at /Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:309:7 | |
at next (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:247:23) | |
at Object._onImmediate (/Users/lefnire/Dropbox/Sites/habitrpg/modules/habitrpg-shared/node_modules/mocha/lib/runner.js:276:5) | |
at processImmediate [as _immediateCallback] (timers.js:330:15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
And with Markus's code, these are the tests that fail (mostly the original cron tests):