Created
August 5, 2010 01:33
-
-
Save lenards/509081 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 0745c67fd63e5b73959e54cbe9677621554e05fd Mon Sep 17 00:00:00 2001 | |
| From: lenards <lenards@iplantcollaborative.org> | |
| Date: Wed, 4 Aug 2010 18:17:35 -0700 | |
| Subject: [PATCH] CORE-703: activate JavadocMethod check for public methods (and tweak method/ctor length constraints). | |
| --- | |
| src/build/iplant-checkstyle.xml | 16 +++++++++++----- | |
| 1 files changed, 11 insertions(+), 5 deletions(-) | |
| diff --git a/src/build/iplant-checkstyle.xml b/src/build/iplant-checkstyle.xml | |
| index 258036c..66dd515 100644 | |
| --- a/src/build/iplant-checkstyle.xml | |
| +++ b/src/build/iplant-checkstyle.xml | |
| @@ -33,30 +33,36 @@ | |
| <property name="ignoreSetter" value="true"/> | |
| </module> | |
| <module name="CyclomaticComplexity"> | |
| - <property name="max" value="25" /> | |
| + <property name="max" value="20" /> | |
| </module> | |
| <module name="NPathComplexity"> | |
| - <property name="max" value="225" /> | |
| + <property name="max" value="175" /> | |
| </module> | |
| <module name="SimplifyBooleanExpression"/> | |
| <module name="BooleanExpressionComplexity"/> | |
| <module name="MethodLength"> | |
| <property name="tokens" value="METHOD_DEF" /> | |
| - <property name="max" value="200" /> | |
| + <property name="max" value="100" /> | |
| <property name="countEmpty" value="false" /> | |
| </module> | |
| <module name="MethodLength"> | |
| <property name="tokens" value="CTOR_DEF" /> | |
| - <property name="max" value="75" /> | |
| + <property name="max" value="35" /> | |
| <property name="countEmpty" value="false" /> | |
| </module> | |
| <module name="AnonInnerLength"> | |
| - <property name="max" value="200" /> | |
| + <property name="max" value="100" /> | |
| </module> | |
| <module name="JavadocType"> | |
| <property name="scope" value="public" /> | |
| </module> | |
| + <module name="JavadocMethod"> | |
| + <property name="scope" value="public" /> | |
| + <!-- I turned this on and got 1312 errors [lenards] | |
| + <property name="scope" value="protected" /> | |
| + --> | |
| + </module> | |
| <module name="StringLiteralEquality"/> | |
| </module> | |
| </module> | |
| \ No newline at end of file | |
| -- | |
| 1.7.0.3+GitX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment