Skip to content

Instantly share code, notes, and snippets.

@libbyschuknight
Last active November 5, 2017 23:05
Show Gist options
  • Select an option

  • Save libbyschuknight/02a88c98883f7d554d37af0dfec97247 to your computer and use it in GitHub Desktop.

Select an option

Save libbyschuknight/02a88c98883f7d554d37af0dfec97247 to your computer and use it in GitHub Desktop.
Pull Request Emojis

PR Emojis

When reviewing a Pull Request, the more Emoji the better ✨. These ones have a defined meaning:

  • πŸ’‘ FYIs (such as: "πŸ’‘In another service, we solve a similar problem in this way")

  • ⚠️ blocking (such as: "⚠️ I don't think this will work for these edge cases")

  • 🐘 non-blocking (such as: "🐘 This could be more elegant by doing it a different way")

  • πŸ„ code smell (such as: "πŸ„ This seems like a lot of logic for a view")

  • πŸ’­ thought (such as: "πŸ’­I wonder if we could use this pattern in other services?")

  • ✨ compliments (such as: "✨This is some great code, computer friend!")

  • ❓ questions (such as: "❓Why have you done this this way?")

  • πŸ‘  style (such as: ":high_heel: Add some spaces inside the curly braces")

  • πŸŽ“ learning (such as: ":mortar_board: "I haven't used geckoboard, wondering where this method comes from?")

  • β™Ώ accessibility (such as: ":wheelchair: The link text 'click here' might not make sense to someone using a screen reader if they encounter it out of context")

  • πŸ”§ todo / building next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment