When reviewing a Pull Request, the more Emoji the better β¨. These ones have a defined meaning:
-
π‘ FYIs (such as: "π‘In another service, we solve a similar problem in this way")
-
β οΈ blocking (such as: "β οΈ I don't think this will work for these edge cases") -
π non-blocking (such as: "π This could be more elegant by doing it a different way")
-
π code smell (such as: "π This seems like a lot of logic for a view")
-
π thought (such as: "πI wonder if we could use this pattern in other services?")
-
β¨ compliments (such as: "β¨This is some great code, computer friend!")
-
β questions (such as: "βWhy have you done this this way?")
-
π style (such as: ":high_heel: Add some spaces inside the curly braces")
-
π learning (such as: ":mortar_board: "I haven't used geckoboard, wondering where this method comes from?")
-
βΏ accessibility (such as: ":wheelchair: The link text 'click here' might not make sense to someone using a screen reader if they encounter it out of context")
-
π§ todo / building next