Skip to content

Instantly share code, notes, and snippets.

@llogiq

llogiq/stage2.log

Created September 9, 2015 04:15
Show Gist options
  • Save llogiq/21474c9907d46450f065 to your computer and use it in GitHub Desktop.
Save llogiq/21474c9907d46450f065 to your computer and use it in GitHub Desktop.
Download ZIP
A log of compiling rust as of 474ad2f / stage 2 with rust-clippy
Raw
stage2.log
cfg: version 1.4.0-dev (474ad2fc7 2015-09-08)
cfg: build triple i686-unknown-linux-gnu
cfg: host triples i686-unknown-linux-gnu
cfg: target triples i686-unknown-linux-gnu
cfg: host for i686-unknown-linux-gnu is i386
cfg: os for i686-unknown-linux-gnu is unknown-linux-gnu
cfg: good valgrind for i686-unknown-linux-gnu is 1
cfg: using CC=gcc (CFG_CC)
cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS)
cfg: valgrind-rpass command set to "/usr/bin/valgrind" --error-exitcode=100 --fair-sched=try --quiet --soname-synonyms=somalloc=NONE --suppressions=/home/andre/projects/rust/src/etc/x86.supp --tool=memcheck --leak-check=full
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libcore-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libcore-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libcore/lib.rs
src/libcore/num/f32.rs:81:25: 81:66 warning: approximate value of `f32::PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:81 pub const PI: f32 = 3.14159265358979323846264338327950288_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:81:25: 81:66 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:85:32: 85:73 warning: approximate value of `f32::FRAC_PI_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:85 pub const FRAC_PI_2: f32 = 1.57079632679489661923132169163975144_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:85:32: 85:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:89:32: 89:73 warning: approximate value of `f32::FRAC_PI_3` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:89 pub const FRAC_PI_3: f32 = 1.04719755119659774615421446109316763_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:89:32: 89:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:93:32: 93:74 warning: approximate value of `f32::FRAC_PI_4` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:93 pub const FRAC_PI_4: f32 = 0.785398163397448309615660845819875721_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:93:32: 93:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:97:32: 97:73 warning: approximate value of `f32::FRAC_PI_6` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:97 pub const FRAC_PI_6: f32 = 0.52359877559829887307710723054658381_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:97:32: 97:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:101:32: 101:73 warning: approximate value of `f32::FRAC_PI_8` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:101 pub const FRAC_PI_8: f32 = 0.39269908169872415480783042290993786_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:101:32: 101:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:105:32: 105:74 warning: approximate value of `f32::FRAC_1_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:105 pub const FRAC_1_PI: f32 = 0.318309886183790671537767526745028724_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:105:32: 105:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:109:32: 109:74 warning: approximate value of `f32::FRAC_2_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:109 pub const FRAC_2_PI: f32 = 0.636619772367581343075535053490057448_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:109:32: 109:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:113:37: 113:78 warning: approximate value of `f32::FRAC_2_SQRT_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:113 pub const FRAC_2_SQRT_PI: f32 = 1.12837916709551257389615890312154517_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:113:37: 113:78 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:117:29: 117:70 warning: approximate value of `f32::SQRT_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:117 pub const SQRT_2: f32 = 1.41421356237309504880168872420969808_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:117:29: 117:70 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:121:36: 121:78 warning: approximate value of `f32::FRAC_1_SQRT_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:121 pub const FRAC_1_SQRT_2: f32 = 0.707106781186547524400844362104849039_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:121:36: 121:78 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:125:24: 125:65 warning: approximate value of `f32::E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:125 pub const E: f32 = 2.71828182845904523536028747135266250_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:125:24: 125:65 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:129:29: 129:70 warning: approximate value of `f32::LOG2_E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:129 pub const LOG2_E: f32 = 1.44269504088896340735992468100189214_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:129:29: 129:70 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:133:30: 133:72 warning: approximate value of `f32::LOG10_E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:133 pub const LOG10_E: f32 = 0.434294481903251827651128918916605082_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:133:30: 133:72 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:137:27: 137:69 warning: approximate value of `f32::LN_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:137 pub const LN_2: f32 = 0.693147180559945309417232121458176568_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:137:27: 137:69 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f32.rs:141:28: 141:69 warning: approximate value of `f32::LN_10` found. Consider using it directly [-W approx-constant]
src/libcore/num/f32.rs:141 pub const LN_10: f32 = 2.30258509299404568401799145468436421_f32;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:141:28: 141:69 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/float_macros.rs:74:48: 163:37 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(prev_sig - ..) < epsilon` for some suitable value of epsilon [-W float-cmp]
(internal compiler error: unprintable span)
note: in expansion of for loop expansion
src/libcore/num/float_macros.rs:52:13: 94:14 note: expansion site
src/libcore/num/float_macros.rs:22:1: 161:2 note: in expansion of from_str_radix_float_impl!
src/libcore/num/f32.rs:163:5: 163:39 note: expansion site
src/libcore/num/float_macros.rs:74:48: 163:37 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/float_macros.rs:76:49: 163:37 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(prev_sig - ..) < epsilon` for some suitable value of epsilon [-W float-cmp]
(internal compiler error: unprintable span)
note: in expansion of for loop expansion
src/libcore/num/float_macros.rs:52:13: 94:14 note: expansion site
src/libcore/num/float_macros.rs:22:1: 161:2 note: in expansion of from_str_radix_float_impl!
src/libcore/num/f32.rs:163:5: 163:39 note: expansion site
src/libcore/num/float_macros.rs:76:49: 163:37 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f32.rs:167:31: 167:43 warning: equal expressions as operands to != [-W eq-op]
src/libcore/num/f32.rs:167 fn is_nan(self) -> bool { self != self }
^~~~~~~~~~~~
src/libcore/num/f32.rs:167:31: 167:43 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libcore/num/f32.rs:167:31: 167:43 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(self - self) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f32.rs:167 fn is_nan(self) -> bool { self != self }
^~~~~~~~~~~~
src/libcore/num/f32.rs:167:31: 167:43 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f32.rs:172:9: 172:34 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(self - Float::infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f32.rs:172 self == Float::infinity() || self == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:172:9: 172:34 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f32.rs:172:38: 172:67 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(self - Float::neg_infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f32.rs:172 self == Float::infinity() || self == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:172:38: 172:67 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f32.rs:244:23: 244:56 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs((1.0 / self) - Float::infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f32.rs:244 self > 0.0 || (1.0 / self) == Float::infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:244:23: 244:56 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f32.rs:251:23: 251:60 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs((1.0 / self) - Float::neg_infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f32.rs:251 self < 0.0 || (1.0 / self) == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f32.rs:251:23: 251:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:81:25: 81:66 warning: approximate value of `f64::PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:81 pub const PI: f64 = 3.14159265358979323846264338327950288_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:81:25: 81:66 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:85:32: 85:73 warning: approximate value of `f64::FRAC_PI_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:85 pub const FRAC_PI_2: f64 = 1.57079632679489661923132169163975144_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:85:32: 85:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:89:32: 89:73 warning: approximate value of `f64::FRAC_PI_3` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:89 pub const FRAC_PI_3: f64 = 1.04719755119659774615421446109316763_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:89:32: 89:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:93:32: 93:74 warning: approximate value of `f64::FRAC_PI_4` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:93 pub const FRAC_PI_4: f64 = 0.785398163397448309615660845819875721_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:93:32: 93:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:97:32: 97:73 warning: approximate value of `f64::FRAC_PI_6` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:97 pub const FRAC_PI_6: f64 = 0.52359877559829887307710723054658381_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:97:32: 97:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:101:32: 101:73 warning: approximate value of `f64::FRAC_PI_8` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:101 pub const FRAC_PI_8: f64 = 0.39269908169872415480783042290993786_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:101:32: 101:73 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:105:32: 105:74 warning: approximate value of `f64::FRAC_1_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:105 pub const FRAC_1_PI: f64 = 0.318309886183790671537767526745028724_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:105:32: 105:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:109:32: 109:74 warning: approximate value of `f64::FRAC_2_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:109 pub const FRAC_2_PI: f64 = 0.636619772367581343075535053490057448_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:109:32: 109:74 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:113:37: 113:78 warning: approximate value of `f64::FRAC_2_SQRT_PI` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:113 pub const FRAC_2_SQRT_PI: f64 = 1.12837916709551257389615890312154517_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:113:37: 113:78 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:117:29: 117:70 warning: approximate value of `f64::SQRT_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:117 pub const SQRT_2: f64 = 1.41421356237309504880168872420969808_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:117:29: 117:70 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:121:36: 121:78 warning: approximate value of `f64::FRAC_1_SQRT_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:121 pub const FRAC_1_SQRT_2: f64 = 0.707106781186547524400844362104849039_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:121:36: 121:78 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:125:24: 125:65 warning: approximate value of `f64::E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:125 pub const E: f64 = 2.71828182845904523536028747135266250_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:125:24: 125:65 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:129:29: 129:70 warning: approximate value of `f64::LOG2_E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:129 pub const LOG2_E: f64 = 1.44269504088896340735992468100189214_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:129:29: 129:70 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:133:30: 133:72 warning: approximate value of `f64::LOG10_E` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:133 pub const LOG10_E: f64 = 0.434294481903251827651128918916605082_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:133:30: 133:72 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:137:27: 137:69 warning: approximate value of `f64::LN_2` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:137 pub const LN_2: f64 = 0.693147180559945309417232121458176568_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:137:27: 137:69 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/f64.rs:141:28: 141:69 warning: approximate value of `f64::LN_10` found. Consider using it directly [-W approx-constant]
src/libcore/num/f64.rs:141 pub const LN_10: f64 = 2.30258509299404568401799145468436421_f64;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:141:28: 141:69 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#approx_constant
src/libcore/num/float_macros.rs:74:48: 163:37 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(prev_sig - ..) < epsilon` for some suitable value of epsilon [-W float-cmp]
(internal compiler error: unprintable span)
note: in expansion of for loop expansion
src/libcore/num/float_macros.rs:52:13: 94:14 note: expansion site
src/libcore/num/float_macros.rs:22:1: 161:2 note: in expansion of from_str_radix_float_impl!
src/libcore/num/f64.rs:163:5: 163:39 note: expansion site
src/libcore/num/float_macros.rs:74:48: 163:37 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/float_macros.rs:76:49: 163:37 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(prev_sig - ..) < epsilon` for some suitable value of epsilon [-W float-cmp]
(internal compiler error: unprintable span)
note: in expansion of for loop expansion
src/libcore/num/float_macros.rs:52:13: 94:14 note: expansion site
src/libcore/num/float_macros.rs:22:1: 161:2 note: in expansion of from_str_radix_float_impl!
src/libcore/num/f64.rs:163:5: 163:39 note: expansion site
src/libcore/num/float_macros.rs:76:49: 163:37 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:167:31: 167:43 warning: equal expressions as operands to != [-W eq-op]
src/libcore/num/f64.rs:167 fn is_nan(self) -> bool { self != self }
^~~~~~~~~~~~
src/libcore/num/f64.rs:167:31: 167:43 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libcore/num/f64.rs:167:31: 167:43 warning: !=-comparison of f32 or f64 detected. Consider changing this to `abs(self - self) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f64.rs:167 fn is_nan(self) -> bool { self != self }
^~~~~~~~~~~~
src/libcore/num/f64.rs:167:31: 167:43 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:172:9: 172:34 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(self - Float::infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f64.rs:172 self == Float::infinity() || self == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:172:9: 172:34 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:172:38: 172:67 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(self - Float::neg_infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f64.rs:172 self == Float::infinity() || self == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:172:38: 172:67 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:244:23: 244:56 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs((1.0 / self) - Float::infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f64.rs:244 self > 0.0 || (1.0 / self) == Float::infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:244:23: 244:56 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/f64.rs:251:23: 251:60 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs((1.0 / self) - Float::neg_infinity()) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/f64.rs:251 self < 0.0 || (1.0 / self) == Float::neg_infinity()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/f64.rs:251:23: 251:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/wrapping.rs:357:5: 357:22 warning: you have declared `#[inline(always)]` on `overflowing_add`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:357 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:357:5: 357:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:364:5: 364:22 warning: you have declared `#[inline(always)]` on `overflowing_sub`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:364 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:364:5: 364:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:371:5: 371:22 warning: you have declared `#[inline(always)]` on `overflowing_mul`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:371 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:371:5: 371:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:378:5: 378:22 warning: you have declared `#[inline(always)]` on `overflowing_div`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:378 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:378:5: 378:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:383:5: 383:22 warning: you have declared `#[inline(always)]` on `overflowing_rem`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:383 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:383:5: 383:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:388:5: 388:22 warning: you have declared `#[inline(always)]` on `overflowing_neg`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:388 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:388:5: 388:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:393:5: 393:22 warning: you have declared `#[inline(always)]` on `overflowing_shl`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:393 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:393:5: 393:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:398:5: 398:22 warning: you have declared `#[inline(always)]` on `overflowing_shr`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:398 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:398:5: 398:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:457:5: 457:22 warning: you have declared `#[inline(always)]` on `overflowing_add`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:457 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:457:5: 457:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:464:5: 464:22 warning: you have declared `#[inline(always)]` on `overflowing_sub`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:464 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:464:5: 464:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:471:5: 471:22 warning: you have declared `#[inline(always)]` on `overflowing_mul`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:471 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:471:5: 471:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:478:5: 478:22 warning: you have declared `#[inline(always)]` on `overflowing_div`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:478 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:478:5: 478:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:483:5: 483:22 warning: you have declared `#[inline(always)]` on `overflowing_rem`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:483 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:483:5: 483:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:488:5: 488:22 warning: you have declared `#[inline(always)]` on `overflowing_neg`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:488 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:488:5: 488:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:493:5: 493:22 warning: you have declared `#[inline(always)]` on `overflowing_shl`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:493 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:493:5: 493:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/wrapping.rs:498:5: 498:22 warning: you have declared `#[inline(always)]` on `overflowing_shr`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/wrapping.rs:498 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/wrapping.rs:498:5: 498:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/flt2dec/strategy/dragon.rs:289:9: 305:10 warning: the loop variable `i` is used to index `buf`. Consider using `for (i, item) in buf.iter().enumerate()` or similar iterators [-W needless-range-loop]
src/libcore/num/flt2dec/strategy/dragon.rs:289 for i in 0..len {
src/libcore/num/flt2dec/strategy/dragon.rs:290 if mant.is_zero() { // following digits are all zeroes, we stop here
src/libcore/num/flt2dec/strategy/dragon.rs:291 // do *not* try to perform rounding! rather, fill remaining digits.
src/libcore/num/flt2dec/strategy/dragon.rs:292 for c in &mut buf[i..len] { *c = b'0'; }
src/libcore/num/flt2dec/strategy/dragon.rs:293 return (len, k);
src/libcore/num/flt2dec/strategy/dragon.rs:294 }
...
note: in expansion of for loop expansion
src/libcore/num/flt2dec/strategy/dragon.rs:289:9: 305:10 note: expansion site
src/libcore/num/flt2dec/strategy/dragon.rs:289:9: 305:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/libcore/num/flt2dec/mod.rs:189:5: 189:5 warning: item `Part<'a>` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libcore/num/flt2dec/mod.rs:189 pub fn len(&self) -> usize {
^
src/libcore/num/flt2dec/mod.rs:189:5: 189:5 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libcore/num/flt2dec/mod.rs:237:5: 237:5 warning: item `Formatted<'a>` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libcore/num/flt2dec/mod.rs:237 pub fn len(&self) -> usize {
^
src/libcore/num/flt2dec/mod.rs:237:5: 237:5 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libcore/num/dec2flt/rawfp.rs:174:23: 174:65 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(x as f32 - fp_to_float(Fp { f: x, e: 0 })) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/dec2flt/rawfp.rs:174 debug_assert!(x as f32 == fp_to_float(Fp { f: x, e: 0 }));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/macros.rs:57:1: 68:2 note: in expansion of assert!
src/libcore/macros.rs:129:51: 129:69 note: expansion site
src/libcore/macros.rs:128:1: 130:2 note: in expansion of debug_assert!
src/libcore/num/dec2flt/rawfp.rs:174:9: 174:67 note: expansion site
src/libcore/num/dec2flt/rawfp.rs:174:23: 174:65 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/dec2flt/rawfp.rs:207:9: 207:13 warning: returning the result of a let binding. Consider returning the expression directly. [-W let-and-return]
src/libcore/num/dec2flt/rawfp.rs:207 bits
^~~~
src/libcore/num/dec2flt/rawfp.rs:207:9: 207:13 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_and_return
src/libcore/num/dec2flt/rawfp.rs:206:25: 206:51 note: this expression can be directly returned
src/libcore/num/dec2flt/rawfp.rs:206 let bits: u64 = unsafe { transmute(self) };
^~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/num/dec2flt/rawfp.rs:221:23: 221:65 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(x as f64 - fp_to_float(Fp { f: x, e: 0 })) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libcore/num/dec2flt/rawfp.rs:221 debug_assert!(x as f64 == fp_to_float(Fp { f: x, e: 0 }));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/macros.rs:57:1: 68:2 note: in expansion of assert!
src/libcore/macros.rs:129:51: 129:69 note: expansion site
src/libcore/macros.rs:128:1: 130:2 note: in expansion of debug_assert!
src/libcore/num/dec2flt/rawfp.rs:221:9: 221:67 note: expansion site
src/libcore/num/dec2flt/rawfp.rs:221:23: 221:65 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libcore/num/dec2flt/mod.rs:271:1: 271:18 warning: you have declared `#[inline(always)]` on `simplify`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/num/dec2flt/mod.rs:271 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/num/dec2flt/mod.rs:271:1: 271:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/num/mod.rs:1166:22: 767:30 warning: equal expressions as operands to == [-W eq-op]
(internal compiler error: unprintable span)
src/libcore/num/mod.rs:663:1: 1162:2 note: in expansion of uint_impl!
src/libcore/num/mod.rs:1166:5: 1173:43 note: expansion site
src/libcore/num/mod.rs:1166:22: 767:30 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libcore/mem.rs:252:5: 252:22 warning: you have declared `#[inline(always)]` on `dropped_impl`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/mem.rs:252 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/mem.rs:252:5: 252:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/nonzero.rs:44:5: 44:22 warning: you have declared `#[inline(always)]` on `new`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/nonzero.rs:44 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/nonzero.rs:44:5: 44:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/ptr.rs:118:1: 118:18 warning: you have declared `#[inline(always)]` on `read`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/ptr.rs:118 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/ptr.rs:118:1: 118:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/ptr.rs:128:1: 128:18 warning: you have declared `#[inline(always)]` on `read_and_drop`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/ptr.rs:128 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/ptr.rs:128:1: 128:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/ptr.rs:184:5: 190:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/ptr.rs:184 pub unsafe fn as_ref<'a>(&self) -> Option<&'a T> where T: Sized {
src/libcore/ptr.rs:185 if self.is_null() {
src/libcore/ptr.rs:186 None
src/libcore/ptr.rs:187 } else {
src/libcore/ptr.rs:188 Some(&**self)
src/libcore/ptr.rs:189 }
...
src/libcore/ptr.rs:184:5: 190:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/ptr.rs:233:5: 239:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/ptr.rs:233 pub unsafe fn as_ref<'a>(&self) -> Option<&'a T> where T: Sized {
src/libcore/ptr.rs:234 if self.is_null() {
src/libcore/ptr.rs:235 None
src/libcore/ptr.rs:236 } else {
src/libcore/ptr.rs:237 Some(&**self)
src/libcore/ptr.rs:238 }
...
src/libcore/ptr.rs:233:5: 239:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/ptr.rs:267:5: 273:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/ptr.rs:267 pub unsafe fn as_mut<'a>(&self) -> Option<&'a mut T> where T: Sized {
src/libcore/ptr.rs:268 if self.is_null() {
src/libcore/ptr.rs:269 None
src/libcore/ptr.rs:270 } else {
src/libcore/ptr.rs:271 Some(&mut **self)
src/libcore/ptr.rs:272 }
...
src/libcore/ptr.rs:267:5: 273:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/clone.rs:46:5: 46:22 warning: you have declared `#[inline(always)]` on `clone_from`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/clone.rs:46 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/clone.rs:46:5: 46:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/iter.rs:1346:5: 1354:6 warning: trait `ExactSizeIterator` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libcore/iter.rs:1346 fn len(&self) -> usize {
src/libcore/iter.rs:1347 let (lower, upper) = self.size_hint();
src/libcore/iter.rs:1348 // Note: This assertion is overly defensive, but it checks the invariant
src/libcore/iter.rs:1349 // guaranteed by the trait. If this trait were rust-internal,
src/libcore/iter.rs:1350 // we could use debug_assert!; assert_eq! will check all Rust user
src/libcore/iter.rs:1351 // implementations too.
...
src/libcore/iter.rs:1346:5: 1354:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libcore/iter.rs:1949:21: 1949:34 warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [-W wrong-self-convention]
src/libcore/iter.rs:1949 pub fn is_empty(&mut self) -> bool {
^~~~~~~~~~~~~
src/libcore/iter.rs:1949:21: 1949:34 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/libcore/slice.rs:682:1: 682:18 warning: you have declared `#[inline(always)]` on `size_from_ptr`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/slice.rs:682 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/slice.rs:682:1: 682:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/pattern.rs:632:5: 632:22 warning: you have declared `#[inline(always)]` on `next_match`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/str/pattern.rs:632 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/str/pattern.rs:632:5: 632:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/pattern.rs:900:5: 900:22 warning: you have declared `#[inline(always)]` on `byteset_contains`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/str/pattern.rs:900 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/str/pattern.rs:900:5: 900:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/pattern.rs:910:5: 910:22 warning: you have declared `#[inline(always)]` on `next`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/str/pattern.rs:910 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/str/pattern.rs:910:5: 910:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/mod.rs:143:1: 143:18 warning: you have declared `#[inline(always)]` on `from_utf8_unchecked`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/str/mod.rs:143 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:143:1: 143:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/mod.rs:607:5: 619:6 warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libcore/str/mod.rs:607 fn next(&mut self) -> Option<&'a str> {
src/libcore/str/mod.rs:608 if self.finished { return None }
src/libcore/str/mod.rs:609
src/libcore/str/mod.rs:610 let haystack = self.matcher.haystack();
src/libcore/str/mod.rs:611 match self.matcher.next_match() {
src/libcore/str/mod.rs:612 Some((a, b)) => unsafe {
...
src/libcore/str/mod.rs:607:5: 619:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libcore/str/mod.rs:690:5: 696:6 warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libcore/str/mod.rs:690 fn next(&mut self) -> Option<&'a str> {
src/libcore/str/mod.rs:691 match self.count {
src/libcore/str/mod.rs:692 0 => None,
src/libcore/str/mod.rs:693 1 => { self.count = 0; self.iter.get_end() }
src/libcore/str/mod.rs:694 _ => { self.count -= 1; self.iter.next() }
src/libcore/str/mod.rs:695 }
...
src/libcore/str/mod.rs:690:5: 696:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libcore/str/mod.rs:732:5: 734:6 warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libcore/str/mod.rs:732 fn next(&mut self) -> Option<(usize, usize)> {
src/libcore/str/mod.rs:733 self.0.next_match()
src/libcore/str/mod.rs:734 }
src/libcore/str/mod.rs:732:5: 734:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libcore/str/mod.rs:768:5: 773:6 warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libcore/str/mod.rs:768 fn next(&mut self) -> Option<&'a str> {
src/libcore/str/mod.rs:769 self.0.next_match().map(|(a, b)| unsafe {
src/libcore/str/mod.rs:770 // Indices are known to be on utf8 boundaries
src/libcore/str/mod.rs:771 self.0.haystack().slice_unchecked(a, b)
src/libcore/str/mod.rs:772 })
src/libcore/str/mod.rs:773 }
src/libcore/str/mod.rs:768:5: 773:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libcore/str/mod.rs:917:1: 917:18 warning: you have declared `#[inline(always)]` on `run_utf8_validation_iterator`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcore/str/mod.rs:917 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:917:1: 917:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcore/str/mod.rs:1248:5: 1248:63 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1248 fn contains<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1248:5: 1248:63 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1249:5: 1249:68 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1249 fn contains_char<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1249:5: 1249:68 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1253:5: 1253:68 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1253 fn split<'a, P: Pattern<'a>>(&'a self, pat: P) -> Split<'a, P>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1253:5: 1253:68 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1256:5: 1256:84 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1256 fn splitn<'a, P: Pattern<'a>>(&'a self, count: usize, pat: P) -> SplitN<'a, P>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1256:5: 1256:84 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1259:5: 1259:89 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1259 fn split_terminator<'a, P: Pattern<'a>>(&'a self, pat: P) -> SplitTerminator<'a, P>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1259:5: 1259:89 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1262:5: 1262:72 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1262 fn matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> Matches<'a, P>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1262:5: 1262:72 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1265:5: 1265:83 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1265 fn match_indices<'a, P: Pattern<'a>>(&'a self, pat: P) -> MatchIndices<'a, P>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1265:5: 1265:83 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1275:5: 1275:66 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1275 fn starts_with<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1275:5: 1275:66 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1280:5: 1280:75 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1280 fn trim_left_matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> &'a str;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1280:5: 1280:75 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1289:5: 1289:68 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1289 fn find<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1289:5: 1289:68 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1292:5: 1292:72 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1292 fn find_str<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/str/mod.rs:1292:5: 1292:72 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1312:5: 1314:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1312 fn contains<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool {
src/libcore/str/mod.rs:1313 pat.is_contained_in(self)
src/libcore/str/mod.rs:1314 }
src/libcore/str/mod.rs:1312:5: 1314:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1317:5: 1319:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1317 fn contains_char<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool {
src/libcore/str/mod.rs:1318 pat.is_contained_in(self)
src/libcore/str/mod.rs:1319 }
src/libcore/str/mod.rs:1317:5: 1319:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1337:5: 1345:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1337 fn split<'a, P: Pattern<'a>>(&'a self, pat: P) -> Split<'a, P> {
src/libcore/str/mod.rs:1338 Split(SplitInternal {
src/libcore/str/mod.rs:1339 start: 0,
src/libcore/str/mod.rs:1340 end: self.len(),
src/libcore/str/mod.rs:1341 matcher: pat.into_searcher(self),
src/libcore/str/mod.rs:1342 allow_trailing_empty: true,
...
src/libcore/str/mod.rs:1337:5: 1345:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1355:5: 1360:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1355 fn splitn<'a, P: Pattern<'a>>(&'a self, count: usize, pat: P) -> SplitN<'a, P> {
src/libcore/str/mod.rs:1356 SplitN(SplitNInternal {
src/libcore/str/mod.rs:1357 iter: self.split(pat).0,
src/libcore/str/mod.rs:1358 count: count,
src/libcore/str/mod.rs:1359 })
src/libcore/str/mod.rs:1360 }
src/libcore/str/mod.rs:1355:5: 1360:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1370:5: 1375:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1370 fn split_terminator<'a, P: Pattern<'a>>(&'a self, pat: P) -> SplitTerminator<'a, P> {
src/libcore/str/mod.rs:1371 SplitTerminator(SplitInternal {
src/libcore/str/mod.rs:1372 allow_trailing_empty: false,
src/libcore/str/mod.rs:1373 ..self.split(pat).0
src/libcore/str/mod.rs:1374 })
src/libcore/str/mod.rs:1375 }
src/libcore/str/mod.rs:1370:5: 1375:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1385:5: 1387:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1385 fn matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> Matches<'a, P> {
src/libcore/str/mod.rs:1386 Matches(MatchesInternal(pat.into_searcher(self)))
src/libcore/str/mod.rs:1387 }
src/libcore/str/mod.rs:1385:5: 1387:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1397:5: 1399:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1397 fn match_indices<'a, P: Pattern<'a>>(&'a self, pat: P) -> MatchIndices<'a, P> {
src/libcore/str/mod.rs:1398 MatchIndices(MatchIndicesInternal(pat.into_searcher(self)))
src/libcore/str/mod.rs:1399 }
src/libcore/str/mod.rs:1397:5: 1399:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1461:5: 1463:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1461 fn starts_with<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool {
src/libcore/str/mod.rs:1462 pat.is_prefix_of(self)
src/libcore/str/mod.rs:1463 }
src/libcore/str/mod.rs:1461:5: 1463:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1494:5: 1504:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1494 fn trim_left_matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> &'a str {
src/libcore/str/mod.rs:1495 let mut i = self.len();
src/libcore/str/mod.rs:1496 let mut matcher = pat.into_searcher(self);
src/libcore/str/mod.rs:1497 if let Some((a, _)) = matcher.next_reject() {
src/libcore/str/mod.rs:1498 i = a;
src/libcore/str/mod.rs:1499 }
...
src/libcore/str/mod.rs:1494:5: 1504:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1582:5: 1584:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1582 fn find<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize> {
src/libcore/str/mod.rs:1583 pat.into_searcher(self).next_match().map(|(i, _)| i)
src/libcore/str/mod.rs:1584 }
src/libcore/str/mod.rs:1582:5: 1584:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/str/mod.rs:1592:5: 1594:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcore/str/mod.rs:1592 fn find_str<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize> {
src/libcore/str/mod.rs:1593 self.find(pat)
src/libcore/str/mod.rs:1594 }
src/libcore/str/mod.rs:1592:5: 1594:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcore/hash/sip.rs:152:30: 152:72 warning: operator precedence can trip the unwary. Consider adding parentheses to the subexpression [-W precedence]
src/libcore/hash/sip.rs:152 self.tail |= u8to64_le!(msg, 0, length) << 8*self.ntail;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/hash/sip.rs:152:30: 152:72 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
src/libcore/hash/sip.rs:67:20: 67:46 warning: operator precedence can trip the unwary. Consider adding parentheses to the subexpression [-W precedence]
src/libcore/hash/sip.rs:67 out |= ($buf[t+$i] as u64) << t*8;
^~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/hash/sip.rs:52:1: 72:2 note: in expansion of u8to64_le!
src/libcore/hash/sip.rs:152:30: 152:56 note: expansion site
src/libcore/hash/sip.rs:67:20: 67:46 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
src/libcore/hash/sip.rs:157:33: 157:75 warning: operator precedence can trip the unwary. Consider adding parentheses to the subexpression [-W precedence]
src/libcore/hash/sip.rs:157 let m = self.tail | u8to64_le!(msg, 0, needed) << 8*self.ntail;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/hash/sip.rs:157:33: 157:75 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
src/libcore/hash/sip.rs:67:20: 67:46 warning: operator precedence can trip the unwary. Consider adding parentheses to the subexpression [-W precedence]
src/libcore/hash/sip.rs:67 out |= ($buf[t+$i] as u64) << t*8;
^~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/hash/sip.rs:52:1: 72:2 note: in expansion of u8to64_le!
src/libcore/hash/sip.rs:157:33: 157:59 note: expansion site
src/libcore/hash/sip.rs:67:20: 67:46 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
src/libcore/hash/sip.rs:67:20: 67:46 warning: operator precedence can trip the unwary. Consider adding parentheses to the subexpression [-W precedence]
src/libcore/hash/sip.rs:67 out |= ($buf[t+$i] as u64) << t*8;
^~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcore/hash/sip.rs:52:1: 72:2 note: in expansion of u8to64_le!
src/libcore/hash/sip.rs:183:21: 183:45 note: expansion site
src/libcore/hash/sip.rs:67:20: 67:46 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#precedence
info: now are following matches for libcore-*.so libraries:
info: now are following matches for libcore-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcore-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liblibc-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblibc-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liblibc-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liblibc-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblibc-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/liblibc/lib.rs
src/liblibc/lib.rs:3423:47: 3423:53 warning: the operation is ineffective. Consider reducing it to `1` [-W identity-op]
src/liblibc/lib.rs:3423 pub const GLOB_ERR : c_int = 1 << 0;
^~~~~~
src/liblibc/lib.rs:3423:47: 3423:53 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
info: now are following matches for liblibc-*.so libraries:
info: now are following matches for liblibc-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblibc-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librand-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librand-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librand-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'librand-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librand-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/librand/lib.rs
src/librand/distributions/gamma.rs:189:23: 189:31 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(k - 1.0) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/librand/distributions/gamma.rs:189 let repr = if k == 1.0 {
^~~~~~~~
src/librand/distributions/gamma.rs:189:23: 189:31 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/librand/distributions/mod.rs:176:9: 176:48 warning: unneeded return statement. Consider using `self.items[idx + 1].item.clone()` without the return and trailing semicolon [-W needless-return]
src/librand/distributions/mod.rs:176 return self.items[idx + 1].item.clone();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librand/distributions/mod.rs:176:9: 176:48 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/librand/distributions/mod.rs:197:1: 197:18 warning: you have declared `#[inline(always)]` on `ziggurat`. This is usually a bad idea. Are you sure? [-W inline-always]
src/librand/distributions/mod.rs:197 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/librand/distributions/mod.rs:197:1: 197:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/librand/isaac.rs:262:9: 262:19 warning: unneeded return statement. Consider using `ret` without the return and trailing semicolon [-W needless-return]
src/librand/isaac.rs:262 return ret;
^~~~~~~~~~
src/librand/isaac.rs:262:9: 262:19 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/librand/isaac.rs:419:27: 387:45 warning: equal expressions as operands to == [-W eq-op]
(internal compiler error: unprintable span)
src/librand/isaac.rs:383:17: 399:18 note: in expansion of rngstepp!
src/librand/isaac.rs:419:17: 419:34 note: expansion site
note: in expansion of for loop expansion
src/librand/isaac.rs:381:13: 423:14 note: expansion site
note: in expansion of for loop expansion
src/librand/isaac.rs:380:9: 424:10 note: expansion site
src/librand/isaac.rs:419:27: 387:45 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/librand/isaac.rs:505:9: 505:19 warning: unneeded return statement. Consider using `ret` without the return and trailing semicolon [-W needless-return]
src/librand/isaac.rs:505 return ret;
^~~~~~~~~~
src/librand/isaac.rs:505:9: 505:19 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/librand/chacha.rs:98:27: 98:44 warning: the operation is ineffective. Consider reducing it to `counter_low` [-W identity-op]
src/librand/chacha.rs:98 self.state[12] = (counter_low >> 0) as u32;
^~~~~~~~~~~~~~~~~
src/librand/chacha.rs:98:27: 98:44 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
src/librand/chacha.rs:100:27: 100:45 warning: the operation is ineffective. Consider reducing it to `counter_high` [-W identity-op]
src/librand/chacha.rs:100 self.state[14] = (counter_high >> 0) as u32;
^~~~~~~~~~~~~~~~~~
src/librand/chacha.rs:100:27: 100:45 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
src/librand/chacha.rs:129:9: 131:10 warning: the loop variable `i` is used to index `key`. Consider using `for (i, item) in key.iter().enumerate()` or similar iterators [-W needless-range-loop]
src/librand/chacha.rs:129 for i in 0..KEY_WORDS {
src/librand/chacha.rs:130 self.state[4+i] = key[i];
src/librand/chacha.rs:131 }
note: in expansion of for loop expansion
src/librand/chacha.rs:129:9: 131:10 note: expansion site
src/librand/chacha.rs:129:9: 131:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/librand/lib.rs:212:5: 212:22 warning: you have declared `#[inline(always)]` on `gen`. This is usually a bad idea. Are you sure? [-W inline-always]
src/librand/lib.rs:212 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/librand/lib.rs:212:5: 212:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/librand/lib.rs:219:5: 221:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librand/lib.rs:219 fn gen_iter<'a, T: Rand>(&'a mut self) -> Generator<'a, T, Self> {
src/librand/lib.rs:220 Generator { rng: self, _marker: PhantomData }
src/librand/lib.rs:221 }
src/librand/lib.rs:219:5: 221:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librand/lib.rs:245:5: 247:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librand/lib.rs:245 fn gen_ascii_chars<'a>(&'a mut self) -> AsciiGenerator<'a, Self> {
src/librand/lib.rs:246 AsciiGenerator { rng: self }
src/librand/lib.rs:247 }
src/librand/lib.rs:245:5: 247:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
info: now are following matches for librand-*.so libraries:
info: now are following matches for librand-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librand-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc_system-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_system-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc_system-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liballoc_system-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_system-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/liballoc_system/lib.rs
info: now are following matches for liballoc_system-*.so libraries:
info: now are following matches for liballoc_system-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_system-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liballoc-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/liballoc/lib.rs
src/liballoc/heap.rs:32:1: 32:18 warning: you have declared `#[inline(always)]` on `check_size_and_alignment`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/heap.rs:32 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/heap.rs:32:1: 32:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/boxed.rs:210:5: 210:22 warning: you have declared `#[inline(always)]` on `new`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/boxed.rs:210 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/boxed.rs:210:5: 210:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/boxed.rs:258:21: 258:34 warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [-W wrong-self-convention]
src/liballoc/boxed.rs:258 pub fn into_raw(b: Box<T>) -> *mut T {
^~~~~~~~~~~~~
src/liballoc/boxed.rs:258:21: 258:34 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/liballoc/arc.rs:495:18: 495:31 warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [-W wrong-self-convention]
src/liballoc/arc.rs:495 fn is_unique(&mut self) -> bool {
^~~~~~~~~~~~~
src/liballoc/arc.rs:495:18: 495:31 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/liballoc/arc.rs:662:9: 662:40 warning: unneeded return statement. Consider using `Weak { _ptr: self._ptr }` without the return and trailing semicolon [-W needless-return]
src/liballoc/arc.rs:662 return Weak { _ptr: self._ptr }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/liballoc/arc.rs:662:9: 662:40 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/liballoc/rc.rs:419:5: 419:22 warning: you have declared `#[inline(always)]` on `deref`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:419 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:419:5: 419:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:534:5: 534:22 warning: you have declared `#[inline(always)]` on `eq`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:534 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:534:5: 534:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:550:5: 550:22 warning: you have declared `#[inline(always)]` on `ne`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:550 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:550:5: 550:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:572:5: 572:22 warning: you have declared `#[inline(always)]` on `partial_cmp`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:572 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:572:5: 572:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:590:5: 590:22 warning: you have declared `#[inline(always)]` on `lt`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:590 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:590:5: 590:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:606:5: 606:22 warning: you have declared `#[inline(always)]` on `le`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:606 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:606:5: 606:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:622:5: 622:22 warning: you have declared `#[inline(always)]` on `gt`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:622 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:622:5: 622:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:638:5: 638:22 warning: you have declared `#[inline(always)]` on `ge`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:638 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:638:5: 638:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:855:5: 855:22 warning: you have declared `#[inline(always)]` on `inner`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:855 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:855:5: 855:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/liballoc/rc.rs:869:5: 869:22 warning: you have declared `#[inline(always)]` on `inner`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liballoc/rc.rs:869 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liballoc/rc.rs:869:5: 869:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
info: now are following matches for liballoc-*.so libraries:
info: now are following matches for liballoc-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librustc_unicode-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_unicode-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librustc_unicode-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'librustc_unicode-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_unicode-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/librustc_unicode/lib.rs
src/librustc_unicode/u_str.rs:26:12: 26:66 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/librustc_unicode/u_str.rs:26 inner: Filter<Split<'a, fn(char) -> bool>, fn(&&str) -> bool>,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:26:12: 26:66 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/librustc_unicode/u_str.rs:32:5: 32:62 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librustc_unicode/u_str.rs:32 fn split_whitespace<'a>(&'a self) -> SplitWhitespace<'a>;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:32:5: 32:62 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librustc_unicode/u_str.rs:35:5: 35:38 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librustc_unicode/u_str.rs:35 fn trim<'a>(&'a self) -> &'a str;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:35:5: 35:38 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librustc_unicode/u_str.rs:36:5: 36:43 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librustc_unicode/u_str.rs:36 fn trim_left<'a>(&'a self) -> &'a str;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:36:5: 36:43 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librustc_unicode/u_str.rs:37:5: 37:44 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librustc_unicode/u_str.rs:37 fn trim_right<'a>(&'a self) -> &'a str;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:37:5: 37:44 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librustc_unicode/u_str.rs:97:5: 97:48 warning: unneeded return statement. Consider using `UTF8_CHAR_WIDTH[b as usize] as usize` without the return and trailing semicolon [-W needless-return]
src/librustc_unicode/u_str.rs:97 return UTF8_CHAR_WIDTH[b as usize] as usize;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librustc_unicode/u_str.rs:97:5: 97:48 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/librustc_unicode/u_str.rs:204:1: 206:2 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librustc_unicode/u_str.rs:204 pub fn utf16_items<'a>(v: &'a [u16]) -> Utf16Items<'a> {
src/librustc_unicode/u_str.rs:205 Utf16Items { decoder: decode_utf16(v.iter().cloned()) }
src/librustc_unicode/u_str.rs:206 }
src/librustc_unicode/u_str.rs:204:1: 206:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
info: now are following matches for librustc_unicode-*.so libraries:
info: now are following matches for librustc_unicode-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_unicode-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libcollections-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcollections-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libcollections-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libcollections-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcollections-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libcollections/lib.rs
src/libcollections/binary_heap.rs:608:5: 608:22 warning: you have declared `#[inline(always)]` on `pos`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/binary_heap.rs:608 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/binary_heap.rs:608:5: 608:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/binary_heap.rs:612:5: 612:22 warning: you have declared `#[inline(always)]` on `removed`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/binary_heap.rs:612 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/binary_heap.rs:612:5: 612:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/binary_heap.rs:622:5: 622:22 warning: you have declared `#[inline(always)]` on `get`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/binary_heap.rs:622 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/binary_heap.rs:622:5: 622:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/binary_heap.rs:631:5: 631:22 warning: you have declared `#[inline(always)]` on `move_to`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/binary_heap.rs:631 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/binary_heap.rs:631:5: 631:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/btree/node.rs:348:5: 353:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:348 pub fn as_slices<'a>(&'a self) -> (&'a [K], &'a [V]) {
src/libcollections/btree/node.rs:349 unsafe {(
src/libcollections/btree/node.rs:350 slice::from_raw_parts(*self.keys, self.len()),
src/libcollections/btree/node.rs:351 slice::from_raw_parts(*self.vals, self.len()),
src/libcollections/btree/node.rs:352 )}
src/libcollections/btree/node.rs:353 }
src/libcollections/btree/node.rs:348:5: 353:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:356:5: 361:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:356 pub fn as_slices_mut<'a>(&'a mut self) -> (&'a mut [K], &'a mut [V]) {
src/libcollections/btree/node.rs:357 unsafe {(
src/libcollections/btree/node.rs:358 slice::from_raw_parts_mut(*self.keys, self.len()),
src/libcollections/btree/node.rs:359 slice::from_raw_parts_mut(*self.vals, self.len()),
src/libcollections/btree/node.rs:360 )}
src/libcollections/btree/node.rs:361 }
src/libcollections/btree/node.rs:356:5: 361:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:364:5: 386:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:364 pub fn as_slices_internal<'b>(&'b self) -> NodeSlice<'b, K, V> {
src/libcollections/btree/node.rs:365 let is_leaf = self.is_leaf();
src/libcollections/btree/node.rs:366 let (keys, vals) = self.as_slices();
src/libcollections/btree/node.rs:367 let edges: &[_] = if self.is_leaf() {
src/libcollections/btree/node.rs:368 &[]
src/libcollections/btree/node.rs:369 } else {
...
src/libcollections/btree/node.rs:364:5: 386:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:389:5: 413:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:389 pub fn as_slices_internal_mut<'b>(&'b mut self) -> MutNodeSlice<'b, K, V> {
src/libcollections/btree/node.rs:390 let len = self.len();
src/libcollections/btree/node.rs:391 let is_leaf = self.is_leaf();
src/libcollections/btree/node.rs:392 let keys = unsafe { slice::from_raw_parts_mut(*self.keys, len) };
src/libcollections/btree/node.rs:393 let vals = unsafe { slice::from_raw_parts_mut(*self.vals, len) };
src/libcollections/btree/node.rs:394 let edges: &mut [_] = if is_leaf {
...
src/libcollections/btree/node.rs:389:5: 413:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:416:5: 418:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:416 pub fn keys<'a>(&'a self) -> &'a [K] {
src/libcollections/btree/node.rs:417 self.as_slices().0
src/libcollections/btree/node.rs:418 }
src/libcollections/btree/node.rs:416:5: 418:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:421:5: 423:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:421 pub fn keys_mut<'a>(&'a mut self) -> &'a mut [K] {
src/libcollections/btree/node.rs:422 self.as_slices_mut().0
src/libcollections/btree/node.rs:423 }
src/libcollections/btree/node.rs:421:5: 423:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:426:5: 428:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:426 pub fn vals<'a>(&'a self) -> &'a [V] {
src/libcollections/btree/node.rs:427 self.as_slices().1
src/libcollections/btree/node.rs:428 }
src/libcollections/btree/node.rs:426:5: 428:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:431:5: 433:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:431 pub fn vals_mut<'a>(&'a mut self) -> &'a mut [V] {
src/libcollections/btree/node.rs:432 self.as_slices_mut().1
src/libcollections/btree/node.rs:433 }
src/libcollections/btree/node.rs:431:5: 433:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:436:5: 438:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:436 pub fn edges<'a>(&'a self) -> &'a [Node<K, V>] {
src/libcollections/btree/node.rs:437 self.as_slices_internal().edges
src/libcollections/btree/node.rs:438 }
src/libcollections/btree/node.rs:436:5: 438:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:441:5: 443:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:441 pub fn edges_mut<'a>(&'a mut self) -> &'a mut [Node<K, V>] {
src/libcollections/btree/node.rs:442 self.as_slices_internal_mut().edges
src/libcollections/btree/node.rs:443 }
src/libcollections/btree/node.rs:441:5: 443:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:659:32: 659:44 warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [-W wrong-self-convention]
src/libcollections/btree/node.rs:659 pub unsafe fn from_raw<'a>(&'a self) -> Handle<&'a Node<K, V>, Type, NodeType> {
^~~~~~~~~~~~
src/libcollections/btree/node.rs:659:32: 659:44 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/libcollections/btree/node.rs:670:36: 670:52 warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [-W wrong-self-convention]
src/libcollections/btree/node.rs:670 pub unsafe fn from_raw_mut<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, Type, NodeType> {
^~~~~~~~~~~~~~~~
src/libcollections/btree/node.rs:670:36: 670:52 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/libcollections/btree/node.rs:659:5: 665:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:659 pub unsafe fn from_raw<'a>(&'a self) -> Handle<&'a Node<K, V>, Type, NodeType> {
src/libcollections/btree/node.rs:660 Handle {
src/libcollections/btree/node.rs:661 node: &*self.node,
src/libcollections/btree/node.rs:662 index: self.index,
src/libcollections/btree/node.rs:663 marker: PhantomData,
src/libcollections/btree/node.rs:664 }
...
src/libcollections/btree/node.rs:659:5: 665:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:670:5: 676:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:670 pub unsafe fn from_raw_mut<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, Type, NodeType> {
src/libcollections/btree/node.rs:671 Handle {
src/libcollections/btree/node.rs:672 node: &mut *self.node,
src/libcollections/btree/node.rs:673 index: self.index,
src/libcollections/btree/node.rs:674 marker: PhantomData,
src/libcollections/btree/node.rs:675 }
...
src/libcollections/btree/node.rs:670:5: 676:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:859:5: 865:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:859 unsafe fn left_kv<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, handle::KV, NodeType> {
src/libcollections/btree/node.rs:860 Handle {
src/libcollections/btree/node.rs:861 node: &mut *self.node,
src/libcollections/btree/node.rs:862 index: self.index - 1,
src/libcollections/btree/node.rs:863 marker: PhantomData,
src/libcollections/btree/node.rs:864 }
...
src/libcollections/btree/node.rs:859:5: 865:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:870:5: 876:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:870 unsafe fn right_kv<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, handle::KV, NodeType> {
src/libcollections/btree/node.rs:871 Handle {
src/libcollections/btree/node.rs:872 node: &mut *self.node,
src/libcollections/btree/node.rs:873 index: self.index,
src/libcollections/btree/node.rs:874 marker: PhantomData,
src/libcollections/btree/node.rs:875 }
...
src/libcollections/btree/node.rs:870:5: 876:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:962:5: 968:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:962 pub fn left_edge<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, handle::Edge, NodeType> {
src/libcollections/btree/node.rs:963 Handle {
src/libcollections/btree/node.rs:964 node: &mut *self.node,
src/libcollections/btree/node.rs:965 index: self.index,
src/libcollections/btree/node.rs:966 marker: PhantomData,
src/libcollections/btree/node.rs:967 }
...
src/libcollections/btree/node.rs:962:5: 968:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:972:5: 978:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:972 pub fn right_edge<'a>(&'a mut self) -> Handle<&'a mut Node<K, V>, handle::Edge, NodeType> {
src/libcollections/btree/node.rs:973 Handle {
src/libcollections/btree/node.rs:974 node: &mut *self.node,
src/libcollections/btree/node.rs:975 index: self.index + 1,
src/libcollections/btree/node.rs:976 marker: PhantomData,
src/libcollections/btree/node.rs:977 }
...
src/libcollections/btree/node.rs:972:5: 978:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:1098:5: 1117:6 warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libcollections/btree/node.rs:1098 pub fn into_iter(self) -> MoveTraversal<K, V> {
src/libcollections/btree/node.rs:1099 unsafe {
src/libcollections/btree/node.rs:1100 let ret = MoveTraversal {
src/libcollections/btree/node.rs:1101 inner: MoveTraversalImpl {
src/libcollections/btree/node.rs:1102 keys: RawItems::from_slice(self.keys()),
src/libcollections/btree/node.rs:1103 vals: RawItems::from_slice(self.vals()),
...
src/libcollections/btree/node.rs:1098:5: 1117:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libcollections/btree/node.rs:1090:5: 1092:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:1090 pub fn iter<'a>(&'a self) -> Traversal<'a, K, V> {
src/libcollections/btree/node.rs:1091 self.as_slices_internal().iter()
src/libcollections/btree/node.rs:1092 }
src/libcollections/btree/node.rs:1090:5: 1092:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:1094:5: 1096:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/node.rs:1094 pub fn iter_mut<'a>(&'a mut self) -> MutTraversal<'a, K, V> {
src/libcollections/btree/node.rs:1095 self.as_slices_internal_mut().iter_mut()
src/libcollections/btree/node.rs:1096 }
src/libcollections/btree/node.rs:1094:5: 1096:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/node.rs:1203:9: 1203:13 warning: returning the result of a let binding. Consider returning the expression directly. [-W let-and-return]
src/libcollections/btree/node.rs:1203 edge
^~~~
src/libcollections/btree/node.rs:1203:9: 1203:13 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_and_return
src/libcollections/btree/node.rs:1201:20: 1201:73 note: this expression can be directly returned
src/libcollections/btree/node.rs:1201 let edge = ptr::read(self.edges().get_unchecked(self.len() + 1));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcollections/btree/map.rs:105:12: 105:60 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libcollections/btree/map.rs:105 inner: Map<Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a K>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcollections/btree/map.rs:105:12: 105:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libcollections/btree/map.rs:111:12: 111:60 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libcollections/btree/map.rs:111 inner: Map<Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a V>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcollections/btree/map.rs:111:12: 111:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libcollections/btree/map.rs:768:25: 772:26 warning: unneeded return statement. Consider using `SearchStack {
map: self.map,
stack: self.stack,
top: leaf_handle.as_raw()
}` without the return and trailing semicolon [-W needless-return]
src/libcollections/btree/map.rs:768 return SearchStack {
src/libcollections/btree/map.rs:769 map: self.map,
src/libcollections/btree/map.rs:770 stack: self.stack,
src/libcollections/btree/map.rs:771 top: leaf_handle.as_raw()
src/libcollections/btree/map.rs:772 }
src/libcollections/btree/map.rs:768:25: 772:26 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libcollections/btree/map.rs:1296:5: 1301:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/map.rs:1296 pub fn keys<'a>(&'a self) -> Keys<'a, K, V> {
src/libcollections/btree/map.rs:1297 fn first<A, B>((a, _): (A, B)) -> A { a }
src/libcollections/btree/map.rs:1298 let first: fn((&'a K, &'a V)) -> &'a K = first; // coerce to fn pointer
src/libcollections/btree/map.rs:1299
src/libcollections/btree/map.rs:1300 Keys { inner: self.iter().map(first) }
src/libcollections/btree/map.rs:1301 }
src/libcollections/btree/map.rs:1296:5: 1301:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/map.rs:1318:5: 1323:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/btree/map.rs:1318 pub fn values<'a>(&'a self) -> Values<'a, K, V> {
src/libcollections/btree/map.rs:1319 fn second<A, B>((_, b): (A, B)) -> B { b }
src/libcollections/btree/map.rs:1320 let second: fn((&'a K, &'a V)) -> &'a V = second; // coerce to fn pointer
src/libcollections/btree/map.rs:1321
src/libcollections/btree/map.rs:1322 Values { inner: self.iter().map(second) }
src/libcollections/btree/map.rs:1323 }
src/libcollections/btree/map.rs:1318:5: 1323:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/btree/set.rs:50:11: 50:62 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libcollections/btree/set.rs:50 iter: Map<::btree_map::IntoIter<T, ()>, fn((T, ())) -> T>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcollections/btree/set.rs:50:11: 50:62 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libcollections/btree/set.rs:55:11: 55:75 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libcollections/btree/set.rs:55 iter: Map<::btree_map::Range<'a, T, ()>, fn((&'a T, &'a ())) -> &'a T>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libcollections/btree/set.rs:55:11: 55:75 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libcollections/borrow.rs:126:19: 126:32 warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [-W wrong-self-convention]
src/libcollections/borrow.rs:126 pub fn to_mut(&mut self) -> &mut <B as ToOwned>::Owned {
^~~~~~~~~~~~~
src/libcollections/borrow.rs:126:19: 126:32 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention
src/libcollections/linked_list.rs:110:5: 112:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/linked_list.rs:110 unsafe fn resolve<'a>(&self) -> Option<&'a T> {
src/libcollections/linked_list.rs:111 self.p.as_ref()
src/libcollections/linked_list.rs:112 }
src/libcollections/linked_list.rs:110:5: 112:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/linked_list.rs:120:5: 122:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/linked_list.rs:120 unsafe fn resolve_mut<'a>(&mut self) -> Option<&'a mut T> {
src/libcollections/linked_list.rs:121 self.p.as_mut()
src/libcollections/linked_list.rs:122 }
src/libcollections/linked_list.rs:120:5: 122:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/slice.rs:1111:5: 1111:22 warning: you have declared `#[inline(always)]` on `step`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/slice.rs:1111 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/slice.rs:1111:5: 1111:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/str.rs:229:5: 229:22 warning: you have declared `#[inline(always)]` on `as_bytes`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libcollections/str.rs:229 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libcollections/str.rs:229:5: 229:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libcollections/str.rs:682:5: 684:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:682 pub fn contains<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool {
src/libcollections/str.rs:683 core_str::StrExt::contains(self, pat)
src/libcollections/str.rs:684 }
src/libcollections/str.rs:682:5: 684:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:694:5: 696:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:694 pub fn starts_with<'a, P: Pattern<'a>>(&'a self, pat: P) -> bool {
src/libcollections/str.rs:695 core_str::StrExt::starts_with(self, pat)
src/libcollections/str.rs:696 }
src/libcollections/str.rs:694:5: 696:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:753:5: 755:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:753 pub fn find<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize> {
src/libcollections/str.rs:754 core_str::StrExt::find(self, pat)
src/libcollections/str.rs:755 }
src/libcollections/str.rs:753:5: 755:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:875:5: 877:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:875 pub fn split<'a, P: Pattern<'a>>(&'a self, pat: P) -> Split<'a, P> {
src/libcollections/str.rs:876 core_str::StrExt::split(self, pat)
src/libcollections/str.rs:877 }
src/libcollections/str.rs:875:5: 877:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:961:5: 963:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:961 pub fn split_terminator<'a, P: Pattern<'a>>(&'a self, pat: P) -> SplitTerminator<'a, P> {
src/libcollections/str.rs:962 core_str::StrExt::split_terminator(self, pat)
src/libcollections/str.rs:963 }
src/libcollections/str.rs:961:5: 963:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:1046:5: 1048:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:1046 pub fn splitn<'a, P: Pattern<'a>>(&'a self, count: usize, pat: P) -> SplitN<'a, P> {
src/libcollections/str.rs:1047 core_str::StrExt::splitn(self, count, pat)
src/libcollections/str.rs:1048 }
src/libcollections/str.rs:1046:5: 1048:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:1125:5: 1127:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:1125 pub fn matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> Matches<'a, P> {
src/libcollections/str.rs:1126 core_str::StrExt::matches(self, pat)
src/libcollections/str.rs:1127 }
src/libcollections/str.rs:1125:5: 1127:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:1205:5: 1207:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:1205 pub fn match_indices<'a, P: Pattern<'a>>(&'a self, pat: P) -> MatchIndices<'a, P> {
src/libcollections/str.rs:1206 core_str::StrExt::match_indices(self, pat)
src/libcollections/str.rs:1207 }
src/libcollections/str.rs:1205:5: 1207:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:1342:5: 1344:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/str.rs:1342 pub fn trim_left_matches<'a, P: Pattern<'a>>(&'a self, pat: P) -> &'a str {
src/libcollections/str.rs:1343 core_str::StrExt::trim_left_matches(self, pat)
src/libcollections/str.rs:1344 }
src/libcollections/str.rs:1342:5: 1344:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/str.rs:1488:9: 1488:17 warning: unneeded return statement. Consider using `s` without the return and trailing semicolon [-W needless-return]
src/libcollections/str.rs:1488 return s;
^~~~~~~~
src/libcollections/str.rs:1488:9: 1488:17 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libcollections/string.rs:135:5: 250:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libcollections/string.rs:135 pub fn from_utf8_lossy<'a>(v: &'a [u8]) -> Cow<'a, str> {
src/libcollections/string.rs:136 let mut i;
src/libcollections/string.rs:137 match str::from_utf8(v) {
src/libcollections/string.rs:138 Ok(s) => return Cow::Borrowed(s),
src/libcollections/string.rs:139 Err(e) => i = e.valid_up_to(),
src/libcollections/string.rs:140 }
...
src/libcollections/string.rs:135:5: 250:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libcollections/vec.rs:546:13: 552:14 warning: the loop variable `i` is used to index `v`. Consider using `for (i, item) in v.iter().enumerate()` or similar iterators [-W needless-range-loop]
src/libcollections/vec.rs:546 for i in 0..len {
src/libcollections/vec.rs:547 if !f(&v[i]) {
src/libcollections/vec.rs:548 del += 1;
src/libcollections/vec.rs:549 } else if del > 0 {
src/libcollections/vec.rs:550 v.swap(i-del, i);
src/libcollections/vec.rs:551 }
...
note: in expansion of for loop expansion
src/libcollections/vec.rs:546:13: 552:14 note: expansion site
src/libcollections/vec.rs:546:13: 552:14 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/libcollections/vec_deque.rs:1297:9: 1297:20 warning: unneeded return statement. Consider using `elem` without the return and trailing semicolon [-W needless-return]
src/libcollections/vec_deque.rs:1297 return elem;
^~~~~~~~~~~
src/libcollections/vec_deque.rs:1297:9: 1297:20 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libcollections/vec_deque.rs:1424:9: 1430:10 warning: the loop variable `i` is used to index `self`. Consider using `for (i, item) in self.iter().enumerate()` or similar iterators [-W needless-range-loop]
src/libcollections/vec_deque.rs:1424 for i in 0..len {
src/libcollections/vec_deque.rs:1425 if !f(&self[i]) {
src/libcollections/vec_deque.rs:1426 del += 1;
src/libcollections/vec_deque.rs:1427 } else if del > 0 {
src/libcollections/vec_deque.rs:1428 self.swap(i-del, i);
src/libcollections/vec_deque.rs:1429 }
...
note: in expansion of for loop expansion
src/libcollections/vec_deque.rs:1424:9: 1430:10 note: expansion site
src/libcollections/vec_deque.rs:1424:9: 1430:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
info: now are following matches for libcollections-*.so libraries:
info: now are following matches for libcollections-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcollections-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc_jemalloc-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_jemalloc-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liballoc_jemalloc-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liballoc_jemalloc-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_jemalloc-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/liballoc_jemalloc/lib.rs
info: now are following matches for liballoc_jemalloc-*.so libraries:
info: now are following matches for liballoc_jemalloc-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liballoc_jemalloc-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libstd-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libstd-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libstd-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libstd-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libstd/lib.rs
src/libstd/ascii.rs:197:9: 197:18 warning: unneeded return statement. Consider using `me` without the return and trailing semicolon [-W needless-return]
src/libstd/ascii.rs:197 return me
^~~~~~~~~
src/libstd/ascii.rs:197:9: 197:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/ascii.rs:204:9: 204:18 warning: unneeded return statement. Consider using `me` without the return and trailing semicolon [-W needless-return]
src/libstd/ascii.rs:204 return me
^~~~~~~~~
src/libstd/ascii.rs:204:9: 204:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/collections/hash/table.rs:143:5: 143:22 warning: you have declared `#[inline(always)]` on `inspect`. This is usually a bad idea. Are you sure? [-W inline-always]
src/libstd/collections/hash/table.rs:143 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/libstd/collections/hash/table.rs:143:5: 143:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
src/libstd/collections/hash/table.rs:692:5: 703:6 warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libstd/collections/hash/table.rs:692 pub fn into_iter(self) -> IntoIter<K, V> {
src/libstd/collections/hash/table.rs:693 let RawBuckets { raw, hashes_end, .. } = self.raw_buckets();
src/libstd/collections/hash/table.rs:694 // Replace the marker regardless of lifetime bounds on parameters.
src/libstd/collections/hash/table.rs:695 IntoIter {
src/libstd/collections/hash/table.rs:696 iter: RawBuckets {
src/libstd/collections/hash/table.rs:697 raw: raw,
...
src/libstd/collections/hash/table.rs:692:5: 703:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libstd/collections/hash/map.rs:350:9: 355:10 warning: this if statement can be collapsed [-W collapsible-if]
src/libstd/collections/hash/map.rs:350 if hash == full.hash() {
src/libstd/collections/hash/map.rs:351 // If the key doesn't match, it can't be this one..
src/libstd/collections/hash/map.rs:352 if is_match(full.read().0) {
src/libstd/collections/hash/map.rs:353 return FoundExisting(full);
src/libstd/collections/hash/map.rs:354 }
src/libstd/collections/hash/map.rs:355 }
src/libstd/collections/hash/map.rs:350:9: 355:10 help: try
if hash == full.hash() && (is_match(full.read().0)) {
return FoundExisting(full);
}
for further information visit https://github.com/Manishearth/rust-clippy/wiki#collapsible_if
src/libstd/collections/hash/map.rs:386:1: 437:2 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/collections/hash/map.rs:386 fn robin_hood<'a, K: 'a, V: 'a>(mut bucket: FullBucketMut<'a, K, V>,
src/libstd/collections/hash/map.rs:387 mut ib: usize,
src/libstd/collections/hash/map.rs:388 mut hash: SafeHash,
src/libstd/collections/hash/map.rs:389 mut k: K,
src/libstd/collections/hash/map.rs:390 mut v: V)
src/libstd/collections/hash/map.rs:391 -> &'a mut V {
...
src/libstd/collections/hash/map.rs:386:1: 437:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/collections/hash/map.rs:775:5: 819:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/collections/hash/map.rs:775 fn insert_or_replace_with<'a, F>(&'a mut self,
src/libstd/collections/hash/map.rs:776 hash: SafeHash,
src/libstd/collections/hash/map.rs:777 k: K,
src/libstd/collections/hash/map.rs:778 v: V,
src/libstd/collections/hash/map.rs:779 mut found_existing: F)
src/libstd/collections/hash/map.rs:780 -> &'a mut V where
...
src/libstd/collections/hash/map.rs:775:5: 819:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/collections/hash/map.rs:798:13: 807:14 warning: this if statement can be collapsed [-W collapsible-if]
src/libstd/collections/hash/map.rs:798 if bucket.hash() == hash {
src/libstd/collections/hash/map.rs:799 // key matches?
src/libstd/collections/hash/map.rs:800 if k == *bucket.read_mut().0 {
src/libstd/collections/hash/map.rs:801 let (bucket_k, bucket_v) = bucket.into_mut_refs();
src/libstd/collections/hash/map.rs:802 debug_assert!(k == *bucket_k);
src/libstd/collections/hash/map.rs:803 // Key already exists. Get its reference.
...
src/libstd/collections/hash/map.rs:798:13: 807:14 help: try
if bucket.hash() == hash && k == *bucket.read_mut().0 {
let (bucket_k, bucket_v) = bucket.into_mut_refs();
debug_assert!(k == *bucket_k);
// Key already exists. Get its reference.
found_existing(bucket_k, bucket_v, k, v);
return bucket_v;
}
for further information visit https://github.com/Manishearth/rust-clippy/wiki#collapsible_if
src/libstd/collections/hash/map.rs:839:5: 844:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/collections/hash/map.rs:839 pub fn keys<'a>(&'a self) -> Keys<'a, K, V> {
src/libstd/collections/hash/map.rs:840 fn first<A, B>((a, _): (A, B)) -> A { a }
src/libstd/collections/hash/map.rs:841 let first: fn((&'a K,&'a V)) -> &'a K = first; // coerce to fn ptr
src/libstd/collections/hash/map.rs:842
src/libstd/collections/hash/map.rs:843 Keys { inner: self.iter().map(first) }
src/libstd/collections/hash/map.rs:844 }
src/libstd/collections/hash/map.rs:839:5: 844:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/collections/hash/map.rs:864:5: 869:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/collections/hash/map.rs:864 pub fn values<'a>(&'a self) -> Values<'a, K, V> {
src/libstd/collections/hash/map.rs:865 fn second<A, B>((_, b): (A, B)) -> B { b }
src/libstd/collections/hash/map.rs:866 let second: fn((&'a K,&'a V)) -> &'a V = second; // coerce to fn ptr
src/libstd/collections/hash/map.rs:867
src/libstd/collections/hash/map.rs:868 Values { inner: self.iter().map(second) }
src/libstd/collections/hash/map.rs:869 }
src/libstd/collections/hash/map.rs:864:5: 869:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/collections/hash/map.rs:1161:1: 1206:2 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/collections/hash/map.rs:1161 fn search_entry_hashed<'a, K: Eq, V>(table: &'a mut RawTable<K,V>, hash: SafeHash, k: K)
src/libstd/collections/hash/map.rs:1162 -> Entry<'a, K, V>
src/libstd/collections/hash/map.rs:1163 {
src/libstd/collections/hash/map.rs:1164 // Worst case, we'll find one empty bucket among `size + 1` buckets.
src/libstd/collections/hash/map.rs:1165 let size = table.size();
src/libstd/collections/hash/map.rs:1166 let mut probe = Bucket::new(table, hash);
...
src/libstd/collections/hash/map.rs:1161:1: 1206:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/collections/hash/map.rs:1183:9: 1190:10 warning: this if statement can be collapsed [-W collapsible-if]
src/libstd/collections/hash/map.rs:1183 if bucket.hash() == hash {
src/libstd/collections/hash/map.rs:1184 // key matches?
src/libstd/collections/hash/map.rs:1185 if k == *bucket.read().0 {
src/libstd/collections/hash/map.rs:1186 return Occupied(OccupiedEntry{
src/libstd/collections/hash/map.rs:1187 elem: bucket,
src/libstd/collections/hash/map.rs:1188 });
...
src/libstd/collections/hash/map.rs:1183:9: 1190:10 help: try
if bucket.hash() == hash && k == *bucket.read().0 {
return Occupied(OccupiedEntry{
elem: bucket,
});
}
for further information visit https://github.com/Manishearth/rust-clippy/wiki#collapsible_if
src/libstd/collections/hash/map.rs:1282:12: 1282:76 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/map.rs:1282 inner: iter::Map<table::IntoIter<K, V>, fn((SafeHash, K, V)) -> (K, V)>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/map.rs:1282:12: 1282:76 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/collections/hash/map.rs:1288:12: 1288:60 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/map.rs:1288 inner: Map<Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a K>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/map.rs:1288:12: 1288:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/collections/hash/map.rs:1303:12: 1303:60 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/map.rs:1303 inner: Map<Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a V>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/map.rs:1303:12: 1303:60 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/collections/hash/map.rs:1320:12: 1320:77 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/map.rs:1320 inner: iter::Map<table::Drain<'a, K, V>, fn((SafeHash, K, V)) -> (K, V)>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/map.rs:1320:12: 1320:77 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/collections/hash/set.rs:815:11: 815:54 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/set.rs:815 iter: Map<map::IntoIter<K, ()>, fn((K, ())) -> K>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/set.rs:815:11: 815:54 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/collections/hash/set.rs:821:11: 821:55 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/collections/hash/set.rs:821 iter: Map<map::Drain<'a, K, ()>, fn((K, ())) -> K>,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/collections/hash/set.rs:821:11: 821:55 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/dynamic_lib.rs:75:9: 75:22 warning: unneeded return statement. Consider using `newvar` without the return and trailing semicolon [-W needless-return]
src/libstd/dynamic_lib.rs:75 return newvar;
^~~~~~~~~~~~~
src/libstd/dynamic_lib.rs:75:9: 75:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/fs.rs:563:5: 563:5 warning: item `Metadata` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libstd/fs.rs:563 pub fn len(&self) -> u64 { self.0.size() }
^
src/libstd/fs.rs:563:5: 563:5 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libstd/io/buffered.rs:778:9: 778:17 warning: unneeded return statement. Consider using `w` without the return and trailing semicolon [-W needless-return]
src/libstd/io/buffered.rs:778 return w;
^~~~~~~~
src/libstd/io/buffered.rs:778:9: 778:17 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/net/ip.rs:417:21: 433:22 warning: the loop variable `i` is used to index `segments`. Consider using `for (i, item) in segments.iter().enumerate()` or similar iterators [-W needless-range-loop]
src/libstd/net/ip.rs:417 for i in 0..8 {
src/libstd/net/ip.rs:418 if segments[i] == 0 {
src/libstd/net/ip.rs:419 if cur_span_len == 0 {
src/libstd/net/ip.rs:420 cur_span_at = i;
src/libstd/net/ip.rs:421 }
src/libstd/net/ip.rs:422
...
note: in expansion of for loop expansion
src/libstd/net/ip.rs:417:21: 433:22 note: expansion site
src/libstd/net/ip.rs:417:21: 433:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/libstd/net/parser.rs:66:39: 66:92 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/net/parser.rs:66 fn read_or<T>(&mut self, parsers: &mut [Box<FnMut(&mut Parser) -> Option<T> + 'static>])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/net/parser.rs:66:39: 66:92 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/net/parser.rs:214:32: 214:37 warning: the operation is ineffective. Consider reducing it to `i` [-W identity-op]
src/libstd/net/parser.rs:214 groups[i + 0] = ((octets[0] as u16) << 8) | (octets[1] as u16);
^~~~~
note: in expansion of if let expansion
src/libstd/net/parser.rs:212:21: 217:22 note: expansion site
src/libstd/net/parser.rs:214:32: 214:37 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
src/libstd/path.rs:292:5: 292:5 warning: item `Prefix<'a>` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libstd/path.rs:292 fn len(&self) -> usize {
^
src/libstd/path.rs:292:5: 292:5 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libstd/sync/mpsc/select.rs:255:13: 255:28 warning: unneeded return statement. Consider using `ready_id` without the return and trailing semicolon [-W needless-return]
src/libstd/sync/mpsc/select.rs:255 return ready_id;
^~~~~~~~~~~~~~~
src/libstd/sync/mpsc/select.rs:255:13: 255:28 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/sync/mpsc/shared.rs:79:9: 79:17 warning: unneeded return statement. Consider using `p` without the return and trailing semicolon [-W needless-return]
src/libstd/sync/mpsc/shared.rs:79 return p;
^~~~~~~~
src/libstd/sync/mpsc/shared.rs:79:9: 79:17 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libstd/sync/mpsc/mod.rs:401:5: 403:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/sync/mpsc/mod.rs:401 unsafe fn inner_mut<'a>(&'a self) -> &'a mut Flavor<T> {
src/libstd/sync/mpsc/mod.rs:402 &mut *self.inner_unsafe().get()
src/libstd/sync/mpsc/mod.rs:403 }
src/libstd/sync/mpsc/mod.rs:401:5: 403:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/sync/mpsc/mod.rs:404:5: 406:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libstd/sync/mpsc/mod.rs:404 unsafe fn inner<'a>(&'a self) -> &'a Flavor<T> {
src/libstd/sync/mpsc/mod.rs:405 &*self.inner_unsafe().get()
src/libstd/sync/mpsc/mod.rs:406 }
src/libstd/sync/mpsc/mod.rs:404:5: 406:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libstd/sys/common/wtf8.rs:178:5: 180:6 warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libstd/sys/common/wtf8.rs:178 pub fn from_str(str: &str) -> Wtf8Buf {
src/libstd/sys/common/wtf8.rs:179 Wtf8Buf { bytes: <[_]>::to_vec(str.as_bytes()) }
src/libstd/sys/common/wtf8.rs:180 }
src/libstd/sys/common/wtf8.rs:178:5: 180:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libstd/sys/common/wtf8.rs:474:5: 474:5 warning: item `Wtf8` has a `.len(_: &Self)` method, but no `.is_empty(_: &Self)` method. Consider adding one [-W len-without-is-empty]
src/libstd/sys/common/wtf8.rs:474 pub fn len(&self) -> usize {
^
src/libstd/sys/common/wtf8.rs:474:5: 474:5 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty
src/libstd/sys/common/wtf8.rs:459:5: 461:6 warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libstd/sys/common/wtf8.rs:459 pub fn from_str(value: &str) -> &Wtf8 {
src/libstd/sys/common/wtf8.rs:460 unsafe { Wtf8::from_bytes_unchecked(value.as_bytes()) }
src/libstd/sys/common/wtf8.rs:461 }
src/libstd/sys/common/wtf8.rs:459:5: 461:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 132:40 warning: equal expressions as operands to || [-W eq-op]
src/libstd/sys/common/gnu/libbacktrace.rs:128 let selfname = if cfg!(target_os = "freebsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:129 cfg!(target_os = "dragonfly") ||
src/libstd/sys/common/gnu/libbacktrace.rs:130 cfg!(target_os = "bitrig") ||
src/libstd/sys/common/gnu/libbacktrace.rs:131 cfg!(target_os = "openbsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:132 cfg!(target_os = "windows") {
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 132:40 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 131:40 warning: equal expressions as operands to || [-W eq-op]
src/libstd/sys/common/gnu/libbacktrace.rs:128 let selfname = if cfg!(target_os = "freebsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:129 cfg!(target_os = "dragonfly") ||
src/libstd/sys/common/gnu/libbacktrace.rs:130 cfg!(target_os = "bitrig") ||
src/libstd/sys/common/gnu/libbacktrace.rs:131 cfg!(target_os = "openbsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 131:40 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 130:39 warning: equal expressions as operands to || [-W eq-op]
src/libstd/sys/common/gnu/libbacktrace.rs:128 let selfname = if cfg!(target_os = "freebsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:129 cfg!(target_os = "dragonfly") ||
src/libstd/sys/common/gnu/libbacktrace.rs:130 cfg!(target_os = "bitrig") ||
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 130:39 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 129:42 warning: equal expressions as operands to || [-W eq-op]
src/libstd/sys/common/gnu/libbacktrace.rs:128 let selfname = if cfg!(target_os = "freebsd") ||
src/libstd/sys/common/gnu/libbacktrace.rs:129 cfg!(target_os = "dragonfly") ||
src/libstd/sys/common/gnu/libbacktrace.rs:128:27: 129:42 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:75:26: 75:78 warning: equal expressions as operands to || [-W eq-op]
src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:75 let symaddr = if cfg!(target_os = "macos") || cfg!(target_os = "ios") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:75:26: 75:78 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#eq_op
src/libstd/sys/unix/os.rs:133:11: 134:45 warning: very complex type used. Consider factoring parts into `type` definitions [-W type-complexity]
src/libstd/sys/unix/os.rs:133 iter: iter::Map<slice::Split<'a, u8, fn(&u8) -> bool>,
src/libstd/sys/unix/os.rs:134 fn(&'a [u8]) -> PathBuf>,
src/libstd/sys/unix/os.rs:133:11: 134:45 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#type_complexity
src/libstd/sys/unix/os_str.rs:65:5: 67:6 warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libstd/sys/unix/os_str.rs:65 pub fn from_str(s: &str) -> &Slice {
src/libstd/sys/unix/os_str.rs:66 Slice::from_u8_slice(s.as_bytes())
src/libstd/sys/unix/os_str.rs:67 }
src/libstd/sys/unix/os_str.rs:65:5: 67:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
src/libstd/sys/unix/process.rs:198:50: 198:56 warning: the operation is ineffective. Consider reducing it to `d` [-W identity-op]
src/libstd/sys/unix/process.rs:198 ((a << 24) | (b << 16) | (c << 8) | (d << 0)) as i32
^~~~~~
src/libstd/sys/unix/process.rs:198:50: 198:56 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
src/libstd/sys/unix/process.rs:246:18: 246:29 warning: the operation is ineffective. Consider reducing it to `errno` [-W identity-op]
src/libstd/sys/unix/process.rs:246 (errno >> 0) as u8,
^~~~~~~~~~~
src/libstd/sys/unix/process.rs:246:18: 246:29 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#identity_op
info: now are following matches for libstd-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.so
info: now are following matches for libstd-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libstd-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libflate-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libflate-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libflate-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libflate-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libflate/lib.rs
info: now are following matches for libflate-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.so
info: now are following matches for libflate-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libflate-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libarena-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libarena-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libarena-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libarena-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libarena/lib.rs
info: now are following matches for libarena-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.so
info: now are following matches for libarena-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libarena-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liblog-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liblog-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'liblog-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'liblog-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/liblog/lib.rs
src/liblog/lib.rs:326:1: 326:18 warning: you have declared `#[inline(always)]` on `log_level`. This is usually a bad idea. Are you sure? [-W inline-always]
src/liblog/lib.rs:326 #[inline(always)]
^~~~~~~~~~~~~~~~~
src/liblog/lib.rs:326:1: 326:18 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#inline_always
info: now are following matches for liblog-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.so
info: now are following matches for liblog-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/liblog-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libterm-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libterm-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libterm-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libterm-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libterm/lib.rs
src/libterm/terminfo/parser/compiled.rs:298:39: 298:55 warning: `name.to_owned()` is faster [-W str-to-string]
src/libterm/terminfo/parser/compiled.rs:298 string_map.insert(name.to_string(),
^~~~~~~~~~~~~~~~
note: in expansion of for loop expansion
src/libterm/terminfo/parser/compiled.rs:273:9: 307:10 note: expansion site
src/libterm/terminfo/parser/compiled.rs:298:39: 298:55 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/libterm/terminfo/mod.rs:163:5: 163:52 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libterm/terminfo/mod.rs:163 fn get_ref<'a>(&'a self) -> &'a T { &self.out }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libterm/terminfo/mod.rs:163:5: 163:52 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libterm/terminfo/mod.rs:165:5: 165:64 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libterm/terminfo/mod.rs:165 fn get_mut<'a>(&'a mut self) -> &'a mut T { &mut self.out }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libterm/terminfo/mod.rs:165:5: 165:64 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libterm/lib.rs:247:5: 247:39 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libterm/lib.rs:247 fn get_ref<'a>(&'a self) -> &'a T;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libterm/lib.rs:247:5: 247:39 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libterm/lib.rs:250:5: 250:47 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libterm/lib.rs:250 fn get_mut<'a>(&'a mut self) -> &'a mut T;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libterm/lib.rs:250:5: 250:47 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
info: now are following matches for libterm-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.so
info: now are following matches for libterm-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libterm-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libserialize-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libserialize-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libserialize-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libserialize-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libserialize/lib.rs
src/libserialize/collection_impls.rs:24:17: 24:30 warning: I see you're using a LinkedList! Perhaps you meant some other data structure? [-W linkedlist]
src/libserialize/collection_impls.rs:24 > Encodable for LinkedList<T> {
^~~~~~~~~~~~~
src/libserialize/collection_impls.rs:24:17: 24:30 help: a RingBuf might work
for further information visit https://github.com/Manishearth/rust-clippy/wiki#linkedlist
src/libserialize/collection_impls.rs:35:33: 35:46 warning: I see you're using a LinkedList! Perhaps you meant some other data structure? [-W linkedlist]
src/libserialize/collection_impls.rs:35 impl<T:Decodable> Decodable for LinkedList<T> {
^~~~~~~~~~~~~
src/libserialize/collection_impls.rs:35:33: 35:46 help: a RingBuf might work
for further information visit https://github.com/Manishearth/rust-clippy/wiki#linkedlist
src/libserialize/collection_impls.rs:36:48: 36:61 warning: I see you're using a LinkedList! Perhaps you meant some other data structure? [-W linkedlist]
src/libserialize/collection_impls.rs:36 fn decode<D: Decoder>(d: &mut D) -> Result<LinkedList<T>, D::Error> {
^~~~~~~~~~~~~
src/libserialize/collection_impls.rs:36:48: 36:61 help: a RingBuf might work
for further information visit https://github.com/Manishearth/rust-clippy/wiki#linkedlist
src/libserialize/json.rs:1066:9: 1082:10 warning: instead of prefixing all patterns with `&`, you can dereference the expression to match: `match *self { ...` [-W match-ref-pats]
src/libserialize/json.rs:1066 match self {
src/libserialize/json.rs:1067 &Json::Object(ref map) => {
src/libserialize/json.rs:1068 match map.get(key) {
src/libserialize/json.rs:1069 Some(json_value) => Some(json_value),
src/libserialize/json.rs:1070 None => {
src/libserialize/json.rs:1071 for (_, v) in map {
...
src/libserialize/json.rs:1066:9: 1082:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
src/libserialize/json.rs:1230:5: 1235:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libserialize/json.rs:1230 fn index<'a>(&'a self, idx: usize) -> &'a Json {
src/libserialize/json.rs:1231 match *self {
src/libserialize/json.rs:1232 Json::Array(ref v) => &v[idx],
src/libserialize/json.rs:1233 _ => panic!("can only index Json with usize if it is an array")
src/libserialize/json.rs:1234 }
src/libserialize/json.rs:1235 }
src/libserialize/json.rs:1230:5: 1235:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libserialize/json.rs:1312:5: 1321:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libserialize/json.rs:1312 pub fn get<'l>(&'l self, idx: usize) -> StackElement<'l> {
src/libserialize/json.rs:1313 match self.stack[idx] {
src/libserialize/json.rs:1314 InternalIndex(i) => StackElement::Index(i),
src/libserialize/json.rs:1315 InternalKey(start, size) => {
src/libserialize/json.rs:1316 StackElement::Key(str::from_utf8(
src/libserialize/json.rs:1317 &self.str_buffer[start as usize .. start as usize + size as usize])
...
src/libserialize/json.rs:1312:5: 1321:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libserialize/json.rs:1354:5: 1364:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libserialize/json.rs:1354 pub fn top<'l>(&'l self) -> Option<StackElement<'l>> {
src/libserialize/json.rs:1355 match self.stack.last() {
src/libserialize/json.rs:1356 None => None,
src/libserialize/json.rs:1357 Some(&InternalIndex(i)) => Some(StackElement::Index(i)),
src/libserialize/json.rs:1358 Some(&InternalKey(start, size)) => {
src/libserialize/json.rs:1359 Some(StackElement::Key(str::from_utf8(
...
src/libserialize/json.rs:1354:5: 1364:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libserialize/json.rs:1395:9: 1398:10 warning: unneeded return statement. Consider using `match *self.stack.last().unwrap() {
InternalIndex(_) => true,
_ => false,
}` without the return and trailing semicolon [-W needless-return]
src/libserialize/json.rs:1395 return match *self.stack.last().unwrap() {
src/libserialize/json.rs:1396 InternalIndex(_) => true,
src/libserialize/json.rs:1397 _ => false,
src/libserialize/json.rs:1398 }
src/libserialize/json.rs:1395:9: 1398:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libserialize/json.rs:1466:5: 1468:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libserialize/json.rs:1466 pub fn stack<'l>(&'l self) -> &'l Stack {
src/libserialize/json.rs:1467 &self.stack
src/libserialize/json.rs:1468 }
src/libserialize/json.rs:1466:5: 1468:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/libserialize/json.rs:2181:13: 2185:14 warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [-W single-match]
src/libserialize/json.rs:2181 match (it.next(), it.next()) {
src/libserialize/json.rs:2182 // exactly one character
src/libserialize/json.rs:2183 (Some(c), None) => return Ok(c),
src/libserialize/json.rs:2184 _ => ()
src/libserialize/json.rs:2185 }
src/libserialize/json.rs:2181:13: 2185:14 help: try
if let (Some(c), None) = (it.next(), it.next()) { return Ok(c) }
for further information visit https://github.com/Manishearth/rust-clippy/wiki#single_match
src/libserialize/json.rs:2216:33: 2216:53 warning: `"fields".to_owned()` is faster [-W str-to-string]
src/libserialize/json.rs:2216 match o.remove(&"fields".to_string()) {
^~~~~~~~~~~~~~~~~~~~
src/libserialize/json.rs:2216:33: 2216:53 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/libserialize/json.rs:2282:39: 2282:55 warning: `name.to_owned()` is faster [-W str-to-string]
src/libserialize/json.rs:2282 let value = match obj.remove(&name.to_string()) {
^~~~~~~~~~~~~~~~
src/libserialize/json.rs:2282:39: 2282:55 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/libserialize/json.rs:2289:60: 2289:76 warning: `name.to_owned()` is faster [-W str-to-string]
src/libserialize/json.rs:2289 Err(_) => return Err(MissingFieldError(name.to_string())),
^~~~~~~~~~~~~~~~
src/libserialize/json.rs:2289:60: 2289:76 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/libserialize/json.rs:2389:26: 2389:41 warning: `err.to_owned()` is faster [-W str-to-string]
src/libserialize/json.rs:2389 ApplicationError(err.to_string())
^~~~~~~~~~~~~~~
src/libserialize/json.rs:2389:26: 2389:41 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/libserialize/json.rs:2449:46: 2449:62 warning: `self.to_owned()` is faster [-W str-to-string]
src/libserialize/json.rs:2449 fn to_json(&self) -> Json { Json::String(self.to_string()) }
^~~~~~~~~~~~~~~~
src/libserialize/json.rs:2449:46: 2449:62 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
info: now are following matches for libserialize-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.so
info: now are following matches for libserialize-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libserialize-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libgetopts-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libgetopts-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libgetopts-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libgetopts-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libgetopts/lib.rs
src/libgetopts/lib.rs:228:5: 234:6 warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [-W should-implement-trait]
src/libgetopts/lib.rs:228 fn from_str(nm: &str) -> Name {
src/libgetopts/lib.rs:229 if nm.len() == 1 {
src/libgetopts/lib.rs:230 Short(nm.char_at(0))
src/libgetopts/lib.rs:231 } else {
src/libgetopts/lib.rs:232 Long(nm.to_owned())
src/libgetopts/lib.rs:233 }
...
src/libgetopts/lib.rs:228:5: 234:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait
info: now are following matches for libgetopts-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.so
info: now are following matches for libgetopts-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgetopts-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librbml-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'librbml-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librbml-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'librbml-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/librbml/lib.rs
src/librbml/lib.rs:156:5: 158:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:156 pub fn get<'a>(&'a self, tag: usize) -> Doc<'a> {
src/librbml/lib.rs:157 reader::get_doc(*self, tag)
src/librbml/lib.rs:158 }
src/librbml/lib.rs:156:5: 158:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:164:5: 166:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:164 pub fn as_str_slice<'a>(&'a self) -> &'a str {
src/librbml/lib.rs:165 str::from_utf8(&self.data[self.start..self.end]).unwrap()
src/librbml/lib.rs:166 }
src/librbml/lib.rs:164:5: 166:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:169:9: 169:40 warning: `self.as_str_slice().to_owned()` is faster [-W str-to-string]
src/librbml/lib.rs:169 self.as_str_slice().to_string()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librbml/lib.rs:169:9: 169:40 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
src/librbml/lib.rs:366:5: 374:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:366 pub fn doc_at<'a>(data: &'a [u8], start: usize) -> DecodeResult<TaggedDoc<'a>> {
src/librbml/lib.rs:367 let elt_tag = try!(tag_at(data, start));
src/librbml/lib.rs:368 let elt_size = try!(tag_len_at(data, elt_tag));
src/librbml/lib.rs:369 let end = elt_size.next + elt_size.val;
src/librbml/lib.rs:370 Ok(TaggedDoc {
src/librbml/lib.rs:371 tag: elt_tag.val,
...
src/librbml/lib.rs:366:5: 374:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:376:5: 388:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:376 pub fn maybe_get_doc<'a>(d: Doc<'a>, tg: usize) -> Option<Doc<'a>> {
src/librbml/lib.rs:377 let mut pos = d.start;
src/librbml/lib.rs:378 while pos < d.end {
src/librbml/lib.rs:379 let elt_tag = try_or!(tag_at(d.data, pos), None);
src/librbml/lib.rs:380 let elt_size = try_or!(tag_len_at(d.data, elt_tag), None);
src/librbml/lib.rs:381 pos = elt_size.next + elt_size.val;
...
src/librbml/lib.rs:376:5: 388:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:390:5: 398:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:390 pub fn get_doc<'a>(d: Doc<'a>, tg: usize) -> Doc<'a> {
src/librbml/lib.rs:391 match maybe_get_doc(d, tg) {
src/librbml/lib.rs:392 Some(d) => d,
src/librbml/lib.rs:393 None => {
src/librbml/lib.rs:394 error!("failed to find block with tag {:?}", tg);
src/librbml/lib.rs:395 panic!();
...
src/librbml/lib.rs:390:5: 398:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:400:5: 404:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:400 pub fn docs<'a>(d: Doc<'a>) -> DocsIterator<'a> {
src/librbml/lib.rs:401 DocsIterator {
src/librbml/lib.rs:402 d: d
src/librbml/lib.rs:403 }
src/librbml/lib.rs:404 }
src/librbml/lib.rs:400:5: 404:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:435:13: 435:44 warning: unneeded return statement. Consider using `Some((elt_tag.val, doc))` without the return and trailing semicolon [-W needless-return]
src/librbml/lib.rs:435 return Some((elt_tag.val, doc));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/librbml/lib.rs:435:13: 435:44 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/librbml/lib.rs:439:5: 444:6 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/librbml/lib.rs:439 pub fn tagged_docs<'a>(d: Doc<'a>, tag: usize) -> TaggedDocsIterator<'a> {
src/librbml/lib.rs:440 TaggedDocsIterator {
src/librbml/lib.rs:441 iter: docs(d),
src/librbml/lib.rs:442 tag: tag,
src/librbml/lib.rs:443 }
src/librbml/lib.rs:444 }
src/librbml/lib.rs:439:5: 444:6 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
src/librbml/lib.rs:858:30: 858:45 warning: `err.to_owned()` is faster [-W str-to-string]
src/librbml/lib.rs:858 ApplicationError(err.to_string())
^~~~~~~~~~~~~~~
src/librbml/lib.rs:858:30: 858:45 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#str_to_string
info: now are following matches for librbml-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.so
info: now are following matches for librbml-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librbml-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libtest-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libtest-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libtest-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libtest-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libtest/lib.rs
src/libtest/stats.rs:25:15: 25:21 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(x - y) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libtest/stats.rs:25 } else if x == y {
^~~~~~
src/libtest/stats.rs:25:15: 25:21 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libtest/stats.rs:171:13: 185:14 warning: the loop variable `i` is only used to index `partials`. Consider using `for item in &partials` or similar iterators [-W needless-range-loop]
src/libtest/stats.rs:171 for i in 0..partials.len() {
src/libtest/stats.rs:172 let mut y: f64 = partials[i];
src/libtest/stats.rs:173 if x.abs() < y.abs() {
src/libtest/stats.rs:174 mem::swap(&mut x, &mut y);
src/libtest/stats.rs:175 }
src/libtest/stats.rs:176 // Rounded `x+y` is stored in `hi` with round-off stored in
...
note: in expansion of for loop expansion
src/libtest/stats.rs:171:13: 185:14 note: expansion site
note: in expansion of for loop expansion
src/libtest/stats.rs:166:9: 192:10 note: expansion site
src/libtest/stats.rs:171:13: 185:14 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop
src/libtest/stats.rs:293:8: 293:22 warning: ==-comparison of f32 or f64 detected. Consider changing this to `abs(pct - hundred) < epsilon` for some suitable value of epsilon [-W float-cmp]
src/libtest/stats.rs:293 if pct == hundred {
^~~~~~~~~~~~~~
src/libtest/stats.rs:293:8: 293:22 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#float_cmp
src/libtest/lib.rs:622:9: 622:27 warning: unneeded return statement. Consider using `Ok(success)` without the return and trailing semicolon [-W needless-return]
src/libtest/lib.rs:622 return Ok(success);
^~~~~~~~~~~~~~~~~~
src/libtest/lib.rs:622:9: 622:27 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
src/libtest/lib.rs:724:5: 724:33 warning: unneeded return statement. Consider using `st.write_run_finish()` without the return and trailing semicolon [-W needless-return]
src/libtest/lib.rs:724 return st.write_run_finish();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libtest/lib.rs:724:5: 724:33 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_return
info: now are following matches for libtest-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.so
info: now are following matches for libtest-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libtest-a5fc0d6c.rlib
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.so"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libgraphviz-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libgraphviz-*.so' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.so
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'libgraphviz-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'libgraphviz-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/libgraphviz/lib.rs
src/libgraphviz/lib.rs:539:9: 543:10 warning: instead of prefixing all patterns with `&`, you can dereference the expression to match: `match *self { ...` [-W match-ref-pats]
src/libgraphviz/lib.rs:539 match self {
src/libgraphviz/lib.rs:540 &LabelStr(ref s) => format!("\"{}\"", s.escape_default()),
src/libgraphviz/lib.rs:541 &EscStr(ref s) => format!("\"{}\"", LabelText::escape_str(&s[..])),
src/libgraphviz/lib.rs:542 &HtmlStr(ref s) => format!("<{}>", s),
src/libgraphviz/lib.rs:543 }
src/libgraphviz/lib.rs:539:9: 543:10 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
src/libgraphviz/lib.rs:620:1: 624:2 warning: explicit lifetimes given in parameter types where they could be elided [-W needless-lifetimes]
src/libgraphviz/lib.rs:620 pub fn render<'a, N:Clone+'a, E:Clone+'a, G:Labeller<'a,N,E>+GraphWalk<'a,N,E>, W:Write>(
src/libgraphviz/lib.rs:621 g: &'a G,
src/libgraphviz/lib.rs:622 w: &mut W) -> io::Result<()> {
src/libgraphviz/lib.rs:623 render_opts(g, w, &[])
src/libgraphviz/lib.rs:624 }
src/libgraphviz/lib.rs:620:1: 624:2 help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
info: now are following matches for libgraphviz-*.so libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.so
info: now are following matches for libgraphviz-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libgraphviz-a5fc0d6c.rlib
MATCHES=""; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librustc_bitflags-*.so\' "libraries:" $MATCHES; rm $MATCHES ; fi
MATCHES="i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_bitflags-a5fc0d6c.rlib"; if [ -n "$MATCHES" ] ; then echo "warning: removing previous" \'librustc_bitflags-*.rlib\' "libraries:" $MATCHES; rm $MATCHES ; fi
warning: removing previous 'librustc_bitflags-*.rlib' libraries: i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_bitflags-a5fc0d6c.rlib
CFG_LLVM_LINKAGE_FILE=/home/andre/projects/rust/i686-unknown-linux-gnu/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/andre/projects/rust/i686-unknown-linux-gnu/stage2/lib:$LD_LIBRARY_PATH i686-unknown-linux-gnu/stage2/bin/rustc --cfg stage2 -O --cfg rtopt -L ~/projects/rust-clippy/target/release/ -Z extra-plugins=clippy -W clippy -A shadow-unrelated -A inline-always --target=i686-unknown-linux-gnu -C prefer-dynamic -L "i686-unknown-linux-gnu/rt" -L native="/home/andre/projects/rust/i686-unknown-linux-gnu/llvm/Release/lib" -Z always-build-mir --out-dir i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib -C extra-filename=-a5fc0d6c src/librustc_bitflags/lib.rs
info: now are following matches for librustc_bitflags-*.so libraries:
info: now are following matches for librustc_bitflags-*.rlib libraries:
i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc_bitflags-a5fc0d6c.rlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment