Last active
September 16, 2015 08:37
-
-
Save lnaia/b57a005c3856946e08e6 to your computer and use it in GitHub Desktop.
I would attempt the refactoring of method "extractContraints" here https://github.com/bichotll/FormValidationBundle/blob/master/Generator/ValidationField.php to the following:
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<?php | |
class ValidationField extends ContainerAware { | |
/** | |
* Helper - Extract all the constraints | |
*/ | |
private function extractContraints() | |
{ | |
// get validator | |
$validator = $this->container->get('validator'); | |
// get meta data from entity | |
$metadata = $validator->getMetadataFor($this->dataClass); | |
// loop through members | |
foreach ($metadata->members AS $property => $inner) { | |
if ($property != $this->pathName[0]) { | |
continue; | |
} | |
// init property name index | |
$this->constraints = array(); | |
$this->parseInnerDefinition($inner); | |
} | |
} | |
/** | |
* @param $inner | |
*/ | |
private function parseInnerDefinition($inner) | |
{ | |
foreach ($inner AS $definition) { | |
// if group | |
if (empty($this->validationGroups)) { | |
foreach ($definition->constraints AS $ungroupedConstraits) { | |
// add constraint object | |
$this->constraints['default'][] = $ungroupedConstraits; | |
} | |
} else { | |
$this->parseConstraintGroups($definition); | |
} | |
} | |
} | |
/** | |
* @param $definition | |
*/ | |
private function parseConstraintGroups($definition) | |
{ | |
foreach ($definition->constraintsByGroup AS $constraintGroup => $constraints) { | |
if (in_array($constraintGroup,$this->validationGroups)) { | |
foreach ($constraints AS $constraint) { | |
$this->constraints[$constraintGroup][] = $constraint; | |
} | |
} else { | |
$this->parseValidationGroups($constraintGroup, $constraints); | |
} | |
} | |
} | |
/** | |
* @param $constraintGroup | |
* @param $constraints | |
* @return mixed | |
*/ | |
private function parseValidationGroups($constraintGroup, $constraints) | |
{ | |
foreach ($this->validationGroups as $validationGroup) { | |
if (!in_array($constraintGroup, $validationGroup)) { | |
continue; | |
} | |
foreach ($constraints AS $constraint) { | |
$this->constraints[$constraintGroup][] = $constraint; | |
} | |
} | |
} | |
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<?php | |
namespace Bic\FormValidationBundle\Generator; | |
use Symfony\Component\DependencyInjection\ContainerAware; | |
use Symfony\Component\DependencyInjection\ContainerInterface; | |
class ValidationField extends ContainerAware { | |
/** | |
* @var array Full name of the field | |
*/ | |
private $pathName = array(); | |
/** | |
* @var array Validation groups | |
*/ | |
private $validationGroups = array(); | |
/** | |
* @var class Property parent class | |
*/ | |
private $dataClass; | |
/** | |
* @var array Validation constraints | |
*/ | |
private $constraints = array(); | |
/** | |
* Note: Return false if is a submit object | |
* | |
* @param \Symfony\Component\DependencyInjection\ContainerInterface $container | |
* @param \Symfony\Component\Form\FormInterface $form | |
* @return boolean | |
*/ | |
public function __construct(ContainerInterface $container, \Symfony\Component\Form\FormInterface $form) { | |
// set container | |
$this->setContainer($container); | |
//get pathName | |
$this->pathName[] = $form->getConfig()->getName(); | |
$this->getParentPathNames($form); | |
//break if it's a submit object | |
if ($this->pathName[0] == 'submit') { | |
return false; | |
} | |
//get validationGroups | |
$this->getParentValidationGroups($form); | |
//get dataClass | |
$this->getParentDataClasses($form); | |
//get constraints using the already code | |
$this->extractContraints(); | |
} | |
/** | |
* | |
* @param \Symfony\Component\Form\FormInterface $form | |
*/ | |
private function getParentPathNames(\Symfony\Component\Form\FormInterface $form) { | |
$parent = $form->getParent(); | |
if ($parent) { | |
$this->pathName[] = $parent->getConfig()->getName(); | |
$this->getParentPathNames($parent); | |
} | |
} | |
/** | |
* | |
* @param \Symfony\Component\Form\FormInterface $form | |
*/ | |
private function getParentValidationGroups(\Symfony\Component\Form\FormInterface $form) { | |
$parent = $form->getParent(); | |
$validationGroups = $parent->getConfig()->getOption('validation_groups'); | |
if ($parent && !empty($validationGroups)) { | |
$this->validationGroups[] = $parent->getConfig()->getOption('validation_groups'); | |
} | |
} | |
/** | |
* | |
* @param \Symfony\Component\Form\FormInterface $form | |
*/ | |
private function getParentDataClasses(\Symfony\Component\Form\FormInterface $form) { | |
$parent = $form->getParent(); | |
if ($parent->getConfig()->getDataClass()) { | |
$this->dataClass = $parent->getConfig()->getDataClass(); | |
} else if ($parent->getConfig()->getData()) { | |
$this->dataClass = $parent->getConfig()->getData(); | |
$this->assignProperDataClass(); | |
} else { | |
$this->getParentDataClasses($parent); | |
} | |
} | |
/** | |
* | |
* @return boolean | |
*/ | |
private function assignProperDataClass() { | |
if (is_array($this->dataClass)) { | |
foreach ($this->dataClass as $class) { | |
$className = strtolower(get_class($class)); | |
//todo to change this crappy problem...forgive me, I was upset enough with Symfony forms | |
$className = str_replace("\\", '.', $className); | |
$className = preg_replace('/[.]?[a-zA-Z]+[.]/', "", $className); | |
foreach ($this->pathName as $path) { | |
$path = strtolower($path); | |
if ($path == $className) { | |
$this->dataClass = $class; | |
return true; | |
} | |
} | |
if (property_exists($class, $this->pathName[0])) { | |
$this->dataClass = get_class($class); | |
} | |
} | |
} | |
} | |
/** | |
* Helper - Extract all the constraints | |
*/ | |
private function extractContraints() | |
{ | |
// get validator | |
$validator = $this->container->get('validator'); | |
// get meta data from entity | |
$metadata = $validator->getMetadataFor($this->dataClass); | |
// loop through members | |
foreach ($metadata->members AS $property => $inner) { | |
if ($property != $this->pathName[0]) { | |
continue; | |
} | |
// init property name index | |
$this->constraints = array(); | |
$this->parseInnerDefinition($inner); | |
} | |
} | |
/** | |
* @param $inner | |
*/ | |
private function parseInnerDefinition($inner) | |
{ | |
foreach ($inner AS $definition) { | |
// if group | |
if (empty($this->validationGroups)) { | |
foreach ($definition->constraints AS $ungroupedConstraits) { | |
// add constraint object | |
$this->constraints['default'][] = $ungroupedConstraits; | |
} | |
} else { | |
$this->parseConstraintGroups($definition); | |
} | |
} | |
} | |
/** | |
* @param $definition | |
*/ | |
private function parseConstraintGroups($definition) | |
{ | |
foreach ($definition->constraintsByGroup AS $constraintGroup => $constraints) { | |
if (in_array($constraintGroup,$this->validationGroups)) { | |
foreach ($constraints AS $constraint) { | |
$this->constraints[$constraintGroup][] = $constraint; | |
} | |
} else { | |
$this->parseValidationGroups($constraintGroup, $constraints); | |
} | |
} | |
} | |
/** | |
* @param $constraintGroup | |
* @param $constraints | |
* @return mixed | |
*/ | |
private function parseValidationGroups($constraintGroup, $constraints) | |
{ | |
foreach ($this->validationGroups as $validationGroup) { | |
if (!in_array($constraintGroup, $validationGroup)) { | |
continue; | |
} | |
foreach ($constraints AS $constraint) { | |
$this->constraints[$constraintGroup][] = $constraint; | |
} | |
} | |
} | |
/** | |
* @return string Field name | |
*/ | |
public function getName() { | |
return $this->pathName[0]; | |
} | |
/** | |
* @return array Field full name | |
*/ | |
public function getPathName() { | |
return $this->pathName; | |
} | |
/** | |
* @return array Validation groups | |
*/ | |
public function getValidationGroups() { | |
return $this->validationGroups; | |
} | |
/** | |
* @return string Parent class | |
*/ | |
public function getDataClass() { | |
return $this->dataClass; | |
} | |
/** | |
* @return array Constraints | |
*/ | |
public function getConstraints() { | |
return $this->constraints; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment