we added MultivaluePropertyCollection to more efficiently handle detection if an array property in PHPCR ODM changed or not .. guess we actually reduced performance and prevented people from using array functions easily .. doh!

performance optimization gone wrong

<?php


require 'vendor/doctrine/common/lib/Doctrine/Common/Collections/Collection.php';
require 'vendor/doctrine/common/lib/Doctrine/Common/Collections/Selectable.php';
require 'vendor/doctrine/common/lib/Doctrine/Common/Collections/ArrayCollection.php';
require 'vendor/doctrine/phpcr-odm/lib/Doctrine/ODM/PHPCR/PersistentCollection.php';
require 'vendor/doctrine/phpcr-odm/lib/Doctrine/ODM/PHPCR/MultivaluePropertyCollection.php';

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ODM\PHPCR\MultivaluePropertyCollection;

$array1 = array('foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar');
$array2 = array('foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', new \stdClass);
$collection = new MultivaluePropertyCollection(new ArrayCollection($array1));

$iterations = 10000000;

$times['init'] = microtime(true);
for ($i = 0; $i < $iterations; $i++)
    $collection->changed();
$times['$collection->changed()'] = microtime(true);
for ($i = 0; $i < $iterations; $i++)
    $array1 === $array2;
$times['$array1 === $array2   '] = microtime(true);
for ($i = 0; $i < $iterations; $i++)
    $array1 == $array2;
$times['$array1 == $array2    '] = microtime(true);
for ($i = 0; $i < $iterations; $i++)
    $array1 === $array1;
$times['$array1 === $array1   '] = microtime(true);
for ($i = 0; $i < $iterations; $i++)
    $array1 == $array1;
$times['$array1 == $array1    '] = microtime(true);

$previous_time = array_shift($times);
foreach ($times as $key => $time) {
    echo("$key: ".($time - $previous_time))."\n";
    $previous_time = $time;
}

/*
results without xdebug.so loaded:
$collection->changed(): 2.6968159675598
$array1 === $array2   : 1.0440990924835
$array1 == $array2    : 1.183198928833
$array1 === $array1   : 0.80106401443481
$array1 == $array1    : 1.1964271068573
 */