luhenry

We’ll be running all the following steps inside a ubuntu:latest docker container. This will help guarantee reproducibility. I’ll be using podman locally, but you can use docker with exactly the same steps. Do not forget to docker pull ubuntu:latest to have the latest version of that container locally.

Get the sources for PyTorch:

git clone --recursive [email protected]:pytorch/pytorch.git

As some riscv64 binaries will be run in the build and test process, you need to install QEMU on your host machine:

luhenry

#!/usr/bin/python3

## Dependencies: pip install torch torchvision pandas timm transformers

import pandas as pd
import sys
import torch
import torch.autograd.profiler as profiler
import torch.nn as nn
from enum import StrEnum, auto

luhenry

Java Concurrency Stress Tests
---------------------------------------------------------------------------------
Rev: ce8a2c7747e0232f, built by ludovic with 17.0.4.1 at 2023-08-07T09:53:34Z

Burning up to figure out the exact CPU count....... done!

Probing the target OS:
 (all failures are non-fatal, but may affect testing accuracy)

----- [OK] Trying to set global affinity with taskset

luhenry

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index f8d391ee98b..17f8208c15a 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -676,23 +676,9 @@ riscv_disassemble_insn (bfd_vma memaddr,
 			disassemble_info *info)
 {
   const struct riscv_opcode *op;
-  static bool init = false;
-  static const struct riscv_opcode *riscv_hash[OP_MASK_OP + 1];

luhenry

[ RUN      ] ParquetTpchTestBase/MultiParquetTpchTest.Q3/0
Plan Operators:
CallbackSink(5)<test_cursor 3:0.0 0x55556300ebf0
Limit(4)<test_cursor 3:0.0 0x555562e65dd0
OrderBy(3)<test_cursor 3:0.0 0x555562d12260
FilterProject(2)<test_cursor 3:0.0 0x555562e641b0
Aggregation(1)<test_cursor 3:0.0 0x7fffc40ffa80
LocalExchange(0)
-- HashJoin[INNER l_orderkey=o_orderkey] -> l_orderkey:INTEGER, o_orderdate:DATE, o_shippriority:INTEGER, part_revenue:DOUBLE
 allows duplicates

luhenry

root@a2f9d9ec22ee:/# more hs_err_pid3297.log
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGILL (0x4) at pc=0x0000003fa41e49ba, pid=3297, tid=3298
#
# JRE version:  (20.0.1+9) (build )
# Java VM: OpenJDK 64-Bit Server VM (20.0.1-beta+9-202306200336, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-riscv64)
# Problematic frame:
# v  ~BufferBlob::native signature handlers 0x0000003fa41e49ba

luhenry

diff --git a/velox/substrait/SubstraitToVeloxPlan.cpp b/velox/substrait/SubstraitToVeloxPlan.cpp
index 7dd849201..d1560b79b 100644
--- a/velox/substrait/SubstraitToVeloxPlan.cpp
+++ b/velox/substrait/SubstraitToVeloxPlan.cpp
@@ -1739,6 +1739,12 @@ void SubstraitVeloxPlanConverter::setFilterMap(
       }
       setColInfoMap<int64_t>(functionName, colIdxVal, val, reverse, colInfoMap);
       break;
+    case TypeKind::REAL:
+      if (substraitLit) {

luhenry

(189, 275332522724) -> (189, 275332522724) { 'count': 297744417 }
(189, 274926036140) -> (189, 274926036140) { 'count': 28031708 }
(189, 275346483392) -> (189, 275346483392) { 'count': 18012092 }
(189, 275332522758) -> (189, 275332522568) { 'count': 16804920 }
(189, 275332522568) -> (189, 275332522572) { 'count': 16804525 }
(189, 275335920462) -> (189, 275335920470) { 'count': 16132318 }
(189, 275335920506) -> (189, 275335920514) { 'count': 16132318 }
(189, 275346486754) -> (189, 275346486766) { 'count': 14994389 }
(189, 275346486766) -> (189, 275346486794) { 'count': 14675069 }
(189, 275332522724) -> (189, 275332522742) { 'count': 12726934 }

luhenry

export OPENJDK_DIR=/workspace/jdk
export OPENJDK_BUILD=/workspace/jdk/build/linux-riscv64-server-release/images/jdk
export TOP_DIR=$(pwd)
export TEST_DIR=$(pwd)
# export BUILD_LIST=openjdk,system/jcstress
export BUILD_LIST=openjdk
export BUILD_ROOT=$(pwd)/test-results
export JRE_IMAGE=/workspace/jdk/build/linux-riscv64-server-release/images/jdk
export TEST_JDK_HOME=/workspace/jdk/build/linux-riscv64-server-release/images/jdk
export TESTIMAGE_PATH=/workspace/jdk/build/linux-riscv64-server-release/images/test

luhenry

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 4d0c178479..f559026e2c 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -74,6 +74,8 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(h, false, PRIV_VERSION_1_12_0, ext_h),
     ISA_EXT_DATA_ENTRY(v, false, PRIV_VERSION_1_12_0, ext_v),
     ISA_EXT_DATA_ENTRY(zicsr, true, PRIV_VERSION_1_10_0, ext_icsr),
+    ISA_EXT_DATA_ENTRY(zicbom, true, PRIV_VERSION_1_10_0, ext_icbom),
+    ISA_EXT_DATA_ENTRY(zicboz, true, PRIV_VERSION_1_10_0, ext_icboz),