You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file lets an AI agent resume the PR #148 review session on a different machine without losing context. Read this file, then read rabbitmq-stream-s3-gh-148.md for the actual review output.
PR under review
Repo: amazon-mq/rabbitmq-stream-s3 (private)
PR: #148 - "Redesign upload path to behave like replication"
The issue is a review of what remains to be done for per-protocol connection limits. The stream plugin already has stream.max_connections and the web_mqtt plugin already has web_mqtt.max_connections. This document covers the implementation of mqtt.max_connections (PR #16367, under revision) and stomp.max_connections (PR #16368, open).
Status of PR #16367: The initial implementation used ranch:info(RanchRef) (same as the stream plugin). Reviewer @ansd identified that this gives a per-listener count, not a node-wide count. MQTT supports port-to-vhost mapping (multiple listeners on different ports), dual-stack (separate IPv4/IPv6 listeners), and mixed TCP/TLS deployments — each of which is a separate Ranch ref with its own supervisor. With four listeners and max_connections = 1000, the actual node limit would be 4000. The fix is to use the MQTT P
Scope: PR head 3878a85 (24 commits, +1377 / -259). Focus: correctness and design.
TL;DR
The layering is defensible and follows the RabbitMQ precedent for Mnesia-to-Khepri backends (recent-history, JMS, consistent-hash exchanges). Single-bucket timestamp-prefixed keys are a reasonable choice. But the Leveled backend has two critical correctness bugs: storage is never actually freed after delivery, and messages_delayed/1 is wrong for any exchange that has ever delivered a message. There are also several design and robustness issues around the gen_server / migration handoff and a macOS-hostile Makefile. The migration path has a documented "at-most-one extra delivery" tradeoff that is defensible but not exercised by the tests. The PR should not merge as-is; the two critical bugs are blockers. A follow-up topic branch has already landed fixes for several other items in this review; see the section below.
This document outlines the steps required if the chocolatey-community organization chooses to accept this template and its associated wiki as the official AU packages template.
This test demonstrates the PowerShell 7.3.0+ breaking change in empty string argument passing
and verifies that the fix using $null instead of '' works correctly.
The Bug
PowerShell 7.3.0+ changed how empty strings are passed to external commands:
When rabbitmqctl list_consumers -q | wc -l reports a significantly lower number of consumers than the Management UI → Global counts → Consumers, the mismatch is usually due to one or more of the following factors.
This pack is $849 new, selling for $450 plus shipping. Used on a trip up Mt Rainier and Glacier Peak in WA state. It’s a great pack but is more than what I need.
Size is Large. I am 5′ 10″ tall (70 inches / 177cm), 32″ waist, and average build. The pack fits perfectly.