Last active
June 12, 2023 00:46
-
-
Save m-bers/58612d97d813468cdd5f423fb435ece6 to your computer and use it in GitHub Desktop.
ACSO patch for Ubuntu mainline kernel (tested on 5.4.0-33-generic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/bin/bash | |
# VFIO ACS override patch script for Ubuntu | |
(tested on focal 5.4.0-33-generic), based on https://wiki.ubuntu.com/Kernel/BuildYourOwnKernel with patch spliced from https://gitlab.com/Queuecumber/linux-acs-override and | |
sudo add-apt-repository -s "deb http://us.archive.ubuntu.com/ubuntu $(lsb_release -cs) main" | |
sudo add-apt-repository -s "deb http://us.archive.ubuntu.com/ubuntu $(lsb_release -cs)-updates main" | |
sudo apt update && sudo apt dist-upgrade -y | |
sudo apt build-dep -y linux linux-image-$(uname -r) | |
sudo apt install -y libncurses-dev flex bison openssl libssl-dev dkms libelf-dev libudev-dev libpci-dev libiberty-dev autoconf git fakeroot | |
mkdir acso | |
cd acso | |
wget -nc https://gist.githubusercontent.com/jc4gavejc/58612d97d813468cdd5f423fb435ece6/raw/bf13c9700e90b8ac439a4e5d5296148fe6eec0a8/acso_patch_5_4_ubuntu.patch | |
apt source -y linux-image-unsigned-$(uname -r) | |
cd linux-* | |
chmod a+x debian/rules | |
chmod a+x debian/scripts/* | |
chmod a+x debian/scripts/misc/* | |
LANG=C fakeroot debian/rules clean | |
LANG=C fakeroot debian/rules editconfigs | |
git apply ../acso_patch_5_4_ubuntu.patch | |
sed -i '0,/)/s//-acso)/' debian/changelog | |
LANG=C fakeroot debian/rules clean | |
LANG=C fakeroot debian/rules DEB_BUILD_OPTIONS=parallel="$(nproc)" binary-headers binary-generic | |
cd .. | |
sudo dpkg -i *.deb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt | |
index 0bed972..eacae29 100644 | |
--- a/Documentation/admin-guide/kernel-parameters.txt | |
+++ b/Documentation/admin-guide/kernel-parameters.txt | |
@@ -3285,6 +3285,15 @@ | |
Also, it enforces the PCI Local Bus spec | |
rule that those bits should be 0 in system reset | |
events (useful for kexec/kdump cases). | |
+ pcie_acs_override = | |
+ [PCIE] Override missing PCIe ACS support for: | |
+ downstream | |
+ All downstream ports - full ACS capabilities | |
+ multfunction | |
+ All multifunction devices - multifunction ACS subset | |
+ id:nnnn:nnnn | |
+ Specfic device - full ACS capabilities | |
+ Specified as vid:did (vendor/device ID) in hex | |
noioapicquirk [APIC] Disable all boot interrupt quirks. | |
Safety option to keep boot IRQs enabled. This | |
should never be necessary. | |
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c | |
index 320255e5e8f8..d4aaf74c54df 100644 | |
--- a/drivers/pci/quirks.c | |
+++ b/drivers/pci/quirks.c | |
@@ -3483,6 +3483,106 @@ static void quirk_no_bus_reset(struct pci_dev *dev) | |
dev->dev_flags |= PCI_DEV_FLAGS_NO_BUS_RESET; | |
} | |
+static bool acs_on_downstream; | |
+static bool acs_on_multifunction; | |
+ | |
+#define NUM_ACS_IDS 16 | |
+struct acs_on_id { | |
+ unsigned short vendor; | |
+ unsigned short device; | |
+}; | |
+static struct acs_on_id acs_on_ids[NUM_ACS_IDS]; | |
+static u8 max_acs_id; | |
+ | |
+static __init int pcie_acs_override_setup(char *p) | |
+{ | |
+ if (!p) | |
+ return -EINVAL; | |
+ | |
+ while (*p) { | |
+ if (!strncmp(p, "downstream", 10)) | |
+ acs_on_downstream = true; | |
+ if (!strncmp(p, "multifunction", 13)) | |
+ acs_on_multifunction = true; | |
+ if (!strncmp(p, "id:", 3)) { | |
+ char opt[5]; | |
+ int ret; | |
+ long val; | |
+ | |
+ if (max_acs_id >= NUM_ACS_IDS - 1) { | |
+ pr_warn("Out of PCIe ACS override slots (%d)\n", | |
+ NUM_ACS_IDS); | |
+ goto next; | |
+ } | |
+ | |
+ p += 3; | |
+ snprintf(opt, 5, "%s", p); | |
+ ret = kstrtol(opt, 16, &val); | |
+ if (ret) { | |
+ pr_warn("PCIe ACS ID parse error %d\n", ret); | |
+ goto next; | |
+ } | |
+ acs_on_ids[max_acs_id].vendor = val; | |
+ | |
+ p += strcspn(p, ":"); | |
+ if (*p != ':') { | |
+ pr_warn("PCIe ACS invalid ID\n"); | |
+ goto next; | |
+ } | |
+ | |
+ p++; | |
+ snprintf(opt, 5, "%s", p); | |
+ ret = kstrtol(opt, 16, &val); | |
+ if (ret) { | |
+ pr_warn("PCIe ACS ID parse error %d\n", ret); | |
+ goto next; | |
+ } | |
+ acs_on_ids[max_acs_id].device = val; | |
+ max_acs_id++; | |
+ } | |
+next: | |
+ p += strcspn(p, ","); | |
+ if (*p == ',') | |
+ p++; | |
+ } | |
+ | |
+ if (acs_on_downstream || acs_on_multifunction || max_acs_id) | |
+ pr_warn("Warning: PCIe ACS overrides enabled; This may allow non-IOMMU protected peer-to-peer DMA\n"); | |
+ | |
+ return 0; | |
+} | |
+early_param("pcie_acs_override", pcie_acs_override_setup); | |
+ | |
+static int pcie_acs_overrides(struct pci_dev *dev, u16 acs_flags) | |
+{ | |
+ int i; | |
+ | |
+ /* Never override ACS for legacy devices or devices with ACS caps */ | |
+ if (!pci_is_pcie(dev) || | |
+ pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS)) | |
+ return -ENOTTY; | |
+ | |
+ for (i = 0; i < max_acs_id; i++) | |
+ if (acs_on_ids[i].vendor == dev->vendor && | |
+ acs_on_ids[i].device == dev->device) | |
+ return 1; | |
+ | |
+ switch (pci_pcie_type(dev)) { | |
+ case PCI_EXP_TYPE_DOWNSTREAM: | |
+ case PCI_EXP_TYPE_ROOT_PORT: | |
+ if (acs_on_downstream) | |
+ return 1; | |
+ break; | |
+ case PCI_EXP_TYPE_ENDPOINT: | |
+ case PCI_EXP_TYPE_UPSTREAM: | |
+ case PCI_EXP_TYPE_LEG_END: | |
+ case PCI_EXP_TYPE_RC_END: | |
+ if (acs_on_multifunction && dev->multifunction) | |
+ return 1; | |
+ } | |
+ | |
+ return -ENOTTY; | |
+} | |
/* | |
* Some Atheros AR9xxx and QCA988x chips do not behave after a bus reset. | |
* The device will throw a Link Down error on AER-capable systems and | |
@@ -4663,6 +4763,7 @@ static const struct pci_dev_acs_enabled { | |
{ PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs }, | |
/* Amazon Annapurna Labs */ | |
{ PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs }, | |
+ { PCI_ANY_ID, PCI_ANY_ID, pcie_acs_overrides }, | |
{ 0 } | |
}; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment