Skip to content

Instantly share code, notes, and snippets.

@makoto
Last active May 3, 2018 11:28
Show Gist options
  • Save makoto/6866634633f2999e1aabe3f6c66157a3 to your computer and use it in GitHub Desktop.
Save makoto/6866634633f2999e1aabe3f6c66157a3 to your computer and use it in GitHub Desktop.

Comparing branches

  1. https://github.com/ensdomains/dnssec-oracle/tree/delete-rrset ( currently under PR)
  2. https://github.com/ensdomains/dnssec-oracle/tree/delete-rrset-2 (rewrite)
  3. https://github.com/ensdomains/dnssec-oracle/tree/delete-rrset-3 (this version does not copy tails)

NOTES: I commented out the following tests from all the three branches as it is currently failing on #1.

Assert.equal(a_b_c.compareNames(d)      <  0, true, "one name has a difference of >1 label to the other");

Gas for testcompareNames test

  1.   ✓ testcompareNames (213529 gas)
    
  2.   ✓ testcompareNames (209737 gas)
    
  3.   ✓ testcompareNames (197817 gas)
    

Gas for deleteRRSet function

#  │  Contract  ·  Method          ·  Min      ·  Max      ·  Avg      ·  # calls     ·  usd (avg)  │
1. │  DNSSEC    ·  deleteRRSet     ·    26048  ·    28855  ·    26984  ·           3  ·       0.02  │
2. │  DNSSEC    ·  deleteRRSet     ·    24077  ·    28823  ·    25659  ·           3  ·       0.02  │
3. │  DNSSEC    ·  deleteRRSet     ·    24125  ·    27768  ·    25339  ·           3  ·       0.02  │
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment