mamhoff

### Keybase proof

I hereby claim:

  * I am mamhoff on github.
  * I am mamhoff (https://keybase.io/mamhoff) on keybase.
  * I have a public key ASDa7fPZoFkIjy6IyWfFYyDAmzFfDwGLtg7OajjPdzDAmAo

To claim this, I am signing this object:

mamhoff

Add a PaymentProvider class to model Payment Gateways with multiple Payment Methods

Currently, for historical reasons, the Solidus Source conflates the idea of a payment method and a payment gateway/provider.

When the payment system was first conceived, there were only two payment methods: "Check", which was a bogus payment method that essentially meant "We'll deal with it in cash", and "Credit Card", which had the additional complexity of needing a "Gateway" to process the credit card payments.

Things have changed since then. Companies have emerged that handle many payment methods (credit, credit card, direct debit, Apple/Android pay, SEPA). Within Solidus core, we have taken great care to allow multiple payment sources, so now we have the ability of identifying a nonce as a "Braintree token" or a "Spreedly credit card" - but we still conflate "payment method", the option a user chooses to pay, and "payment gateway", the company processing payments.

This PR changes that by moving the API calls from

mamhoff

Solidus Workshop

People

• Martin Meyerhoff (@mamhoff) Solidus Core team member
• Alessandro Lepore (@alepore) Committer for Solidus i18n gem

What is Solidus

• eCommerce framework for Ruby on Rails

mamhoff

module Spree
  ProductsController.class_eval do
    helper_method :sorting_param
    alias_method :old_index, :index

    def index
      old_index # Like calling super: http://stackoverflow.com/a/13806783/73673
      @products = @products.includes(:prices).send(sorting_scope)
    end

mamhoff

#! /bin/sh
### BEGIN INIT INFO
# Provides:          unicorn
# Required-Start:    $all
# Required-Stop:     $network $local_fs $syslog
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: starts the unicorn web server
# Description:       starts unicorn
### END INIT INFO

mamhoff

class AddLocations < ActiveRecord::Migration
  def change
    create_table :locations do |t|
      t.string :title, limit: 64
      t.integer :picture_id
      t.string :subtitle, limit: 64
      t.string :street, limit: 128
      t.string :number, limit: 16
      t.string :postal_code, limit: 10
      t.string :city, limit: 64

mamhoff

class AdminsController < ApplicationController
  def new
  	@admin = Admin.new
  end

  def show
  	@admin = Admin.find(params[:id])
  end

  def create

mamhoff

{
        "translatorID": "9405db4b-be7f-42ab-86ca-430226be9b35",
        "label": "Potsdamer Neueste Nachrichten",
        "creator": "Martin Meyerhoff",
        "target": "^http://www.pnn.de",
        "minVersion": "1.0",
        "maxVersion": "",
        "priority": 100,
        "inRepository": "1",
        "translatorType": 4,

mamhoff

{
        "translatorID": "e8e10bd4-fd6f-4297-a060-a8e0a479043f",
        "label": "Blaetter fuer deutsche und internationale Politik",
        "creator": "Martin Meyerhoff",
        "target": "^http://www\\.blaetter\\.de",
        "minVersion": "1.0",
        "maxVersion": "",
        "priority": 100,
        "inRepository": "1",
        "translatorType": 4,

mamhoff

{
        "translatorID": "1ab8b9a4-72b5-4ef4-adc8-4956a50718f7",
        "label": "Der Freitag",
        "creator": "Martin Meyerhoff",
        "target": "^http://www\\.freitag\\.de",
        "minVersion": "1.0",
        "maxVersion": "",
        "priority": 100,
        "inRepository": "1",
        "translatorType": 4,