Skip to content

Instantly share code, notes, and snippets.

@manuwell
Created December 15, 2016 13:05
Show Gist options
  • Save manuwell/edd6a164376ea6f3b146fbfd9fcbfd4e to your computer and use it in GitHub Desktop.
Save manuwell/edd6a164376ea6f3b146fbfd9fcbfd4e to your computer and use it in GitHub Desktop.
Pull Request Review Steps

For a good PR review you should consider the following topics

  1. It's proposal should be clear
  2. Code quality
  3. Readability
  4. Unexpected exception
  5. Security Issues
  6. Unexpected recursion
  7. Test readability
  8. Test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment