For a good PR review you should consider the following topics
- It's proposal should be clear
- Code quality
- Readability
- Unexpected exception
- Security Issues
- Unexpected recursion
- Test readability
- Test coverage
For a good PR review you should consider the following topics
| *H********************************************************************** | |
| * FILENAME : main.c | |
| * | |
| * DESCRIPTION : | |
| * Cadastro de pessoas com nome, idade e sexo e imprime as pessoas | |
| * do sexo feminino com idade até 28 anos (inclusive) | |
| * | |
| * | |
| * AUTHOR : Wellington Santos RA : 20993835 | |
| * |
| # convert pdf pages into multiple tiffs | |
| convert unidade_1.pdf pages-%03d.tiff | |
| # convert multiple pdf into tiff grayscaled | |
| convert unidade_1.pdf -gravity center -append -background white -alpha remove -alpha off -set colorspace Gray -separate -average unidade.tiff | |
| # with compress | |
| convert *.pdf -gravity center -append -background white -alpha remove -alpha off -separate -average -strip -quality 90 -depth 16 -compress Zip chargeback-3.tiff ; ls -ltrah *.tiff | |
| # working conversion tiff |
| @Slf4j | |
| @SpringBootApplication | |
| @EntityScan({ "com.app.domain.models" }) | |
| @EnableJpaRepositories({ "com.app.domain.repositories" }) | |
| @ComponentScan({ "com.app.config", "com.app.domain", "com.app.backoffice" }) | |
| @EnableAutoConfiguration | |
| public class BackofficeApplication { | |
| public static void main(String[] args) throws Exception { | |
| log.info("STARTING BACKOFFICE APPLICATION"); | |
| SpringApplication.run(BackofficeApplication.class, args); |
| #!/bin/sh | |
| # | |
| # Check for ruby style errors | |
| # To install follow: | |
| # 1. add this file to your repository .git/hooks/pre-commit | |
| # 2. chmod +x .git/hooks/pre-commit | |
| # | |
| # To skip rubocop checks, before you commit things do: | |
| # SKIP_RC=1 git commit -m 'my skipped commit' |
Perhaps talking to them and explain your point of view. Try to present the benefits you think you can get with rails panel. I think all will learn in the discussion.
But if you want to, I tested here and this works:
# in your Gemfile
# double exclamation (!!) point just to ensure to return a bool
gem 'meta_request', require: !!ENV['APP_WITH_RAILS_PANEL']| // planilhas de teste: | |
| // https://drive.google.com/drive/folders/19bJHxbbAcbky8dO0DB3-T2bmwtJCzc8P | |
| // para que esta função funcione vc. precisa: | |
| // . nomear o intervalo da coluna que guardará o status do sync com o nome "financeiro" | |
| // . criar uma aba chamada config-sync com 2 colunas: Config | Valor | |
| // . configurar as propriedades: | |
| // . URL Planilha Financeiro | |
| // . Aba Planilha Financeiro | |
| // . Cebeçalho (usar formula join para concatenar o cabecalho separado por ';') | |
| function sendToDestino() { |