Skip to content

Instantly share code, notes, and snippets.

@marbiano
Created November 7, 2014 18:31
Show Gist options
  • Save marbiano/eec73d29df6d9612d45d to your computer and use it in GitHub Desktop.
Save marbiano/eec73d29df6d9612d45d to your computer and use it in GitHub Desktop.
MINE
1. Needs general styling update.
2. Needs general responsive fine tuning.
3. Nav from logotype click feels a bit weird. Alternative would be logo linking to homepage and hamburguer icon to the right opening that menu.
4. Benton Sans and Benton Modern, to load them or not. Could be replaced with Helvetica/Arial and Georgia.
5. Poster view has styling bugs, need to review based on the CSS I already wrote.
6. Profile view is broken. Should we even hate it at v1 if you can't edit anything?
7. Signed-out landing needs some work.
JESH
/ Style Brand header
Depends wheter we decide to use something else other than logo. Otherwise it's fine without a header.
/ Style Alerts
Not seing any alert.
/ Style Nav
+1
/ Switch touch <> desktop messaging
Also placement, I think it would be better to have it at the bottom, in order to avoid people switching to desktop mode from their devices as much as possible.
/ Progressive enhancement
Let's talk about this.
/ How many breakpoints?
Depends, I had 2 for poster, but they were mostly for desktop resolutions. Need to think a bit about this one.
/ None for desktop?
Well, on story page I think it's fine having what we have right now. At devices width decent just in case, on desktop widths optimized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment