gistfile1.txt

[15:01:59] <nn-1> who doesn't love giant diffs
[15:03:19] <nn-1> so you were using the container
[15:03:27] <nn-1> so igorw/naderman told you to inject parameters which you did

-- Correct.

[15:03:32] <nn-1> then i told you to use the container
[15:03:40] <nn-1> and you went back to container

-- I kind of have trouble understanding what you mean with that.

[15:05:12] <nn-1> the order is static protected

-- I'll change those.

[15:05:20] <nn-1> you are missing docblocks on avatar manager properties

-- Do you mean the variables $config, $valid_drivers, $avatar_drivers, and $container? If yes, do we need a docblock for each of them?
   Only $valid_drivers will be altered outside of the __construct() method.
  
[15:06:39] <nn-1> is there a difference between valid driver and enabled driver?
[15:06:47] <nn-1> if no why two terms for the same thing?

-- Not anymore. I'll change that to enabled drivers.

[15:07:30] <nn-1> why do get_valid_drivers and get_all_drivers have different caching logic?

-- get_all_drivers() could be "cached" similar to get_valid_drivers(). This would result in the need for another class variable,
   i.e. $all_drivers. As this will only be called in the ACP I decided to leave this out.

[15:08:21] <nn-1> Marc: the order is static public

-- Will change.

[15:10:42] <nn-1> Marc: is there a prose description of user-visible changes?

-- See the RFC topic on Area 51: http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=32835&p=249771#p249771

[15:23:21] <nn-1> Marc: use plain include with class_exists
[15:23:25] <nn-1> not include_once

-- I'll change that now.