Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Save marinacor1/e1b7dcb3102d2c090f9a0ed9df3f9216 to your computer and use it in GitHub Desktop.
Save marinacor1/e1b7dcb3102d2c090f9a0ed9df3f9216 to your computer and use it in GitHub Desktop.
1602-mock-assessment-submission.markdown
@rrgayhart
Copy link

  • Logout functionality not present on show
  • Fields should clear after creating link
  • Strike through or other visual change to link when read
  • Remaining finished functionality

Testing is good as is, if it continues along with new features as they get added. JS coverage would be good (either by teaspoon or selenium) but not a requirement for passing the assessment, as model and controller tests are logically being used.

@joshuajhun
Copy link

  1. Satisfactory Progress

    3: Developer completes iterations 1 through 5 with few bugs and no missing functionality. (In the real final assessment, this will involve completing one supporting feature.)

  2. Ruby Syntax & Style

    3: Developer is able to write idiomatic and effective Ruby. Application makes good use of Object-Oriented modeling with few gaps in class identification and component extraction. Developer can speak to choices made in the code and knows what every line of code is doing.

  3. Rails Style & API

    3: Developer generally writes clean Rails features that make smart use of Ruby, with some struggles in pushing logic down the stack. The application displays good judgement in modeling the problem as data. Developer can speak to choices made in the code and knows what every line of code is doing.

  4. Javascript Syntax & Style

    3: Developer writes solid Javascript code using common patterns and idioms. Code is organized appropriately within objects and functions. Developer can speak to choices made in the code and knows what every line of code is doing.

  5. Testing

    4: Developer excels at taking small steps and using the tests for both design and verification. Developer uses integration tests, controller tests, and model tests where appropriate.

  6. User Interface

    3: The application has many strong pages/interactions, but a few holes in lesser-used functionality

  7. Workflow

    4: The developer effectively uses Git branches and many small, atomic commits that document the evolution of their application.

-ui and ux is pretty weak.

  • there are some bugs in the functionality but once you get through the bugs the feature delivers
  • bugs:
    • read/undread works but you have to click the thing twice
    • edit doesn't clear or add the idea directly to the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment