Skip to content

Instantly share code, notes, and snippets.

@marti1125
Created July 15, 2014 20:37
Show Gist options
  • Save marti1125/74fc37e938e6b2e81f29 to your computer and use it in GitHub Desktop.
Save marti1125/74fc37e938e6b2e81f29 to your computer and use it in GitHub Desktop.
last issue for fix
04:55:19 p.m. - marti1125: this ? https://issues.apache.org/jira/browse/CB-4556
04:55:55 p.m. - marti1125: what does mean r+ ?
04:57:22 p.m. - marti1125: https://issues.apache.org/jira/browse/CB-5610
04:57:29 p.m. - rodms: ah, r+ is a bugzilla thing we carried over :) It means it passed the review
04:57:54 p.m. - marti1125: ohhhh, :)
05:00:35 p.m. - rodms: marti1125: https://issues.apache.org/jira/browse/CB-4556 looks like a good one
05:00:59 p.m. - rodms: from the comment it needs a clean.bat file to work on windows
05:02:54 p.m. - rodms: CB-5610 is more involved, we need to investigate if it's even possible to implement the APIs in firefoxOS
05:03:06 p.m. - rodms: and it may only be possible on more recent versions
05:03:11 p.m. - marti1125: ok what repo I fork?
05:04:05 p.m. - rodms: for CB-4556 it's cordova-firefoxos
05:04:50 p.m. - rodms: the clean script is here: https://github.com/apache/cordova-firefoxos/blob/master/bin/templates/project/cordova/clean
05:05:15 p.m. - rodms: we need a .bat file similar to the one we have for the build script: https://github.com/apache/cordova-firefoxos/blob/master/bin/templates/project/cordova/build.bat
05:06:49 p.m. - marti1125: ok!!
05:07:13 p.m. - rodms: to test it, create a new cordova app and run:
05:07:17 p.m. - marti1125: I will do at night
05:07:22 p.m. - rodms: platforms/firefoxos/cordova/clean.bat
05:07:29 p.m. - rodms: on a windows platform
05:07:42 p.m. - rodms: you should see "Cleaning Firefoxos project"
05:08:19 p.m. - rodms: and the build folder should be removed
05:08:30 p.m. - rodms: the folder gets created when you run cordova build
05:09:00 p.m. - rodms: marti1125: thanks! :D No hurry
05:09:20 p.m. - marti1125: thank you for instructions
05:14:56 p.m. - marti1125: build folder is =?
05:16:38 p.m. - marti1125: https://cordova.apache.org/docs/en/3.0.0/guide_cli_index.md.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment