Last active
February 22, 2017 20:40
-
-
Save matanlurey/41854515caad364dfce7669663b9e52d to your computer and use it in GitHub Desktop.
An example of an unnecessary Completer usage in Dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import 'dart:async'; | |
final messageStorage = <String>[]; | |
Future save(String message) { | |
var completer = new Completer(); | |
new Future(() => messagesStorage.add(message)).then((_) => completer.complete()); | |
return completer.future; | |
} | |
Future<List<String>> getAll() { | |
var completer = new Completer(); | |
new Future(() => messagesStorage).then((List<String> messages) => completer.complete(messages)); | |
return completer.future; | |
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future<bool> doServe() async { | |
var c = new Completer(); | |
var httpServer = await HttpServer.bind(_SVhost, _SVport); | |
// Connection monitor timer | |
Timer monitor = new Timer.periodic(new Duration(seconds: 5), (_) { | |
var connInfo = httpServer.connectionsInfo(); | |
log("Connections[${connInfo.total}]: active[${connInfo.active}] idle[${connInfo.idle}] closing[${connInfo.closing}]"); | |
}); | |
httpServer.listen((request) { | |
log("Connection from [${request.connectionInfo.remoteAddress.toString()}] at [${request.connectionInfo.remotePort}]"); | |
request.response.writeln("Hello World!"); | |
request.response.close(); | |
c.complete(true); | |
}, | |
onError: (e) { | |
log.e("Error occured: ${e}"); | |
} | |
); | |
return c.future; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment