Skip to content

Instantly share code, notes, and snippets.

@matt-stj
Last active February 14, 2016 05:09
Show Gist options
  • Save matt-stj/43b1ed13ec3836c3b557 to your computer and use it in GitHub Desktop.
Save matt-stj/43b1ed13ec3836c3b557 to your computer and use it in GitHub Desktop.

##Leap My code: here

  • Responder #1 (here) - This responder showed that I could've written a much shorter function by condensing my if statements. By combinig all of my conditionals, I could've significantly reduced the number of lines that I needed to write.
  • Responder #2 (here) - This responder did a hybrid between the code I wrote and what Responder #1 wrote. This version is slightly less verbose than mine, but still not as clean as Responder #1's.
  • Responder #3 (here) - This is my favorite implementation yet ;). if(year === 2015) { return false; } Seems like it got the tests to pass, but won't work for any year other than 2015.
  • Responder #4 (here) - Lots of if statements. Seems like it could be a bit short with use of &&/||.
  • Responder #5 (here) - return false; Second favorite implementation.

##Hamming My code: here

  • Responder #1 (here) - Very similar to the way that I solved the problem, but decided to throw an error in an else portion of a conditional.
  • Responder #2 (here) - I like the way they broke their solution up into two functions. One conditional to check if the strings are valid, and then the call the comparison function if the strings meet the necessary criteria.
  • Responder #3 (here) - A little verbose with the split function and doesn't throw a real error.
  • Responder #4 (here) - Uses map function, but doesn't return a value - probably could've used a forEach instead.
  • Responder #5 (here) - almost identical to mine, but with better usage of naming variables.

##RNA Transcription My code: here

  • Responder #1 (here) - Really liked how this person set up a hash/collection of keys/values and just itereated through the dna sequence and referenced that.
  • Responder #2 (here) - Great use of string concatenation, without having to join array at the end. up a hash/collection of keys/values and just itereated through the dna sequence and referenced that.
  • Responder #3 (here) - Not sure how this implementation passed the tests to make it to submission, but with a solution of just 1 -- I'm impressed.
  • Responder #4 (here) - Similar to responder #2, really like the string concatenation.
  • Responder #5 (here) - Intersting use of map(). Could be shorter with proper return statements, but clever idea all around.
@rrgayhart
Copy link

Hey Matt - Instructions a little unclear, but you'd actually need to compare with 5 other implementations per exercism!

@matt-stj
Copy link
Author

Got it all cleared up - thanks Meeka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment