Skip to content

Instantly share code, notes, and snippets.

@mehulkar
Last active July 23, 2020 02:44
Show Gist options
  • Save mehulkar/8a88ec14f028be9dd6c1c9a7d8817b08 to your computer and use it in GitHub Desktop.
Save mehulkar/8a88ec14f028be9dd6c1c9a7d8817b08 to your computer and use it in GitHub Desktop.
max callstack size exceeded
import Controller from '@ember/controller';
import { reads } from '@ember/object/computed';
import { computed } from '@ember/object';
export default Controller.extend({
appName: 'Ember Twiddle',
foo: reads('bar'),
something: true,
bar: computed('foo', 'something', function() {
if (this.get('something')) {
return 'earlyreturn ';
}
// this getter causes an infinite loop
return this.foo;
}),
actions: {
toggleSomething() {
this.toggleProperty('something');
}
}
})
<h1>Welcome to {{this.appName}}</h1>
<p>Change the ember version in twiddle.json to see how this changes in 3.12.4 vs 3.13.0</p>
<p>In 3.12, everything renders and then when you toggle
the property so that the computed property will reach the infinite loop, it causes a RangeError.</p>
<p>In 3.13, the rest of the page never renders, because the computed property greedily looks at getters inside it, and causes the infinite loop.</p>
{{this.bar}}
<button {{action "toggleSomething"}}>toggle</button>
<br>
<br>
{
"version": "0.17.1",
"EmberENV": {
"FEATURES": {},
"_TEMPLATE_ONLY_GLIMMER_COMPONENTS": false,
"_APPLICATION_TEMPLATE_WRAPPER": true,
"_JQUERY_INTEGRATION": true
},
"options": {
"use_pods": false,
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.5.1/jquery.js",
"ember": "3.12.4",
"ember-template-compiler": "3.12.4",
"ember-testing": "3.12.4"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment