Pivot Notes

gistfile1.txt

app/controllers/admin/base_controller.rb
9: Redundant: won't current_user.admin? return nil if current_user is nil?

app/controllers/admin/items_controller.rb
Use strong params here?

app/controllers/admin/orders_controller.rb
Strong params

application_controller.rb
15: Address commented code, remove comment

carts_controller.rb
8: remove comment
Strong Params
#update_existing_cart: strong params could clean this up quite a bit, can we push this to model?

categories_controller.rb
Strong Params

items_controller.rb
Strong Params

orders_controller.rb
11-12: remove comments
17: possibly simplify and pull this out into a method?

sessions_controller.rb
Strong params

welcome_controller.rb
what is this for?

items_helper.rb
This feels weird to me. Does it belong here?

ability.rb
7-9: remove comments

item_order.rb
4-11: Remove comments

order.rb
Use scoping here?

presenter.rb
What are unique category names? Shouldn't they already be unique?

showcart.html.erb
22: pull this logic out

categories/new.html.erb
Empty file

items/show.html.erb
6: pull logic out

layouts/_nav_bar.html.erb
pull logic out / presenter class

orders/index.html.erb
18: Pull logic out

orders/show.html.erb
22-23: Pull logic out

sessions/index.html.erb
empty file

shared/_status_table.html.erb
2: pull logic out

routes.rb
Emily had some tips for us here.