misterdjules

nfml-jgilliXAH:find-my-way jgilli$ node --prof-process isolate-0x103802400-v8.log 
Code move event for unknown code: 0x30fac5d4de20
Code move event for unknown code: 0x30fac5d5d2f8
Statistical profiling result from isolate-0x103802400-v8.log, (61379 ticks, 1220 unaccounted, 0 excluded).

 [Shared libraries]:
   ticks  total  nonlib   name
   1916    3.1%          /usr/lib/system/libsystem_platform.dylib
    321    0.5%          /usr/lib/system/libsystem_pthread.dylib
    211    0.3%          /usr/lib/system/libsystem_malloc.dylib

misterdjules

The original goal of this ticket was to handle the case when a volume would
unexpectedly change its IP address on its existing network due to, e.g. operator
changes, migration or bugs.

The first implementation that has been tried at
https://github.com/joyent/sdc-vmapi/tree/ZAPI-793 updates the
{{internal_metadata}} of VMs that mount a given volume during their {{start}}
workflow and update the IP address of any volume that they require.

While this solves part of the original use case, it has the fundamental

misterdjules

var assert = require('assert-plus');
var fs = require('fs');
var https = require('https');
var url = require('url');
var util = require('util');
var vasync = require('vasync');
var XML = require('xml-simple');

var JENKINS_API_TOKEN = process.env.JENKINS_API_TOKEN;
assert.string(JENKINS_API_TOKEN, 'JENKINS_API_TOKEN');

misterdjules

➜  mountain-gorilla git:(master) ✗ git diff | cat
diff --git a/configure b/configure
index 9556013..eae0c94 100755
--- a/configure
+++ b/configure
@@ -283,39 +283,53 @@ function preload_bits_from_manta() {
     # of the actual latest path. Something similar but with a "-<buildstamp>"
     # instead of "-latest" and we'll grab that into latest_dir.
     #
-    local count=0

misterdjules

diff --git a/lib/machines.js b/lib/machines.js
index 1ae8960..681acc7 100644
--- a/lib/machines.js
+++ b/lib/machines.js
@@ -271,7 +271,7 @@ function getListOptions(req) {
 
     switch (req.params.type) {
     case 'smartmachine':
-        opts.predicate = '{ "and" [ ' +
+        opts.predicate = '{ "and": [ ' +

misterdjules

diff --git a/test/cnapi.test.js b/test/cnapi.test.js
index 6c67a44..169b7bc 100644
--- a/test/cnapi.test.js
+++ b/test/cnapi.test.js
@@ -8,10 +8,12 @@
  * Copyright (c) 2018, Joyent, Inc.
  */
 
+var assert = require('assert-plus');
 var bunyan = require('bunyan');

misterdjules

[2018-02-14T22:47:19.646Z]  WARN: muskie/27560 on 56564894-a7c2-470e-a218-3d859e7e1687: mako: connection failed (req_id=95747e03-ec42-4075-9721-317822b609c3, method=GET, path=/Joyent_Dev/public/builds/reg
istrar/master-latest, shark="[object SharkClient<17.stor.us-east.joyent.us>]")
    PoolFailedError: Pool 15b224b9-30d0-4214-8cf1-3fb68d8caa55 (17.stor.us-east.joyent.us) has failed and cannot take new requests.
        at Object._onImmediate (/opt/smartdc/muskie/node_modules/cueball/lib/pool.js:752:8)
        at processImmediate [as _immediateCallback] (timers.js:363:15)
[2018-02-14T22:47:19.648Z]  WARN: muskie/27560 on 56564894-a7c2-470e-a218-3d859e7e1687: request failed: internal error (req_id=95747e03-ec42-4075-9721-317822b609c3, method=GET, path=/Joyent_Dev/public/bui
lds/registrar/master-latest)
    InternalError: an unexpected error occurred
        at translateError (/opt/smartdc/muskie/lib/errors.js:681:13)
        at ServerResponse.formatJSON (/opt/smartdc/muskie/lib/server.js:51:16)

misterdjules

[root@15334da5-a188-4143-926c-25ff16f8c1d1 (nightly-1:binder2) ~]# pstack 5930
5930:   /lib/svc/bin/svc.startd
-----------------  lwp# 1 / thread# 1  --------------------
 feec3ee5 sigsuspend (8047dd0)
 0807625f main     (8047e1c, fef3f348, 8047e58, 805b2d8, 1, 8047e80) + 20e
 0805b2d8 _start_crt (1, 8047e80, fefd1f20, 0, 0, 0) + 97
 0805b1aa _start   (1, 8047f48, 0, 8047f60, 8047f80, 8047f91) + 1a
-----------------  lwp# 2 / thread# 2  --------------------
 feec3875 ioctl    (5, 63746502, 80edfa8)
 fed62fbd ct_event_read_critical (5, fed0efac, fed0efa8, 1, fef39d20, fedd2000) + 16

misterdjules

diff --git a/lib/errors.js b/lib/errors.js
index 825c42f..5f3f6a1 100644
--- a/lib/errors.js
+++ b/lib/errors.js
@@ -342,6 +342,18 @@ DefaultFabricNetworkNotConfiguredError.prototype.restCode =
     'DefaultFabricNetworkNotConfiguredError';
 DefaultFabricNetworkNotConfiguredError.prototype.statusCode = 409;
 
+function isDataVersionError(err) {
+    assert.object(err, 'err');

misterdjules

[root@headnode (coal) ~]# sdc-volapi /volumes | json -Ha -c 'state==="ready"'
{
  "uuid": "d0ae6d3d-28e5-cbe7-f1d0-efd9e783e606",
  "name": "test-volume",
  "owner_uuid": "a08085c4-1624-45c1-a004-c16e91efae1e",
  "size": 10240,
  "type": "tritonnfs",
  "create_timestamp": "2017-10-26T21:32:26.972Z",
  "state": "ready",
  "networks": [