[ ] a [ ] b
- c
- d
If user is careless, forgetting to put "- " before "[ ]", TODO list could get buggy.
Steps to reproduce bug:
- on parsed MD page of list above, tick "c" to note that "c" is done.
- Now, edit the file.
begin | |
require 'bundler/inline' | |
rescue LoadError => e | |
$stderr.puts 'Bundler version 1.10 or later is required. Please update your Bundler' | |
raise e | |
end | |
gemfile(true) do | |
source 'https://rubygems.org' | |
gem 'rails', github: 'rails/rails' |
[#<Net::LDAP::PDU:0x007fa610a7bf58 | |
@app_tag=4, | |
@ldap_controls=[], | |
@message_id=3, | |
@search_entry= | |
#<Net::LDAP::Entry:0x007fa610a7be90 | |
@myhash= | |
{:dn=>["uid=user1,ou=People,dc=rubyldap,dc=com"], | |
:uid=>["user1"], | |
:cn=>["user1"], |
[ ] a [ ] b
If user is careless, forgetting to put "- " before "[ ]", TODO list could get buggy.
Steps to reproduce bug:
I hereby claim:
To claim this, I am signing this object:
Based on the article: Using checklists for code review
In general, people are pretty good at the code review process, but it's sometimes surprising what can slip through. A natural consequence of the way our brains look at the world is that it's easy to pay a lot of attention to small details and code style flubs, and completely miss the big picture.
Obviously, not everything is applicable for every change. If the review request isn't making any changes to UI, then skip the first two checklists entirely. If a change is a bug fix, typically don't review it for architecture and design principles.
Put the big stuff first (e.g. architecture). You don't want to work through a ton of small issues before realizing that everything has to be rewritten.
Do a pass through the code for each and every item in the checklist. By only looking for a very specific type of defect, each pass goes relatively quickly, even for large changes. Focu
[ Launch: Tributary inlet ] 5433519 by mtodd
[ Launch: sin waves ] 5417194 by mtodd
require 'rubygems' | |
require 'yajl/json_gem' # or 'json' | |
require 'yaml' | |
puts JSON.parse($stdin.read.chomp).to_yaml |