Last active
December 2, 2020 15:14
-
-
Save n8yeung/79484cd4c01fa5b4d01af050fedfa201 to your computer and use it in GitHub Desktop.
Predictive Search Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 3 is the current line in the settings_data.json file. Line 4 is the fix which matches the type that the Predictive Search API is expecting | |
{ | |
"search_option": "products", | |
"search_option": "product" | |
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 3-7 is what is currently in style.scss.liquid. Line 9-13 is the proposed fix to allow the text elements in the search results to show up. | |
.search__results { | |
background-color: white; | |
margin-top: 0; | |
padding: 0; | |
} | |
.search__results { | |
background-color: {{ settings.header_bg_color }}; | |
margin-top: 0; | |
padding: 0; | |
} | |
Line 18 is the fix for having the search match the desktop experience previous it was 'white' but with this you will not need to create new settings for mobile. | |
.mobile-search { | |
form { | |
background-color: {{ settings.header_bg_color }}; | |
margin: 0; | |
padding: 10px 20px 0; | |
position: relative; | |
min-height: 70vh; | |
width: 100%; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update
A full working fix of the mobile search predictive search api for this recent Nov update is on my store https://northstarfox.com
I’ve also added some features to my product page and the announcement bar that has increased my conversion rate.