Skip to content

Instantly share code, notes, and snippets.

@nessamurmur
Last active November 10, 2015 19:14
Show Gist options
  • Select an option

  • Save nessamurmur/e62b2bb0e9fac5553c4b to your computer and use it in GitHub Desktop.

Select an option

Save nessamurmur/e62b2bb0e9fac5553c4b to your computer and use it in GitHub Desktop.
ownership.md

Code Ownership

Code Review

The time for:

  • mentorship
  • exemplifying how code review well
  • checking test coverage
  • design discussions
  • enforcing style guides
  • ensuring docs make sense

Contributing

  • how to contribute should be in the README of the repo
  • anything a contributor needs to know to be able to get tests running,
    code built, whatever else they'd need to be able to verify
    changes they make before submitting a patch for merging belongs
    in the README as well.

Documentation

Wiki level stuff

  • Cross-team / Organizational level people / process stuff: i.e. *Mozilla's Module Ownership doc
    • Style guides
    • How to do some generalized thing (write documentation, propose a standard, etc.)
  • 10,000 ft view of the whole system (diagrams of how services connect, etc.)
  • Narrative style explanations of broad / general ideas (architectural patterns, programming paradigms, patterns, etc.)

README level stuff

  • How to contribute
  • How to report a bug
  • How to request a feature
  • How to run tests
  • High level overview of build / deployment pipeline
  • narrative information about the particular repo
  • Where to look for useful / up to date API docs
  • Public API usage

API Docs level stuff

  • How a particular function works
  • Types
  • Doctests if possible
  • Low-level narrative stuff (i.e. how this class / function fits into other components)

Standards

A central place to find, propose, discuss standards. I'm partial to a git
repo hosted somewhere were patch requests with comments are (a la Github).

QUESTIONS

  • How to affect cultural change? (this shit can't be mandated... or at least when I've seen it tried it failed miserably (and somewhat predictably))...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment