Last active
August 29, 2015 14:04
-
-
Save niallsmart/eae69b4e826b1f881905 to your computer and use it in GitHub Desktop.
Fix for CircleCI build failure 5866
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d83cdc36a40fc090c02bc0e1df1eaf8687bd3ea4 | |
Author: Brent Wheeldon <[email protected]> | |
Date: Fri Jul 18 09:33:57 2014 -0400 | |
Don’t hide popovers in feature tests, this makes them really flaky. | |
diff --git a/app/assets/javascripts/common/directives/ht_deal_changed_popover_factory.coffee b/app/assets/javascripts/common/directives/ht_deal_changed_popover_factory.coffee | |
index a324389..19b88eb 100644 | |
--- a/app/assets/javascripts/common/directives/ht_deal_changed_popover_factory.coffee | |
+++ b/app/assets/javascripts/common/directives/ht_deal_changed_popover_factory.coffee | |
@@ -24,5 +24,5 @@ hightower.factory "htDealChangedPopoverFactory", ($timeout, $rootScope) -> | |
.on("click", "a.undo", undo) | |
.on("click", "i.close", closePopover) | |
- $timeout(closePopover, 3000) | |
+ $timeout(closePopover, 3000) if !hightowerEnvironment.isTest() || hightowerEnvironment.isJavascriptTest() | |
element.popover("show") | |
diff --git a/spec/support/feature_helpers/deal_helpers.rb b/spec/support/feature_helpers/deal_helpers.rb | |
index fd33be7..6a04822 100644 | |
--- a/spec/support/feature_helpers/deal_helpers.rb | |
+++ b/spec/support/feature_helpers/deal_helpers.rb | |
@@ -110,6 +110,7 @@ module DealHelpers | |
end | |
def undo_deal_stage_change | |
+ expect(page).to have_selector(".ht-deal-stage-changed-popover") | |
within ".deal-overview" do | |
click_on "Undo" | |
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment