Skip to content

Instantly share code, notes, and snippets.

@niksseif
Last active February 17, 2021 23:13
Show Gist options
  • Save niksseif/8c72e5825d4ad77fad22e6e2d6836f12 to your computer and use it in GitHub Desktop.
Save niksseif/8c72e5825d4ad77fad22e6e2d6836f12 to your computer and use it in GitHub Desktop.
Rachel + Shawn, Hang in there paired project

Hang In There Pair Project

Thanks for your work on this project!

Rubric score key (applies only to that section of the rubric):

  • 4: went beyond set learning goals; did self-teaching.
  • 3: exactly on track! great work!
  • 2: a little behind where we want to see you; study in this area to level up
  • 1: significantly behind where we want to see you; let’s do some pairing!

πŸ™Œ Notes on things to keep doing
🌱 Notes on things to improve on

Professionalism: 3.5
πŸ™Œ Commits are super even. Nice commit:PR ratio. PR template is used.Great job on that. πŸ™Œ Solid code reviews.
🌱 Your README should include a gif of your app.

**JavaScript Style & Implementation : **
πŸ™Œ Your code is clean, easy to follow, and indented very well. πŸ™Œ Great work using your knowledge of falsyness to keep your conditionals concise in saveCreatedposter function 🌱 In the showMynewPoster on line 173 showMyNewPoster function and on line 190 inside the deletePoster function there is an event.preventDefault() with event being undefined. If you need to use anonymous function to be able to pass the event through the functions. 🌱 Create one reusable function (with parameters) that will show/hide elements, rather than having so much repeated code.

Functional Expectations: 2
Application completes all the expectations of Iteration 3 and some 4 with bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment