Created
November 27, 2011 18:44
-
-
Save nistude/1397967 to your computer and use it in GitHub Desktop.
double('Foo') vs. Demeter's Law
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# in Rails | |
class BarCollection | |
def initialize | |
@bars = [Bar.new, Bar.new] | |
end | |
def get_bars | |
@bars | |
end | |
end | |
class Foo | |
def do_something | |
bars = BarCollection.new.get_bars | |
bars.each do |bar| | |
bar.something | |
end | |
end | |
end | |
----- | |
require 'foo' | |
require 'bar_collection' | |
describe Foo do | |
it 'does something' do | |
bars = doube(BarCollection) | |
bars.should_receive(:get_bars).and_return([double('Bar').as_null_object]) | |
foo = Foo.new | |
foo.do_something | |
end | |
end |
Excellent point, hadn't thought that far. Thanks! :)
That's actually a very interesting point, however. I think a blog post is in order!
just wrote up my learnings of the last couple of days: http://blog.nistu.de/2011/12/02/an-epiphany-in-test-driven-development/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see what you're saying, but you'd see the LoD violation if the spec said
bars.should_receive(:get_bars).and_return([Bar.new])
as well. It's not usingdouble('Bar')
that gets you there - it's setting the return value onshould_receive
. Make sense?