Code Review Discount Factor Mayur Patel

DiscountFactor.py

class DiscountFactor(object):
    '''
    Holds the discount factor for a specific date. Includes:
    1. referenceDate
    2. discountFactorDate
    3. factor
    '''

    def __init__(self, reference_date, discount_factor_date, discount_factor):
        '''
        We set the initial values
        '''
        self.reference_date = reference_date
        self.discount_factor_date = discount_factor_date
        self.discount_factor = discount_factor
    
    def __repr__(self):
        """Return a string representation of this class.
        """
        return self.__class__.__name__ + "(" + repr(self.reference_date) + "," + repr(self.discount_factor_date) + "," + repr(self.discountFactor) + ")"
    
    def __str__(self):
        """Return a human-friendly string for this class.
        """
        return self.__class__.__name__ + "(" + repr(self.reference_date.as_datetime()) + "," + repr(self.discount_factor_date.as_datetime()) + "," + repr(self.discountFactor) + ")"


def make(reference_date, discount_factor_date, discount_factor):
    '''
    Make a new DiscountFactor.
    reference_date -- SerialDate
    discount_factor_date -- SerialDate
    discount_factor -- double
    '''
    return DiscountFactor(reference_date, discount_factor_date, discount_factor)