Created
July 26, 2023 10:33
-
-
Save nsjames/0ca141e741425be19cfbb9e33b368dc0 to your computer and use it in GitHub Desktop.
PR Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [ ] I understand the purpose of this PR | |
- [ ] I have visually inspected every line of added and removed code | |
- [ ] I have analyzed the side effects of the additions and removals | |
- [ ] I have checked the code for quality: | |
- [ ] Names are coherent, descriptive, and consistent | |
- [ ] There are no superfluous comments, only ones that give context | |
- [ ] All code is self-explanatory | |
- [ ] The code does not repeat itself | |
- [ ] The code follows the project standards (indentation, spacing, etc) | |
- [ ] I have tested the code | |
- [ ] The test coverage is sufficient | |
- [ ] Unhappy paths are tested | |
- [ ] I have reviewed the dependencies | |
- [ ] No helper tiny libraries are imported | |
- [ ] No packages have security vulnerabilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment