Android shared preference observer using kotlin coroutines (1.3.0)

PreferenceExtensions.kt

inline fun <reified T> SharedPreferences.observeKey(key: String, default: T): Flow<T> = channelFlow {
    send(getItem(key, default))

    val listener = SharedPreferences.OnSharedPreferenceChangeListener { _, k ->
        if (key == k) {
            trySend(getItem(key, default))
        }
    }
    registerOnSharedPreferenceChangeListener(listener)

    awaitClose {
        unregisterOnSharedPreferenceChangeListener(listener)
    }
}

inline fun <reified T> SharedPreferences.getItem(key: String, default: T): T {
    @Suppress("UNCHECKED_CAST")
    return when (default) {
        is String -> getString(key, default) as T
        is Int -> getInt(key, default) as T
        is Long -> getLong(key, default) as T
        is Boolean -> getBoolean(key, default) as T
        is Float -> getFloat(key, default) as T
        is Set<*> -> getStringSet(key, default as Set<String>) as T
        else -> error("generic type not handled ${T::class.java.name}")
    }
}

I came with this solution:

    private fun SharedPreferences.userIdFlow(key: String, defValue: String?): Flow<String?> = callbackFlow {
        var currentValue = getString(key, defValue)

        val listener = SharedPreferences.OnSharedPreferenceChangeListener { _, k ->
            if (k == key) {
                val newValue = getString(key, defValue)
                if (newValue != currentValue) {
                    currentValue = newValue
                    trySend(newValue).isSuccess
                }
            }
        }

        registerOnSharedPreferenceChangeListener(listener)
        if (currentValue != null && currentValue!!.isNotEmpty()) {
            trySend(currentValue).isSuccess // emit current value immediately if not null and not empty
        }

        awaitClose { unregisterOnSharedPreferenceChangeListener(listener) }
    }

What's your analysis on it compared to yours?

@mobilekosmos as MutableSet is always also a Set, your code would never return a MutableSet.

Then again: why would you want to put a MutableSet into SharedPreferences in the first place? It would lose its mutability anyway the moment you serialize. And when you return it, you actually only ever get an immutable set. Which one could then make a mutable set at the call site, if needed.

I would just remove that when branch altogether.

What I'm using now is kind of a mix between @ologe's and @mobilekosmos 's approach:

inline fun <reified T> SharedPreferences.observeKey(
    coroutineScope: CoroutineScope,
    coroutineContextProvider: CoroutineContextProvider,
    key: String,
    default: T,
): Flow<T> = callbackFlow {
    trySend(getItem(coroutineContextProvider, key, default))

    val listener = SharedPreferences.OnSharedPreferenceChangeListener { _, k ->
        if (k == key) {
            coroutineScope.launch {
                trySend(getItem(coroutineContextProvider, key, default))
            }
        }
    }

    registerOnSharedPreferenceChangeListener(listener)

    awaitClose { unregisterOnSharedPreferenceChangeListener(listener) }
}.conflate()

suspend inline fun <reified T> SharedPreferences.getItem(
    coroutineContextProvider: CoroutineContextProvider,
    key: String,
    default: T,
): T = withContext(coroutineContextProvider.io) {
    @Suppress("UNCHECKED_CAST")
    when (default) {
        is String -> getString(key, default) as T
        is Int -> getInt(key, default) as T
        is Long -> getLong(key, default) as T
        is Boolean -> getBoolean(key, default) as T
        is Float -> getFloat(key, default) as T
        is Set<*> -> getStringSet(key, default as Set<String>) as T
        else -> throw IllegalArgumentException("generic type not handle ${T::class.java.name}")
    }
}

@ubuntudroid yeah probably handling MutableSet is not actually needed, I think the initial thought was that kotlin.collection.MutableSet translated into java.util.Set

btw about switching dispatcher, I think is unnecessary because if I remember correctly SharedPreferences is just a glorified HashMap, and everything is stored (additionally) in memory, the expensive part of the api is writing to disk

---

I'm also updating the gist to what I think is the cleanest way after almost 4 years 😄