A Better Refactor for Mike Henke

gistfile1.cfm

<cffunction	name=	"minorNamesToString"
			output=	"false"
			hint=	"I convert a query of minor names to a string.">
	<cfargument	name=	"qMinorNames" />

	<cfset	var	sMinorNames=		"" />
	<cfset	var	sPreviousLastName=	"" />

	<!---	Edge Case: 1 Name in Query	--->
	<cfif	qMinorNames.RecordCount EQ 1>
		<cfset	sMinorNames=	qMinorNames.First & " " & qMinorNames.Last />

		<cfreturn	sMinorNames />
	</cfif>

	<!---	Insure Names are in Alphabetical Order	--->
	<cfquery	name=	"qMinorNames"
				dbtype=	"query">
	SELECT
		qMinorNames.[First] ,
		qMinorNames.[Last]

	FROM	qMinorNames
	ORDER BY	qMinorNames.[Last] , qMinorNames.[First]

	</cfquery>

	<cfset	sPreviousLastName=	TRIM( qMinorNames.Last ) />
	<cfloop	query=	"qMinorNames">
		<!---	Add Last Name to Group	--->
		<cfif	Compare( sPreviousLastName , TRIM( qMinorNames.Last ) )>
			<cfset	sMinorNames&=	" " & sPreviousLastName />

		</cfif>

		<!---	Everything Except The Last Entry	--->
		<cfif	qMinorNames.CurrentRow LT qMinorNames.RecordCount>
			<cfset	sMinorNames=	ListAppend( sMinorNames , qMinorNames.First ) />

		</cfif>

		<!---	Store Last Name	--->
		<cfset	sPreviousLastName=	TRIM( qMinorNames.Last ) />
	</cfloop>

	<!---	Add Last Entry	--->
	<cfset	sMinorNames&=	" and #qMinorNames.First[ qMinorNames.RecordCount ]# #sPreviousLastName#" />

	<!---	Add Spaces After Commas	--->
	<cfset	sMinorNames=	sMinorNames.ReplaceAll( "," , ", " ) />

	<cfreturn	sMinorNames />
</cffunction>

<cfset	minornames=	minorNamesToString( MinorList ) />