Created
November 26, 2012 20:16
-
-
Save orend/4150344 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| odobzinski:~/lib/pelusa $ /Users/odobzinski/.rbenv/versions/rbx-2.0.0-rc1/1.9/bin/pelusa ~/dev_exclusions/assistly/lib/es_search/agent_builder.rb | |
| ϟ Pelusa ϟ | |
| ---------- | |
| /Users/odobzinski/dev_exclusions/assistly/lib/es_search/agent_builder.rb | |
| class TokenItem | |
| ✿ Is below 50 lines ✓ | |
| ✿ Uses less than 3 ivars ✗ | |
| This class uses 3 instance variables: @token, @type, @value. | |
| ✿ Respects Demeter law ✗ | |
| There are 1 Demeter law violations in lines 9. | |
| ✿ Doesn't use more than one indentation level inside methods ✓ | |
| ✿ Doesn't use else clauses ✓ | |
| ✿ Doesn't use getters, setters or properties ✗ | |
| There are getters, setters or properties in lines 5 | |
| ✿ Doesn't mix array instance variables with others ✓ | |
| ✿ Uses descriptive names ✓ | |
| ✿ Uses names of adequate length (less than 20) ✓ | |
| ✿ Methods have short argument lists ✓ | |
| ✿ Doesn't use eval statement ✓ | |
| class Search | |
| ✿ Is below 50 lines ✗ | |
| This class has 406 lines. | |
| ✿ Uses less than 3 ivars ✗ | |
| This class uses 9 instance variables: @site, @page, @per_page, @user_id, @override_channel_type_id, @search_object_type_id, @search_object_type, @search_term, @es_json. | |
| ✿ Respects Demeter law ✗ | |
| There are 70 Demeter law violations in lines 43, 54, 60, 73, 88, 89, 94, 98, 102, 105, 106, 109, 113, 116, 119, 122, 129, 133, 134, 149, 154, 155, 158, 169, 170, 171, 177, 178, 181, 186, 187, 188, 203, 208, 209, 210, 213, 225, 231, 233, 234, 235, 236, 237, 246, 261, 268, 273, 274, 275, 276, 277, 298, 335, 352, 356, 357, 358, 365, 366, 370, 393, 399, 403, 404, 406, 407, 415, 416, 421. | |
| ✿ Doesn't use more than one indentation level inside methods ✗ | |
| There's too much indentation in lines 292, 285, 102, 105, 106, 113, 116, 119, 122, 125, 129, 132, 135, 138, 139, 148, 154, 158, 161, 164, 167, 170, 176, 178, 184, 188, 189, 198, 206, 210, 211, 214, 219, 228, 231, 232, 239, 245, 249, 254, 259, 261, 265, 267, 272, 282, 287, 317. | |
| ✿ Doesn't use else clauses ✗ | |
| There are 15 else clauses in lines 54, 100, 109, 142, 149, 155, 181, 192, 195, 203, 213, 217, 225, 267, 347 | |
| ✿ Doesn't use getters, setters or properties ✗ | |
| There are getters, setters or properties in lines 31, 35 | |
| ✿ Doesn't mix array instance variables with others ✓ | |
| ✿ Uses descriptive names ✗ | |
| Names are too short: to (line 276, 277, 278, 279) | |
| ✿ Uses names of adequate length (less than 20) ✗ | |
| These names are too long: @override_channel_type_id (line 45, 87, 88, 89, 230), set_search_object_type (line 48, 343), @search_object_type_id (line 50, 57, 60, 370, 403), interpreted_query_items= (line 66), interpreted_query_items (line 89, 155, 298, 366, 406, 416), append_search_filters (line 103, 107, 110, 114, 117, 120, 123, 130, 151, 159, 162, 165, 174, 182, 204, 226, 246, 257, 262, 269, 280, 413), append_search_queries (line 126, 127, 252, 363), searching_by_company? (line 127, 351), get_best_matched_group (line 193), get_best_matched_user (line 217), search_object_type_or_id (line 344, 345, 347), ticket_general_search (line 374), customer_general_search (line 390), company_general_search (line 396), custom_field_by_label (line 404) | |
| ✿ Methods have short argument lists ✓ | |
| ✿ Doesn't use eval statement ✓ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment