to tap or not to tap?

no_tap.rb

def do_it(ids)
  contacts = contact_finder(ids)
  contacts = contacts.my_nice_scope if should_apply_nice_scope?
  contacts
end

tap.rb

def do_it(ids)
  contact_finder(ids).tap do |contacts|
    return contacts.my_nice_scope if should_apply_nice_scope?
  end
end

Is returning inside tap really that bad? :P

I like the no_tap version, because it communicates everything at a glance. You're fetching contacts, then maybe filtering them or not, and returning them. The second version is way more complicated to understand at a glance (and has the same LOC).

+1 to the no_tap version