Skip to content

Instantly share code, notes, and snippets.

@orta
Created March 26, 2017 08:34
Show Gist options
  • Save orta/3f6910b1dba50b8e68bd4b761bb56c97 to your computer and use it in GitHub Desktop.
Save orta/3f6910b1dba50b8e68bd4b761bb56c97 to your computer and use it in GitHub Desktop.
Notes on trying now.sh for staging peril

now.sh notes

Setup

Deployment via docker works great, got something deployed in like ~10m

Running now with a dockerfile + npm, shows > Two manifests found. Press [n] to deploy or re-run with --flag but now help and now deploy help dont show that flag existing, and running now --flag 2 did nothing.

Read the source code, looks like it's refering to the > [1] package.json --npm - --npm bit. Some minor wording could improve that. I know they're ESL, so it's understandable. These are also mentioned at the end of now help.

I did add "type": "docker", to my now.json but that's being ignored.

Post Deployment

I feel like I'm leaving deployments everywhere... Do they expire?

Leaks

Leaked my private env vars ( assumed it would use gitignore to not OSS my ENV vars JSON files) Went and deleted all previous deployments, not sure how to test ENV vars aren't getting leaked Once I figure this, I should PR to this doc page: https://zeit.co/docs/features/env-and-secrets

This seemed to show what's up: vercel/vercel#157 (comment) Time to build a now.json.

Expected now.json to be used automatically. Using this JSON made me need to log in each time?

{
  "alias": "peril-staging"
}

Read the source code, looks like it's automatic on ~/.now.json - https://github.com/zeit/now-cli/blob/1f85f6d5db908141f15ed91fc639070c38ce8b55/lib/cfg.js#L10 Docs for this file are in the blog: https://zeit.co/blog/now-json - The blog post implies it's now.json not .now.json.

I would have expected with a now.json in my folder the config to be a merge of ~/.now.json with now.json.

Found https://zeit.co/docs/features/configuration#files Hrm, I wonder if it's my .dockerignore

Docs

Docs are good though ( I can refresh a page and they work ) Regularly seeing "An unexpected error has occurred." whe I assume the isomorphic JS is happening on https://zeit.co/* in Safari

Aliasing

Aliasing feels strange, I need to run now alias https://peril-rqpxhgxxir.now.sh peril-staging or whatever after every deploy to have a consistent url for my github integration. Maybe I missed something. I did miss something, I can add it to my now.json. The docs don't mention this. https://zeit.co/docs/features/aliases

Having this in the now.json

{
  "type": "docker",
  "name": "peril-staging",
  "alias": "peril-staging"
}

did not set the alias: now --docker

> Deploying ~/dev/projects/danger/peril
> Ready! https://peril-staging-lycvurxggy.now.sh (copied to clipboard) [2s]
> Upload [====================] 100% 0.0s
> Sync complete (1.81kB) [2s]
> Initializing…
> Building
> ▲ docker build
> Removing intermediate container ced21467f917
> Step 7 : EXPOSE 80
>  ---> Running in d4678bb8097d
>  ---> 1dd6570582d9
> Removing intermediate container d4678bb8097d
> Step 8 : CMD npm start
>  ---> Running in 83b83486cc5e
>  ---> e2204577f182
> Removing intermediate container 83b83486cc5e
> Successfully built e2204577f182
> ▲ Storing image
> ▲ Deploying image
> ▲ Container started
> Deployment complete!

Running

Wish I could have logging, had to add papertrail to my app, would love a heroku logs equivilent

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment