Skip to content

Instantly share code, notes, and snippets.

@oxinabox
Last active October 2, 2018 10:24
Show Gist options
  • Save oxinabox/68809d39bd52b1b387e396d28ad823e0 to your computer and use it in GitHub Desktop.
Save oxinabox/68809d39bd52b1b387e396d28ad823e0 to your computer and use it in GitHub Desktop.
Easy issues to fix for UCC Learn to Open Source

Easy issues to fix for UCC Learn to Open Source

When you open the PR, put on the end

cc @oxinabox

so I get notifications.

Delete blank-line (Done, Frames)

so comment is closer to variables that it is talking about on https://github.com/JuliaLang/julia/blob/master/base/special/trig.jl#L58

Fix spaces around operators (Mathew)

All infix operators should have spaces around them a-b => a - b

https://github.com/JuliaLang/julia/blob/8484f97844c452f15e628d4369ebc3007be0b81e/base/special/rem_pio2.jl#L316-L322

Update docs to say BitSet instead of String (Donald)

JuliaLang/julia#29454

Julia Logging Imports

Change everything to using rather than import in https://github.com/JuliaLang/julia/blob/master/stdlib/Logging/src/Logging.jl#L11 except for handle_message, shouldlog, min_enabled_level, catch_exceptions

use dot-points in handle_message doc-string (Cy)

https://github.com/JuliaLang/julia/blob/master/base/logging.jl#L38

Normalize captialization in orgnames (Nick)

https://github.com/JuliaLang/www.julialang.org/blob/master/ecosystems/index.md

Delete redundant comment that is repreated in docstring (Markus)

https://github.com/JuliaLang/julia/blob/master/base/logging.jl#L73

use :: to specify type in doc string (Felix)

https://github.com/JuliaLang/julia/blob/master/base/logging.jl#L159-L176

  • _module=mod => _module::Module

  • _group=symbol => _group::Symbol

  • _id=symbol => _id::Symbol

  • _file=string => _file::AbstractString

  • _line=integer => _line::Integer

etc

Remove constraint on BruteTree metric type.

KristofferC/NearestNeighbors.jl#75

Removing deprecations From DataStructures.jl

Delete lines starting with @deprecate When making PR, not that current is version 0.14, and they were deprecated in version 0.12 or earlier.

https://github.com/JuliaCollections/DataStructures.jl

Correct mix of tabs and spaces in MixtureDistributions.jl

https://github.com/matbesancon/MixedDistributions.jl/blob/master/src/MixedDistributions.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment