Skip to content

Instantly share code, notes, and snippets.

@pcwalton
Created September 19, 2016 20:32
Show Gist options
  • Save pcwalton/d7222943066e86194dab758f99b46608 to your computer and use it in GitHub Desktop.
Save pcwalton/d7222943066e86194dab758f99b46608 to your computer and use it in GitHub Desktop.
commit 68f55384b5c29e83a675e8cdba7858e972e5068d
Author: Patrick Walton <[email protected]>
Date: Mon Sep 19 13:30:48 2016 -0700
layout: Make `baseline_offset_of_last_line_box_in_flow()` only check
blocks in flow.
Improves python.org.
Closes #12124.
diff --git a/components/layout/flow.rs b/components/layout/flow.rs
index 2476e24..36b8da6 100644
--- a/components/layout/flow.rs
+++ b/components/layout/flow.rs
@@ -1405,7 +1405,8 @@ impl<'a> ImmutableFlowUtils for &'a Flow {
return kid.as_inline().baseline_offset_of_last_line()
}
if kid.is_block_like() &&
- kid.as_block().formatting_context_type() == FormattingContextType::None {
+ kid.as_block().formatting_context_type() == FormattingContextType::None &&
+ !base(kid).flags.contains(IS_ABSOLUTELY_POSITIONED) {
if let Some(baseline_offset) = kid.baseline_offset_of_last_line_box_in_flow() {
return Some(base(kid).position.start.b + baseline_offset)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment