Skip to content

Instantly share code, notes, and snippets.

@philsof

philsof/code-review-pair-andy4626,lnagle93-design-drill-argument-order-dependency-challenge.md

Last active January 28, 2016 17:37
Show Gist options
  • Save philsof/b642aa7de8fc995f2e2e to your computer and use it in GitHub Desktop.
Save philsof/b642aa7de8fc995f2e2e to your computer and use it in GitHub Desktop.
Download ZIP
Code review pair-andy4626,lnagle93 design-drill-argument-order-dependency-challenge
Raw
code-review-pair-andy4626,lnagle93-design-drill-argument-order-dependency-challenge.md

Good work! Here are my notes on your code:

  • Good overall use of fetch. Take a look at this for some subtle differences when using fetch that you will need to be aware of. (It looks like you are already aware, but just to make sure.) Notice specifically how nil and false values are handled differently by fetch and [] ||.
  • Interesting choice to pass default values to only four specific attributes. I am guessing you did this just to see what it would do? If so, good job on exploring.
  • Good job using fetch for setting boolean values. If instead you utilized [] || it would have set both variables to true, which you would not want. Sweet!

Any questions, let me know. 👍

-Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment