philsof

Good stuff. Here are my notes on your code:

• Your anagrams? method is sweet. You got this one 100%.
• You chose to use map to iterate through each word in list_arr. This works, but it is a misuse of map. Why? Because map has a specific function: to iterate through an existing array, perform the same action on each object in the existing array, and return a new array that contains the resulting objects. Since you do not need to do this in your find_anagrams method, map is not a good choice.
• BUT, your logic is sound. You are iterating through the list_arr, checking each objec

philsof

Nice work on this one. Here are my notes on your code:

• Your factorial_iterative method does the job concisely, but not as concisely as possible. Specifically, your if condition only handles zero, but not 1. Since you already have if n == 0 you might as well catch 1 with this line also, so a good refactor would be if n <= 1. That way, if n is 1 you don't end up creating an array of [1] and running reduce on it.
• Your reduce is super sharp. Sweet!
• Your factorial_recursive method is short and sweet, and it takes care of 0 and 1

philsof

Good effort on this, you are thisclose! Here are my notes on your code:

• When I go into the console and enter User.new for the first time, a new User is instantiated, but I also get this warning message: /Users/Phil/.../active-record-associations-drill-shirts-challenge/app/models/user.rb:10: warning: duplicated key at line 10 ignored: :through

  /Users/Phil/.../active-record-associations-drill-shirts-challenge/app/models/user.rb:12: warning: duplicated key at line 12 ignored: :through

This is because you are chaining through: statements on lines 10 and 12 of your User model. T

philsof

Good work! Here are my notes on your code:

• Nice work creating your own sort function. (Javascript is stupid, it sorts integers as if they are strings. <~~~ FYI this book is the best on JavaScript.)
• On this line you use ==. Avoid == in JavaScript. Use === instead. This is why.
• Watch out with ++ and --. This is why.
• Your countBetween is really so

philsof

Good work! Everything is solid except for what is mentioned below. So if it's not below, you are good. Here are my notes on your code:

##Views##

• When I go to the edit form at http://localhost:9393/entries/:id/edit the body of the existing entry does not show in the corresponding input field. It looks like this is because you are utilizing a textarea tag in your entries/edit view. Heads up: It doesn't look like the textarea tag supports the value attribute, according to the docs. That would explain why the body doesn't show on the edit form. You will need to fix this, since the user will think the entry doesn't have a body at all (which is not true).
• Watch out: Your entries/new view cannot handle a request from a user w

philsof

Good work! Here are my notes on your code:

• Good overall use of fetch. Take a look at this for some subtle differences when using fetch that you will need to be aware of. (It looks like you are already aware, but just to make sure.) Notice specifically how nil and false values are handled differently by fetch and [] ||.
• Interesting choice to pass default values to only four specific attributes. I am guessing you did this just to see what it would do? If so, good job on exploring.
• Good job using fetch for setting boolean values. If instead you utilized `[] |

philsof

This does the job. Good work. Here are my notes on your code:

• It looks like you unnecessarily separated the parsing work into two methods, your get_list method and your parse_people_objects_from_file method. All of this logic could be contained within parse_people_objects_from_file; there is no need to separate some of the logic into a get_list method. This is how you could combine both methods:

  def parse_people_objects_from_file
    csv_row_objects = []
    CSV.foreach('people.csv', headers: true) do |line|
      csv_row_objects.push(line)
    end

philsof

Good work! Per your desire to sharpen your MVC skills, here are some detailed notes on your code:

• You have a puts call in your Display class's initialize method. Instead, you are going to want your Controller to utilize your Display.look_at_this method to print this initial welcome text to the console:

  @viewer.look_at_this("Welcome to the World's Simplest Browser")

Or, you could write a specific Display method for this:

philsof

Good work! Your code does the job. Here are my notes on your code:

• You are utilizing jQuery's on method for a click event on your form's submit button, which works. But there is a better way. Because we are dealing with a form's submit action, you could utilize jQuery's on method for a submit event, which would look like this:

  $('#style_editor').on('submit', function(event) {  //#style-editor is the id of the form

  Notice the submit event only requires you to locate the form (it automatically knows you are referring to the form's submit action). When binding event handlers to form submit actions, you are going to want to utilize this.

Note: You could also utilize jQuery's submit method directly.

philsof

Good work, here are my notes on your code:

• Watch out: your post controller is allowing user_id to be passed as a param. This means a client could easily spoof themselves as another user and create posts as someone else (by passing someone else's user_id in the params, perhaps via a command-line http tool like curl). You are going to want to remove user_id from your post_params method and instead hard code the adding of user_id to the post via session.user_id. You always want to get your user id from the session.user_id, since session cannot be spoofed.
• Instead on using find_by when searching by a unique id number (like you do [here](https://github.com/nyc-chorus-frogs-2016/build-a-rails-blog/blob/pair-edwardgemson%2Ckerryimai/blog/app/controllers/pos