Skip to content

Instantly share code, notes, and snippets.

@piedoom
Created August 3, 2018 21:24
Show Gist options
  • Save piedoom/18ad71db5bed1f30a95130b68fe45917 to your computer and use it in GitHub Desktop.
Save piedoom/18ad71db5bed1f30a95130b68fe45917 to your computer and use it in GitHub Desktop.
@piedoom
Copy link
Author

piedoom commented Aug 3, 2018

  1. keep changes simple; understand that someone will be reviewing your changes and keep that in mind to be tidy and clear,

  2. Tackle one issue per PR. If you have multiple changes that affect unrelated parts of the codebase, consider breaking them up into separate requests

  3. all changes should have a reason, e.g. "as a developer, this will make the repository easier to maintain" or "as a user, this API change will make dealing with buffers more intuitive". Changes for the sake of changes will not be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment