Peter Karman pkarman

Norms for teams that use GitHub

This template is designed as a list of examples, questions and/or prompts for teams to discuss as they build norms around using GitHub.

We prefer a directory layout that looks like:

Are there tests?
Are tests clearly testing (at least) the AC?
Are variables named helpfully?
Are methods and classes named helpfully?
Do code quality checks pass?
Were any code quality checks disabled?
Are comments helpful? (Do they repeat what's in the code, or explain why? prefer the latter)

Table	Column	Type	Required	Primary Key	Unique	Index	Description
advance_on_docket_motions
advance_on_docket_motions	created_at	datetime ∗	true	false	false
advance_on_docket_motions	granted	boolean	false	false	false		Whether VLJ has determined that there is sufficient cause to fast-track an appeal, i.e. grant or deny the motion to AOD.
advance_on_docket_motions	id	integer (8) PK	true	true	false
advance_on_docket_motions	person_id	integer (8) FK	false	false	false	true	Appellant ID
advance_on_docket_motions	reason	string	false	false	false		VLJ's rationale for their decision on motion to AOD.
advance_on_docket_motions	updated_at	datetime ∗	true	false	false	true
advance_on_docket_motions	user_id	integer (8) FK	false	false	false	true
allocations

	SELECT "appeals".*
	FROM "appeals"
	WHERE "appeals"."established_at" IS NOT NULL
	AND ( ( appeals.updated_at >= '2021/01/01' )
	OR ( appeals.id IN (SELECT "request_issues"."decision_review_id"
	FROM "request_issues"
	WHERE ( request_issues.updated_at >=
	'2021/01/01' )
	AND
	( request_issues.decision_review_type = 'Appeal' )

	* How does Rails handle sessions?
	* How does Rails handle authentication?
	* How does SSO work?
	* What went wrong?

	vh = BusinessLine.find_by(url: 'vha')
	rows = vha.tasks.open.includes(:appeal).order(id: :asc).map do
	\|t\| [
	t.appeal.intake&.user&.css_id,
	t.id,
	"https://appeals.cf.ds.va.gov/decision_reviews/vha/tasks/#{t.id}",
	t.appeal_id,
	t.appeal_type,
	t.appeal.veteran_file_number,
	t.created_at

	RequestStore[:current_user] = User.system_user

	rca = RampClosedAppeal.find 72882

	# this should end in error
	rca.reclose!

	vacols_case_id = 3415206

	# double check at each step

	ready:
	h=`docker-compose ps \| grep healthy`; while [ "$$h" == "" ]; do h=`docker-compose ps \| grep healthy`; echo $$h; sleep 1; done

	up:
	docker-compose up -d

	run: up ready
	foreman start

	test: clean

	#!/usr/bin/env perl
	use strict;
	use warnings;
	use Data::Dump qw( dump );

	sub run {
	my $c = shift;
	my $cmd = "docker-compose -f my-docker-compose.yml run id -- $c";
	print $cmd, $/;
	my @out = `$cmd`;