Skip to content

Instantly share code, notes, and snippets.

@polbins
Last active February 29, 2024 09:58
Show Gist options
  • Select an option

  • Save polbins/e37206fbc444207c0e92 to your computer and use it in GitHub Desktop.

Select an option

Save polbins/e37206fbc444207c0e92 to your computer and use it in GitHub Desktop.
Simple RecyclerView Divider

Simple RecyclerView Divider

Simple Horizontal Divider Item Decoration for RecyclerView

    mRecyclerView.addItemDecoration(new SimpleDividerItemDecoration(
            getApplicationContext()
    	));

NOTE: Add item decoration prior to setting the adapter

<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle">
<size
android:width="1dp"
android:height="1dp" />
<solid android:color="@color/dark_gray" />
</shape>
public class SimpleDividerItemDecoration extends RecyclerView.ItemDecoration {
private Drawable mDivider;
public SimpleDividerItemDecoration(Context context) {
mDivider = context.getResources().getDrawable(R.drawable.line_divider);
}
@Override
public void onDrawOver(Canvas c, RecyclerView parent, RecyclerView.State state) {
int left = parent.getPaddingLeft();
int right = parent.getWidth() - parent.getPaddingRight();
int childCount = parent.getChildCount();
for (int i = 0; i < childCount; i++) {
View child = parent.getChildAt(i);
RecyclerView.LayoutParams params = (RecyclerView.LayoutParams) child.getLayoutParams();
int top = child.getBottom() + params.bottomMargin;
int bottom = top + mDivider.getIntrinsicHeight();
mDivider.setBounds(left, top, right, bottom);
mDivider.draw(c);
}
}
}
@fazlurr

fazlurr commented Feb 6, 2015

Copy link
Copy Markdown

Works like a charm, Thanks!

@AmauryEsparza

Copy link
Copy Markdown

It works, thanks

@Solid-Color-Labs

Copy link
Copy Markdown

Is there any way to make this work with a grid layout?

@bohbra

bohbra commented Mar 13, 2015

Copy link
Copy Markdown

I notice the divider is being drawn on top of the scrollbar, anyway around this?

@Leaking

Leaking commented Mar 17, 2015

Copy link
Copy Markdown

@keyoh
the onDrawover() method will draw the divider on the top of the item view。as a result, it also draws on the top of the scrollbar

@PsyGik

PsyGik commented Apr 22, 2015

Copy link
Copy Markdown

The proposed code above adds a divider to every item including the last item.

So one can even use

<View 
  android:id="@+id/divider"
  android:layout_width="match_parent"
  android:layout_height="1dp"
  android:background="@color/holo_gray_light" />

in the layout for the item to get the same effect.

As a workaround, in the adapter I check if the child is the last item and change the visibility of the divider accordingly.

 @Override
    public void onBindViewHolder(ViewHolder viewHolder, final int position) {
       if(position==getItemCount()) //check if this is the last child, if yes then hide the divider
         viewHolder.divider.setVisibility(View.GONE);
    }

Any suggestions on this are welcome

@elikohen

Copy link
Copy Markdown

It works like a charm! I wanted to use only the onDraw method so I added this other override to add space for the drawable:

@Override
public void getItemOffsets(Rect outRect, View view, RecyclerView parent, RecyclerView.State state) {
    outRect.bottom = mDivider.getIntrinsicHeight();
}

I hope it helps someone. Thanks!

@willblaschko

Copy link
Copy Markdown

@PsyGik

A couple quick comments: because the views are recycled, you'll want to make it visible if it's not the last item. You'll also never trigger this because position will never equal getItemCount() (as long as you're returning something like List.size()). Otherwise looks like a solid alternative that'll work with ListViews too :)

Here's a quick update to your code:

int visible = (position == getItemCount()-1) ? View.GONE : View.VISIBLE;
holder.divider.setVisibility(visible);

@jonasbleyl

Copy link
Copy Markdown

Thanks, works well.
Though getDrawable(int) is deprecated now. Use this instead:

ContextCompat.getDrawable(context, R.drawable.line_divider);

@erwinjnefer

Copy link
Copy Markdown

Thank's so much... it's work ....

@bangiqi

bangiqi commented Oct 6, 2015

Copy link
Copy Markdown

@jonasbleyl : where is ContextCompat declaration?

@chrisvoronin

Copy link
Copy Markdown

ContextCompat is in the support library. ContextCompat.getDrawable(context, resourceID)

@yosisah

yosisah commented Nov 10, 2015

Copy link
Copy Markdown

Thanks, works great.

@krupalshah

Copy link
Copy Markdown

thanks

@Gnzlt

Gnzlt commented Jan 4, 2016

Copy link
Copy Markdown

Nice Work!
I've also included the default Android listDivider drawable inside the constructor if you don't want to implement a custom one:

public SimpleDividerItemDecoration(Context context) {
    final TypedArray a = context.obtainStyledAttributes(new int[]{android.R.attr.listDivider});
    mDivider = a.getDrawable(0);
    a.recycle();
}

@aantthony

aantthony commented Apr 23, 2016

Copy link
Copy Markdown

Thanks.
I used this:

ResourcesCompat.getDrawable(context.getResources(), R.drawable.line_divider, context.getTheme());

@Rupali1992

Copy link
Copy Markdown

I am not able to set divider to my RecyclerView can somebody help me for this?......

ResourcesCompat.getDrawable(context.getResources(), R.drawable.line_divider, context.getTheme());

where should i used this above code?please specify the location

@jovisalonga072714

Copy link
Copy Markdown

Tried many, but this works like magic.

Thanks

@ParisaRashidi

Copy link
Copy Markdown

it works
thanks alot

@jayhack7

Copy link
Copy Markdown

Works perfectly. Thank you

@okadaNana

Copy link
Copy Markdown

Good

@zhonglushu

Copy link
Copy Markdown

I think custom drawable is not work

@axellebot

axellebot commented Mar 7, 2017

Copy link
Copy Markdown

Hello,
Maybe use
ContextCompat

public SimpleDividerItemDecoration(Context context) { mDivider = ContextCompat.getDrawable(context, R.drawable.line_divider); }

@Gematlive

Copy link
Copy Markdown

Thanks a lot

@archigoel

Copy link
Copy Markdown

Thanks,It worked!!

@androidqasim

Copy link
Copy Markdown

593835000c9841a6b0f2d8d9d0bb6ec9
how can i made this?

@paulomcnally

Copy link
Copy Markdown

https://developer.android.com/reference/android/support/v7/widget/DividerItemDecoration.html

val linearLayoutManager = LinearLayoutManager(this)
val dividerItemDecoration = DividerItemDecoration(recyclerView.context, linearLayoutManager.orientation)

// Init recyclerView
recyclerView.setHasFixedSize(true)
recyclerView.layoutManager = linearLayoutManager
recyclerView.addItemDecoration(dividerItemDecoration)

@Geet-Thakur01

Geet-Thakur01 commented May 9, 2018

Copy link
Copy Markdown

Use "card view" for item layout and set "margin top" according to your requirement.
:)

@jkhin

jkhin commented Sep 4, 2018

Copy link
Copy Markdown

It works beauty... Thanks!

@vsg24

vsg24 commented Jan 9, 2019

Copy link
Copy Markdown

If you don't want the last item to have a divider line after it, simply change for (int i = 0; i < childCount; i++) { to for (int i = 0; i < childCount - 1; i++) { and it will skip the last item divider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment